I’m assuming invalidation should be insensitive to scope, no?

IIRC it is not sensitive to scope, no.

Well, something weird’s going on

The task needs to set invalidate_dependents though

But also: are these resources?

actually, it might just be a missing dep… 🙂

Hold that thought

There is a special case in zinc compile for resources

Missing deps aren't a thing anymore afaik (edit: for jvm)

not resources

Yeah, this is more complicated, this is bad invalidation logic in a custom task

OK, this was due to me not passing

invalidate_dependents=True

in a custom task

That really should be the default

It’s far better to do too much work, than not enough...

Our contrib tests now take almost 50 minutes on travis

Which is a shame

Hi, I'm having a problem with

binary

vs

bundle

and the scala compiler. I'm creating an ssh repl which, when I build with binary, can correctly find org.scala-lang.scala-compiler`. Run with

java -jar <big binary jar>

.

2017-03-08T02:01:11,480Z INFO  [MyScalaSshShell-api] SshCommand - New ssh client connected
[Loaded org.apache.sshd.common.channel.Window$2 from file:/tmp/mitesh/query-api.jar]
[Loaded scala.tools.nsc.interpreter.MemberHandlers from file:/tmp/mitesh/query-api.jar]
[Loaded scala.tools.nsc.interpreter.ReplGlobal from file:/tmp/mitesh/query-api.jar]

However the same code, run with

java -jar <bundle jar>

, cant seem to find it.

2017-03-08T02:28:43,492Z ERROR  [MyScalaSshShell-api] CrashingThread - Unhandled exception:
scala.reflect.internal.MissingRequirementError: object scala in compiler mirror not found.
  scala.reflect.internal.MissingRequirementError$.signal(MissingRequirementError.scala:17)

It does find some of the classes, but I guess not all of them.

[Loaded scala.tools.nsc.interpreter.ReplGlobal$replPhase$ from file:/tmp/mitesh2/libs/1stparty.co.actioniq.flame-146.jar]
[Loaded scala.tools.nsc.interpreter.jline.InteractiveReader from file:/tmp/mitesh2/libs/1stparty.co.actioniq.flame-146.jar]

Not entirely sure if this is an issue with the repl or the way pants built the bundle. I know I had to set

scala.tools.nsc.Settings.javacp=true

( to force scala to use the java-classpath). I set the classpath on it too...I figure it must be working because the same code works with

binary

. I confirmed that

-146.jar

does in fact have the

ReplGlobal

class.

Hi, I’m trying to add a task to the existing

binary

goal that I want to be the very last thing to happen. I have registered it successfully on the goal and it is being run, just not at the right time. As per the here: http://www.pantsbuild.org/dev_tasks.html#task-installation-associate-task-with-goals I understand that you need to have a

prepare

method that declares

round_manager.require_data()

with a product_type. After looking through the source code I found that this is the class that I want my task to be executed after: https://github.com/pantsbuild/pants/blob/d30cca1e0ecb9cc0e1b7e2cd0ff6e7e077e62a52/contrib/go/src/python/pants/contrib/go/tasks/go_binary_create.py. However,

GoBinaryCreate

doesn’t implement the method

product_types

. Am I right then that there is no way for me to tell my task to happen after GoBinaryCreate? I guess I could make a pull request adding the

product_types

method, but I would like to know if there is another way before I go that direction. Thanks!

@victorious-potato-60449 does the task you are adding use anything from GoBinaryCreate?

then, adding

product_types

to GoBinaryCreate would make sense. Alternatively, I think if you make sure your tasks’ registration is registered after GoBinaryCreate, it will be run after GoBinaryCreate.

hi - is there a way to write a task that depends only on a list of files but not the contents of the files themselves? I need to write some tasks that generate files that contain lists of files that match a pattern. I want these to only be regenerated if the list of files in the source directory changes, but not regenerate if the contents of these files changes.

Hm. that sounds like you want a different fingerprint strategy for that task—assuming it’s about the task not caring about the contents of the files, and other tasks may care.

Yeah, you want a “DirectoryListingFingerprintStrategy” or something

Do we have custom fprint strategy examples in the pants repo?

Do you guys keep a registry of product types somewhere, so that one can know what's possible to demand from the round_manager?

Is there an easy way to add a third party dep to loose-source plugins, or do you have to roll a full package somehow?

Add the requirement to the

plugins

stanza in your pants.ini

E.g.,

plugins: [
    'protobuf==3.2.0'
  ]

It’s not very intuitive, alas