pantsbuild #general

Channels

welcome

github-notifications

announce

witty-crayon-22786

02/09/2017, 7:53 PM

a patch to do that would be good prolly?

able-airport-54778

02/09/2017, 8:24 PM

hey all, I have (for big organizational issues) a need to have 2 versions of an external library in my repo. When I do a compile of the entire repo, compilation fails due to one place expecting a class that was only available in the 2.xx branch, or another place that wants to reference a new class in the 3.xx. Any suggestions for how to handle this? Is there a good way to relocate a jar_library, or some other strategy?

witty-crayon-22786

02/09/2017, 8:27 PM

twitter stopped compiling "the entire repo" a long time ago, so CI builds roots output by

./pants minimize ::

independently.

witty-crayon-22786

02/09/2017, 8:27 PM

but square gets around it using "dependency management"

witty-crayon-22786

02/09/2017, 8:28 PM

http://www.pantsbuild.org/3rdparty_jvm.html#managing-transitive-dependencies

witty-crayon-22786

02/09/2017, 8:28 PM

i can't really vouch for it, but.

able-airport-54778

02/09/2017, 8:30 PM

yeah I looked at the jar-dependency-management bundle option. and played around w/ the options there. Its good for setting defaults but I don't think solves the problem of if you need to have both 2.x and 3.x to compile the entire project

able-airport-54778

02/09/2017, 8:30 PM

the only way I think that could work is if I could change the package name of one of them

witty-crayon-22786

02/09/2017, 8:31 PM

@able-airport-54778 : depends on the definition of "the entire project"

witty-crayon-22786

02/09/2017, 8:31 PM

is there a single root/binary that needs both versions

able-airport-54778

02/09/2017, 8:31 PM

witty-crayon-22786

02/09/2017, 8:31 PM

ok.

able-airport-54778

02/09/2017, 8:31 PM

but for running tests we "binary ::"

witty-crayon-22786

02/09/2017, 8:32 PM

see above.

witty-crayon-22786

02/09/2017, 8:32 PM

both of the solutions i mentioned are for that case.

witty-crayon-22786

02/09/2017, 8:33 PM

concretely, what we do would look like:

for root in ./pants minimize ::; do ./pants binary $root; done

witty-crayon-22786

02/09/2017, 8:33 PM

except we do it in parallel in CI

witty-crayon-22786

02/09/2017, 8:33 PM

across many workers

witty-crayon-22786

02/09/2017, 8:33 PM

minimize

outputs roots that cover the entire repo

witty-crayon-22786

02/09/2017, 8:34 PM

...that cover the set of targets selected (

::

in this case)

able-airport-54778

02/09/2017, 8:35 PM

ah cool. let me take a look at that then

mysterious-action-44812

02/09/2017, 9:54 PM

is there a way to rename the final bundle name, e.g. right now i have stuff generated like

dist/reporting.src.main.scala.co.actioniq.reporting.reporting-bin-bundle

mysterious-action-44812

02/09/2017, 9:55 PM

also I have an “uber-target”

deploy

that depends on a bunch of jvm_app targets, trying to build many bundles at once, but doing

./pants bundle :deploy

doesnt seem to actually build them?

mysterious-action-44812

02/09/2017, 9:56 PM

specifically https://gist.github.com/nitay/0f8c52e8dd8f8d8b56de3c0a28984eef

mysterious-action-44812

02/09/2017, 9:56 PM

where each dep is a jvm_binary target (also tried jvm_app)

full-kilobyte-93429

02/09/2017, 9:56 PM

that would be

basename

full-kilobyte-93429

02/09/2017, 9:57 PM

the difference is

id

based naming is guaranteed to be unique,

basename

loses that guarantee

mysterious-action-44812

02/09/2017, 10:02 PM

@full-kilobyte-93429 tried it didnt change anything?

mysterious-action-44812

02/09/2017, 10:02 PM

i want e.g.

dist/reporting

mysterious-action-44812

02/09/2017, 10:03 PM

i added basename to both binary and app rules, didnt change anything