https://pantsbuild.org/ logo
Powered by
#general
  • b

    billions-airport-86951

    01/23/2017, 5:19 PM
    Okay; seems to be easy to fix (locally it's working anyway) will see what I can do...
  • e

    enough-analyst-54434

    01/23/2017, 5:19 PM
    The key is for folks not like you who have no slf4j impl - as long as that case + yours works - we're good
  • a

    acceptable-scooter-37412

    01/23/2017, 5:20 PM
    @enough-analyst-54434 here is the source of the plugin: http://pastebin.com/8K59SYjq
  • e

    enough-analyst-54434

    01/23/2017, 5:20 PM
    and what pants version just in case?
  • a

    acceptable-scooter-37412

    01/23/2017, 5:21 PM
    1.2.0
  • e

    enough-analyst-54434

    01/23/2017, 5:21 PM
    Also @acceptable-scooter-37412 - need the code that installs that plugin
  • e

    enough-analyst-54434

    01/23/2017, 5:21 PM
    one or 2 lines
  • a

    acceptable-scooter-37412

    01/23/2017, 5:21 PM
    ah yes, sorry
  • a

    acceptable-scooter-37412

    01/23/2017, 5:21 PM
    Copy code
    def register_goals():
    task(name='build-properties', action=BuildPropertiesTask, serialize=False).install('resources')
  • e

    enough-analyst-54434

    01/23/2017, 5:21 PM
    k
  • e

    enough-analyst-54434

    01/23/2017, 5:22 PM
    Well, the fundamental problem is this is modeled around resource targets, so your task will only ever run when resources change
  • e

    enough-analyst-54434

    01/23/2017, 5:23 PM
    you want to run basically always
  • e

    enough-analyst-54434

    01/23/2017, 5:24 PM
    looking more...
  • e

    enough-analyst-54434

    01/23/2017, 5:25 PM
    yeah - you restrict to jvmbinary targets, but you really want to re-gen whenever those jvm binary targets or any of their dependencies change
  • e

    enough-analyst-54434

    01/23/2017, 5:25 PM
    So I think you may just need to fix your impl of 
    find_all_relevant_resources_targets
  • e

    enough-analyst-54434

    01/23/2017, 5:26 PM
    So, fix to add "or any of their dependencies" and I think things will work as expected.
  • e

    enough-analyst-54434

    01/23/2017, 5:27 PM
    If that does the trick and the interface docs for 
    find_all_relevant_resources_targets
    were misleading, a PR to make those more clear would be welcome.
  • f

    fast-megabyte-33579

    01/23/2017, 5:28 PM
    I am 99% certain the source code for that plugin was copy/pasted from someone on here
  • e

    enough-analyst-54434

    01/23/2017, 5:28 PM
    🙂
  • f

    fast-megabyte-33579

    01/23/2017, 5:28 PM
    for which I put my hand up and apologise for not checking the definition
  • e

    enough-analyst-54434

    01/23/2017, 5:28 PM
    Well, its a weird definition - it talks about resources, but it can be used w/o dealing with resources at all
  • f

    fast-megabyte-33579

    01/23/2017, 5:29 PM
    yeah, I think I think it’s a ResourceTask because it creates resources
  • e

    enough-analyst-54434

    01/23/2017, 5:29 PM
    In your case it deals with jvm_binary roots, which can have resources interior nodes, but...
  • e

    enough-analyst-54434

    01/23/2017, 5:29 PM
    Yeah - exactly. The docs for 
    find_all_relevant_resources_targets
    are just not too good.
  • f

    fast-megabyte-33579

    01/23/2017, 5:30 PM
    thanks John - we’ll take a look
  • e

    enough-analyst-54434

    01/23/2017, 5:30 PM
    @acceptable-scooter-37412 hopefully this makes some sense. You report the roots, you need to report their closure
  • e

    enough-analyst-54434

    01/23/2017, 5:30 PM
    cool
  • b

    billions-airport-86951

    01/23/2017, 5:32 PM
    Created an issue: https://github.com/pantsbuild/pants/issues/4197 I'll see if I can put together a PR for this.
  • e

    enough-analyst-54434

    01/23/2017, 5:37 PM
    OK great - ty. I noted the key bit of missing config in the issue. The crux will be - is there a main for cobertura-instrument and cobertura-run
  • e

    enough-analyst-54434

    01/23/2017, 5:37 PM
    I think there are
1...159615971598...2420Latest