pantsbuild #general

Channels

welcome

github-notifications

announce

flaky-twilight-29457

12/20/2016, 4:10 PM

At least as far as I currently see it

limited-country-20626

12/20/2016, 4:14 PM

I guess I am confused by what you mean by that.

limited-country-20626

12/20/2016, 4:14 PM

the only code I looked at was your pull request

limited-country-20626

12/20/2016, 4:14 PM

which appears to successfully set a shebang on a per-target basis

limited-country-20626

12/20/2016, 4:15 PM

but tests the shebang on the PEXBuilder

limited-country-20626

12/20/2016, 4:15 PM

seems the opposite of " I can set it, but not get it"

limited-country-20626

12/20/2016, 4:18 PM

The PEXBuilder chooses its shebang based on the currently configured interpreter

limited-country-20626

12/20/2016, 4:19 PM

and that is AFAICT something that is fine and not needed for your change

limited-country-20626

12/20/2016, 4:20 PM

now - something that would be useful as part of your pull request

limited-country-20626

12/20/2016, 4:21 PM

would be an option to the builder to set a "default shebang"

limited-country-20626

12/20/2016, 4:21 PM

so instead of setting it per-target or using the PEXBuilder's, it could just use something set in the ini file

limited-country-20626

12/20/2016, 4:26 PM

It is not clear to me that the created pex is actually getting the shebang set, tbh

limited-country-20626

12/20/2016, 4:26 PM

but like I said, I don't create pex internally

flaky-twilight-29457

12/20/2016, 4:27 PM

thank you for your reply. so the _configure_shebang method does the is used to set the shebang on the PEXBuilder, which is in python_task.py

flaky-twilight-29457

12/20/2016, 4:28 PM

which is why I wanted to access it from there

flaky-twilight-29457

12/20/2016, 4:29 PM

The actual code works and produces correct PEXes with set shebangs or normal shebang if the parameter is not provided, however my current usage of the test harness does not yield the correct shebang but the standard one.

flaky-twilight-29457

12/20/2016, 4:30 PM

I currently like the way of providing the shebang with the target, as I can then provide it per binary if I have more than one in the entire pants environment of the repo in question

limited-country-20626

12/20/2016, 4:31 PM

okay, glad it is working

limited-country-20626

12/20/2016, 4:32 PM

you could imagine having both, a repo-wide default and then overriding per-target

limited-country-20626

12/20/2016, 4:32 PM

but I defer to your use case on that

flaky-twilight-29457

12/20/2016, 4:53 PM

So checking for the target in the chroot works

busy-air-14741

12/20/2016, 5:22 PM

cc @bored-art-40741 ^ re: pip

flaky-twilight-29457

12/20/2016, 5:25 PM

So I’ve put in two easy/small tests to the mentioned PR

bored-art-40741

12/20/2016, 6:42 PM

What's the question re: pip? The PR landed. And it also provides enough API flexibility to do programmatically using pip as a library

bored-art-40741

12/20/2016, 6:42 PM

Afaik the only question is whether they've cut a release, which I don't know

busy-air-14741

12/20/2016, 6:44 PM

@bored-art-40741 what's there to do now? i think pip's had a release pretty recently if everything that needed to be in pip is now in pip

astonishing-jelly-60479

12/20/2016, 6:47 PM

where should i be looking for documentation on how to manage the size of

.pants.d/binary/python-binary-create

astonishing-jelly-60479

12/20/2016, 6:47 PM

it's growing quite large on our build boxes

bored-art-40741

12/20/2016, 7:34 PM

That PR is sufficient to do pip resolution and wheel downloading independently of the platform the code is running on. For the purpose of my (now abandoned) work, that was all that was needed on the pip side of things

busy-air-14741

12/20/2016, 9:03 PM

@bored-art-40741 abandoned for any reason in particular? it would be nice to use pip's logic instead of duplicating it for things like wheel tags