pantsbuild #general

Channels

welcome

github-notifications

announce

fancy-queen-20734

12/07/2016, 6:27 PM

Do you have a patch up somewhere?

flaky-twilight-29457

12/07/2016, 6:32 PM

It’s somewhat dirty, but I’ll put it somewhere, wait a sec

flaky-twilight-29457

12/07/2016, 6:46 PM

Hm, I just cleaned up debugging cruft and things look better now, however, I’d be interested in a comment on it nevertheless

flaky-twilight-29457

12/07/2016, 6:56 PM

Have a look at https://github.com/lenucksi/pants/commits/ticket3660-upstream @fancy-queen-20734

fancy-queen-20734

12/07/2016, 7:02 PM

Seems ok. One thing is that you can't assume that the 0th target is the one with the shebang.

fancy-queen-20734

12/07/2016, 7:02 PM

you could look at what PythonChroot does wrt splitting out target types

flaky-twilight-29457

12/07/2016, 7:06 PM

I already guessed something like that, however the relevant entrypoint I saw up to now was in https://github.com/pantsbuild/pants/blob/master/src/python/pants/backend/python/tasks/python_binary_create.py#L84

flaky-twilight-29457

12/07/2016, 7:06 PM

where targets is assembled as [binary]

flaky-twilight-29457

12/07/2016, 7:08 PM

there seems to be targets[‘binaries’] category

flaky-twilight-29457

12/07/2016, 7:09 PM

at least judging from https://github.com/pantsbuild/pants/blob/master/src/python/pants/backend/python/python_chroot.py#L236 it appears that there should only be one binary target

flaky-twilight-29457

12/07/2016, 7:10 PM

Also the first source presents the targets as a list and the second one appears to use it as a dictionary… O_o

fancy-queen-20734

12/07/2016, 7:13 PM

chroot constructs the dictionary

fancy-queen-20734

12/07/2016, 7:14 PM

https://github.com/pantsbuild/pants/blob/master/src/python/pants/backend/python/python_chroot.py#L196

flaky-twilight-29457

12/07/2016, 7:20 PM

Looks like basically only PythonBinary would be relevant, which is mapped to “binaries"

flaky-twilight-29457

12/07/2016, 7:21 PM

Having a look at the contents of target within my environment shows that it always is a list with a PythonBinary

flaky-twilight-29457

12/07/2016, 7:22 PM

How would I create something where I end up with something more or different as argument to PythonTask?

fancy-queen-20734

12/07/2016, 7:23 PM

I’m getting

Exception message: 'ascii' codec can't decode byte 0xe2 in position 0: ordinal not in range(128)

when isort runs in travis sometimes. Has anyone else run into this before or am I just unlucky?

fancy-queen-20734

12/07/2016, 7:23 PM

https://travis-ci.org/pantsbuild/pants/jobs/182038537#L3999

fancy-queen-20734

12/07/2016, 7:24 PM

I can’t repro locally

flaky-twilight-29457

12/07/2016, 7:31 PM

I could filter the list that comes in there for PythonBinaries and take the first one as it supposed to only contain one of those

fancy-queen-20734

12/07/2016, 7:56 PM

@flaky-twilight-29457 It looks like the chroot raises an error if there’s more than one binary, so that sounds reasonable to me

rough-minister-58256

12/07/2016, 11:40 PM

whoa:

rough-minister-58256

12/07/2016, 11:40 PM

@User uploaded a file:

Pasted image at 2016-12-07, 3:40 PM▾

rough-minister-58256

12/07/2016, 11:40 PM

zero day github CR updates

wide-energy-11069

12/07/2016, 11:43 PM

tried with non-contributor account, cannot add reviewers

fancy-queen-20734

12/07/2016, 11:44 PM

😕

happy-kitchen-89482

12/08/2016, 1:13 AM

I just added a couple of you as reviewers to something, instead of assigning the issue, I assume that sends the appropriate email

witty-crayon-22786

12/08/2016, 1:23 AM

yea, should.

thankful-library-32113

12/08/2016, 1:34 AM

we're having multiple people report crazy #s of ng processes in ps aux after using pants for multiple days

thankful-library-32113

12/08/2016, 1:34 AM

is this expected? i know about pants ng-killall