#general
- e
enough-analyst-54434
10/26/2016, 7:12 PMI'll make sure the Suare folks are on the review - l
limited-country-20626
10/26/2016, 7:12 PMthe loose source is what I was referencing - l
limited-country-20626
10/26/2016, 7:12 PMthey had imported them as files - l
limited-country-20626
10/26/2016, 7:13 PMthis was awhile back so again, murky - l
limited-country-20626
10/26/2016, 7:13 PMbut the TLDR is that the files were inlined and I was unable to find an easy way to add its few (1 or 2) pip dependencies - e
enough-analyst-54434
10/26/2016, 7:17 PMYeah, loose-source has no mechanism to add 3rdparty deps - this is true - l
limited-country-20626
10/26/2016, 7:17 PMI am grasping at the actual concrete details of it all so apologies for running this in circles a bit - e
enough-analyst-54434
10/26/2016, 7:17 PMEither using the pantsbuild/setup script, or if you are hacking with a clone of pantsbuild/pants off to the side - e
enough-analyst-54434
10/26/2016, 7:17 PMSok - l
limited-country-20626
10/26/2016, 7:19 PMOur solution at the time was essentially what I pasted in the issue, to allow something akin to WRAPPER_REQUIREMENTS - which is why I was suddenly interested when I thought you were pointing out it already existed - e
enough-analyst-54434
10/26/2016, 7:21 PMYeah - different script, but I'm going to file an issue for that case - basically when using released pants but with a local loose-source plugin (you set [GLOBAL]pythonpath: [...] in pants.ini - you need a way to also have pythonpath include requirements. - l
limited-country-20626
10/26/2016, 7:21 PMthank you, that is exactly my case. Delete away! - e
enough-analyst-54434
10/26/2016, 7:21 PM - e
enough-analyst-54434
10/26/2016, 7:22 PMAha - you filed - l
limited-country-20626
10/26/2016, 7:22 PMoh yeah, I linked it above - l
limited-country-20626
10/26/2016, 7:23 PMoffer to add it still stands - l
limited-country-20626
10/26/2016, 7:24 PMalthough you may have a more robust solution in mind - e
enough-analyst-54434
10/26/2016, 7:24 PMYeah - there is a more robust way to do this outside the setup script - l
limited-country-20626
10/26/2016, 7:26 PMSounds good. I have another related issue, that I will file since you agree on the general need above. - e
enough-analyst-54434
10/26/2016, 7:26 PMAha - already works - e
enough-analyst-54434
10/26/2016, 7:27 PMCopy code[GLOBAL] plugins: ['pip', 'pantsbuild.pants.contrib.cpp'] pythonpath: ['my/local/loose/plugin/that/requires/pip'] - e
enough-analyst-54434
10/26/2016, 7:27 PMIts just not obvious at all that would work - e
enough-analyst-54434
10/26/2016, 7:27 PMThe plugin resolver doesn't actually care the thing it resolves is a plugin - l
limited-country-20626
10/26/2016, 7:28 PMwait - where do the requirements.txt come from? - l
limited-country-20626
10/26/2016, 7:28 PMfor the loose source? - e
enough-analyst-54434
10/26/2016, 7:28 PMno requirements.txt - e
enough-analyst-54434
10/26/2016, 7:28 PMliteral requirement string in list - e
enough-analyst-54434
10/26/2016, 7:28 PM'pip' - l
limited-country-20626
10/26/2016, 7:28 PMah - e
enough-analyst-54434
10/26/2016, 7:28 PMso, a way to do it, may not be ideal