#general
- r
rough-minister-58256
10/26/2016, 6:00 PMah, you mean at the semantic level - my bad - e
enough-analyst-54434
10/26/2016, 6:44 PMI'm going to be annoying with the "Do you use ... ?" questions today: Does anyone still wrap the pants repo's own
script - this specific one here: https://github.com/pantsbuild/pants/blob/master/pants#L11-L12 - and set./pants
orWRAPPER_SRCPATH
? - I'd love to kill them and simplify.WRAPPER_REQUIREMENTS - e
enough-analyst-54434
10/26/2016, 6:54 PMI'll assume not and put the relevant folks on the RB who may have used this in the past to push back if the need do so. - l
limited-country-20626
10/26/2016, 6:58 PMI think that WRAPPER_REQUIREMENTS was useful - is there a first class way to add a third party python dep to the pantsenv? - l
limited-country-20626
10/26/2016, 6:59 PMat one point over the last year, Square wanted to do that and the answer was "maintain a separate virtualenv" - e
enough-analyst-54434
10/26/2016, 7:01 PMWell, you add a dep to any of these: https://github.com/pantsbuild/pants/blob/master/build-support/pants_venv#L8-L12 - e
enough-analyst-54434
10/26/2016, 7:01 PMIs there a case where modifying those requirements.txt is not the right thing to do? - l
limited-country-20626
10/26/2016, 7:05 PMHmmm...so my memory of this is a bit murky and I don't personally consume Pants this way. How about if you bootstrap with the http://www.pantsbuild.org/install.html directions? That installs the requirements.txt from inside the cachedir I think - l
limited-country-20626
10/26/2016, 7:05 PMso you would have to dig in the home directory and share between all Pants repos? - l
limited-country-20626
10/26/2016, 7:05 PMMaybe there is an escape hatch here - e
enough-analyst-54434
10/26/2016, 7:06 PMWell, I think the use case for the
is very narrow: 1. developing in-house plugin 2. plugin needs new pants features 3. you want to run / test the plugin live from plugin sources and pants sourcesWRAPPER_* - e
enough-analyst-54434
10/26/2016, 7:07 PMdrop any one of those 3 and then not needed - l
limited-country-20626
10/26/2016, 7:07 PMAh, sure. In general, I do not think that it is very easy to add a 3rdparty python dep, I was thinking that was a way I had missed - e
enough-analyst-54434
10/26/2016, 7:07 PMAnd I think just hacking the extra dep into one of those reqs files temporarily in your pants clone achieves the same end - l
limited-country-20626
10/26/2016, 7:08 PMsure, it is for a different use than I assumed - r
rough-minister-58256
10/26/2016, 7:08 PMfwiw:Copy code[illuminati source (master)]$ ag -s WRAPPER_SRCPATH [illuminati source (master)]$ ag -s WRAPPER_REQUIREMENTS [illuminati source (master)]$ - l
limited-country-20626
10/26/2016, 7:08 PMwait - that is what he is removing, yeah? - e
enough-analyst-54434
10/26/2016, 7:08 PMThis is good, that gives me a concrete alternative, I'll thro in a 4th, empty requirements.txt that has copious # notes about why and how to use - e
enough-analyst-54434
10/26/2016, 7:08 PMThen update the developing a plugin docs with this advanced case maybe - l
limited-country-20626
10/26/2016, 7:09 PMThat would be great - I have had to walk through this with other orgs - e
enough-analyst-54434
10/26/2016, 7:09 PMk, will do - l
limited-country-20626
10/26/2016, 7:09 PMwhen they want to consume an sdist like buildgen - l
limited-country-20626
10/26/2016, 7:09 PMand we often just hack the install script to accept outside requirements.txt, a la https://github.com/pantsbuild/setup/issues/12 - e
enough-analyst-54434
10/26/2016, 7:10 PMWait - that makes no sense - e
enough-analyst-54434
10/26/2016, 7:10 PMbuildgen as an sdist should be declaring its own requirements - e
enough-analyst-54434
10/26/2016, 7:10 PMAnd so when you add that sdists to the GLOBAL plugins list - e
enough-analyst-54434
10/26/2016, 7:10 PMthose deps get pulled - e
enough-analyst-54434
10/26/2016, 7:10 PMthat already completely works and is used heavily - e
enough-analyst-54434
10/26/2016, 7:11 PMI'm pretty sure this is only an issue for loose source plugins - e
enough-analyst-54434
10/26/2016, 7:12 PMie: while developing a plugin you later sdist release, or else a fully truly local one