widely used, but confusing

ok, i got it working with

config/serviceA/src/resources/application.conf

thanks for all the help

this mostly makes sense

@billowy-beach-68498 : with https://github.com/pantsbuild/pants/issues/3977 closed, are we good to go on your end?

@witty-crayon-22786 yes.

great, thanks.

We have an as-of-yet unexplained issue with the 1.2.0pre1 release. Some of our tests are failing and we haven't found out why.

Its not very many, it affects maybe 6 projects out of hundreds.

flakily, or reproducibly?

@wide-energy-11069 was seeing some additional flakiness which we attributed to the runner changes

@ancient-stone-50795 : ^

There doesn't seem to be a common thread. Some of the tests do seem flaky but I can't get the same projects to pass. One error is a mock interaction:

1) collectGarbage(com.squareup.mailbox.jobs.CollectGarbageActionTest)
                     org.mockito.exceptions.verification.NoInteractionsWanted: 
                     No interactions wanted here:
                     -> at com.squareup.mailbox.jobs.CollectGarbageActionTest.verifyGarbageCollection(CollectGarbageActionTest.java:89)
                     But found this interaction on mock 'fileDeleter':
                     -> at com.squareup.mailbox.jobs.CollectGarbageAction$TrashCollectionEnvironment.deleteFile(CollectGarbageAction.java:98)

another is

Caused by: org.bouncycastle.openssl.PEMException: Unable to create OpenSSL PBDKF: PBKDF-OpenSSL SecretKeyFactory not available

another seems to relate to a timestamp comparison. I'm wondering if this isn't classpath related.

Here's a scary one:

1) com.squareup.pbr.statuscheck.LivenessCheckActionTest
                     java.lang.UnknownError: Abnormal VM exit - test crashed.
                     	at __shaded_by_pants__.org.pantsbuild.tools.junit.impl.ShutdownListener.unexpectedShutdown(ShutdownListener.java:27)
                     	at __shaded_by_pants__.org.pantsbuild.tools.junit.impl.ConsoleRunnerImpl$1.run(ConsoleRunnerImpl.java:482)

@ancient-stone-50795 : are you able to bisect across junit runner versions? how old was the version you were on before?

@witty-crayon-22786 we were using 1.0.14 before.

hm. isn't that the one that was 8?

do you mean 1.0.13?

I must have looked at the wrong branch. We were using the default version that came with 1.1.x

Yes, it was 1.0.13

Let me try switching it to 1.0.13

hm. according to

git log org.pantsbuild-junit-runner-1.0.13...master -- src/java/org/pantsbuild/{junit,testing,tools/junit}

, there wasn't anything relevant in that range.

...oh.

tools/junit

so maybe f46e0702f4409d982b79cab9a3789b35090d46a4 ? or not runner related.

That may be something... It looks like one of the tests reliably fails on linux, but I can't repro it on mac right now. That's the

java.lang.RuntimeException: org.bouncycastle.openssl.PEMException: Unable to create OpenSSL PBDKF: PBKDF-OpenSSL SecretKeyFactory not available

the flakiness i saw was due to dependencies between tests, which is not junit runner’s problem.

@wide-energy-11069 : and we were previously on

1.0.13

as well it looks like.

@ancient-stone-50795 : oh: did default flags to the runner change maybe?

@witty-crayon-22786 do you mean in the runner or in junit_run.py? Is see that the file was moved around.

I'm trying to find a test that reliably fails locally so I can debug it