https://pantsbuild.org/ logo
Powered by
#general
  • w

    witty-crayon-22786

    06/16/2015, 11:58 PM
    (sorry, behind on reviews today)
  • h

    happy-kitchen-89482

    06/17/2015, 12:06 AM
    I can do this once I get that other change committed
  • h

    happy-kitchen-89482

    06/17/2015, 12:06 AM
    and I finish up the artifact cache subsystem change
  • h

    happy-kitchen-89482

    06/17/2015, 12:06 AM
    which is waiting on this one and is otherwise mostly done
  • w

    witty-crayon-22786

    06/17/2015, 12:11 AM
    wow, excellent. i'll focus on reviews then. thanks a lot Benjy!
  • h

    happy-kitchen-89482

    06/17/2015, 12:12 AM
    I'm already banging on subsystems, one more won't hurt...
  • w

    witty-crayon-22786

    06/17/2015, 12:53 AM
    @happy-kitchen-89482: so https://rbcommons.com/s/twitter/r/2372/ is discarded probably?
  • h

    happy-kitchen-89482

    06/17/2015, 12:53 AM
    yes
  • w

    witty-crayon-22786

    06/17/2015, 7:48 PM
    @happy-kitchen-89482: #shipit for https://rbcommons.com/s/twitter/r/2380/
  • w

    witty-crayon-22786

    06/17/2015, 7:50 PM
    anything we can do to help with the addition of a jvm subsystem? it looks like we need a solution for setting jvm_options on checkstyle in our next internal release, so if you think one of us could dive into adding that and beginning to consume it for jvm_options in a few places (checkstyle in particular)
  • w

    witty-crayon-22786

    06/17/2015, 7:51 PM
    otherwise, i can just make a targeted fix
  • h

    happy-kitchen-89482

    06/17/2015, 10:52 PM
    I mean, you can just go for it, I can walk you through it if you get stuck anywhere
  • h

    happy-kitchen-89482

    06/17/2015, 10:52 PM
    Just create a subclass of Subsystem (follow any of the several examples), and have tasks access it via JVM.instance_for_task()
  • w

    witty-crayon-22786

    06/18/2015, 4:42 AM
    @happy-kitchen-89482: what do you envision for tasks that use multiple instances of a subsystem? for example, some Tasks use multiple Tools... should the subsytem be owned by the tool instead?
  • h

    happy-kitchen-89482

    06/18/2015, 8:15 PM
    multiple instances, each with different configs?
  • h

    happy-kitchen-89482

    06/18/2015, 8:15 PM
    That is certainly possible
  • h

    happy-kitchen-89482

    06/18/2015, 8:15 PM
    I mean, the need is there
  • h

    happy-kitchen-89482

    06/18/2015, 8:15 PM
    Shouldn
  • h

    happy-kitchen-89482

    06/18/2015, 8:15 PM
    t be hard to implement
  • h

    happy-kitchen-89482

    06/18/2015, 8:16 PM
    we just need a way of assigning scopes to each one
  • w

    witty-crayon-22786

    06/18/2015, 8:16 PM
    jvm tools currently seem to work by prefixing the options that get installed in a particular scope
  • w

    witty-crayon-22786

    06/18/2015, 8:17 PM
    which means that they wouldn't inherit directly by name
  • h

    happy-kitchen-89482

    06/18/2015, 8:19 PM
    With a JVM subsystem the defaults would be in 
    [jvm]
  • h

    happy-kitchen-89482

    06/18/2015, 8:19 PM
    and a tool can be in 
    [jvm.toolname]
  • h

    happy-kitchen-89482

    06/18/2015, 8:19 PM
    We can untie tools from tasks if we want
  • h

    happy-kitchen-89482

    06/18/2015, 8:20 PM
    as long as there are no scope name collisions
  • w

    witty-crayon-22786

    06/18/2015, 8:20 PM
    right, but we can't have a subsytem specific to the tool without another nested scope
  • w

    witty-crayon-22786

    06/18/2015, 8:21 PM
    not sure if we can untie tools from tasks... some are used multiple places
  • w

    witty-crayon-22786

    06/18/2015, 8:21 PM
    i can see this working if the tool gets its own scope rather than being a prefix on an option
  • h

    happy-kitchen-89482

    06/18/2015, 8:23 PM
    if some tools are used from multiple tasks that's an argument FOR untying them, no?
1...141516...2420Latest