#general
- e
enough-analyst-54434
08/05/2015, 6:37 PMThe master diff is wonked: https://github.com/pantsbuild/pants/commit/ff5410e8d9c8c71824e28ae61c42a2fa46969240 - k
kind-holiday-68516
08/05/2015, 6:37 PMDid I break CI? - e
enough-analyst-54434
08/05/2015, 6:37 PMyup - e
enough-analyst-54434
08/05/2015, 6:37 PMthe diff is totall short files - k
kind-holiday-68516
08/05/2015, 6:37 PMOh, shit - k
kind-holiday-68516
08/05/2015, 6:38 PMLet me fix that - e
enough-analyst-54434
08/05/2015, 6:38 PMty - k
kind-holiday-68516
08/05/2015, 6:38 PMreverted - k
kind-holiday-68516
08/05/2015, 6:38 PMwill repatch - k
kind-holiday-68516
08/05/2015, 6:39 PMrepatched as 31cde2e3c14fcaffd79e0a29b80d872b2266b380 - e
enough-analyst-54434
08/05/2015, 6:40 PMThanks - c
cuddly-accountant-94274
08/05/2015, 8:23 PMHey folks. Stu suggested I ask here. What's your estimate of the effort to make Pants support Python 3 (and Python 2 + 3 living together in the same repository)? What roughly would it entail? - e
enough-analyst-54434
08/05/2015, 8:24 PMAlready done - e
enough-analyst-54434
08/05/2015, 8:24 PMUsed by Clover Health - e
enough-analyst-54434
08/05/2015, 8:25 PMThe only issue I know of is with thrift - here: https://github.com/pantsbuild/pants/issues/1818 - c
cuddly-accountant-94274
08/05/2015, 8:25 PMWell, that was easy simple smile - c
cuddly-accountant-94274
08/05/2015, 8:26 PMAny documentation I should read on the issue? - e
enough-analyst-54434
08/05/2015, 8:27 PMWhich issue? - e
enough-analyst-54434
08/05/2015, 8:27 PMThe original issue / fix: https://github.com/pantsbuild/pants/issues/1658 - e
enough-analyst-54434
08/05/2015, 8:27 PMThat was released on 0.0.35: https://pantsbuild.github.io/changelog.html#heading__126 - c
cuddly-accountant-94274
08/05/2015, 8:27 PMSorry, I meant using Python 3 in pants. - e
enough-analyst-54434
08/05/2015, 8:28 PMAh - that's just a
contraint on targets - see here:compatibility - e
enough-analyst-54434
08/05/2015, 8:28 PM - e
enough-analyst-54434
08/05/2015, 8:28 PMNot sure if we higher level docs - looking - e
enough-analyst-54434
08/05/2015, 8:29 PMNope - nothing high-level - e
enough-analyst-54434
08/05/2015, 8:29 PMSo - a bit of a pain to mix right now, the repo can have 1 repo-wide default constraint in pants.ini - say 2.7 - e
enough-analyst-54434
08/05/2015, 8:30 PMThen all the 3 stuff needs to spell it out in its python_{library,binary} targets - e
enough-analyst-54434
08/05/2015, 8:30 PMBasically we give no convenient way to tag the 3's without copypasta the constraint - e
enough-analyst-54434
08/05/2015, 8:31 PM...but - you have plenty of pants eng and a custom pants plugin backend - so easy to expose either a constant, say compatibility=PYTHON3 or else a target subclass - w
witty-crayon-22786
08/05/2015, 8:31 PMit is currently the case that
blows up due to incompatible modules, so more to do there probably../pants test tests::