pantsbuild #general

Channels

welcome

github-notifications

announce

happy-kitchen-89482

08/03/2015, 9:54 PM

@rough-minister-58256: I wonder if that's broken for subsystems

happy-kitchen-89482

08/03/2015, 9:54 PM

it's supposed to capture the defaults by running faux registration

rough-minister-58256

08/03/2015, 9:56 PM

I think John mentioned a missing param, if I s/self.context()/self.context(for_task_types=[DummyTask])/ it seems to work.

happy-kitchen-89482

08/03/2015, 10:03 PM

ah yes

happy-kitchen-89482

08/03/2015, 10:03 PM

I forgot about that part

happy-kitchen-89482

08/03/2015, 10:04 PM

it doesn't faux register all options, just the ones for the task(s) it uses (and those tasks' subsystems)

enough-analyst-54434

08/03/2015, 10:18 PM

The tests/python/pants_test/subsystem/subsystem_util.py:create_subsystem is in master now

mammoth-pharmacist-54215

08/03/2015, 10:35 PM

I’m working on updating our code so that it passes style guidelines and I wanted to get peoples feelings on one of the styles that was called out. based on pep8 you shouldn’t use additional whitespace after a colon: Do use spaces around the = sign of an annotated function definition. Additionally, use a single space after the : , as well as a single space on either side of the -> sign representing an annotated return value However we have some places in our code where we have ignored this rule in the past to help with clarity… Do we want to ignore this particular rule in style checks against pants or should we go with the standard in this case?

witty-crayon-22786

08/03/2015, 10:41 PM

let's not touch any more style issues for now

witty-crayon-22786

08/03/2015, 10:41 PM

land that code before we deal with pants own style.

enough-analyst-54434

08/03/2015, 10:41 PM

I commented to this effect in the RB, but I'd get a quick read on controversy and then move just the controversies to a pants-devel thread so we have a historical record of the community decision

witty-crayon-22786

08/03/2015, 10:41 PM

imo.

mammoth-autumn-2551

08/04/2015, 1:54 AM

I'm trying to build a demo repo to reproduce an issue with thrift generation in pants 0.0.40... but just getting java compilation running is escaping me... does this mean anything to anyone?

mammoth-autumn-2551

08/04/2015, 1:54 AM

Copy code

Invalidated 2 targets.
                     Compiling 2 java sources in 2 targets (partition 1 of 1).
21:52:10 00:00         [compile]
21:52:10 00:00           [jmake]
                         DEBUG] Found ng server launched with Endpoint(exe='/Library/Java/JavaVirtualMachines/jdk1.7.0_67.jdk/Contents/Home/bin/java', fingerprint='26a7831be452e3e70c1338130684b9f99503e9b5', pid=39564, port=59020)
DEBUG] Executing via NailgunClient(host=u'localhost', port=59020, workdir='/Users/paul/development/issues-1915'): /Library/Java/JavaVirtualMachines/jdk1.7.0_67.jdk/Contents/Home/bin/java -Xmx2G -cp /Users/paul/development/issues-1915/.pants.d/ivy/jars/org.pantsbuild/jmake/jars/jmake-1.3.8-10.jar org.pantsbuild.jmake.Main -classpath .pants.d/compile/jvm/java/classes:.pants.d/ivy/jars/commons-lang/commons-lang/jars/commons-lang-2.6.jar:.pants.d/ivy/jars/org.apache.thrift/libthrift/jars/libthrift-0.5.0-1.jar:.pants.d/ivy/jars/org.slf4j/slf4j-api/jars/slf4j-api-1.6.3.jar -d /Users/paul/development/issues-1915/.pants.d/compile/jvm/java/classes -pdb /Users/paul/development/issues-1915/.pants.d/compile/jvm/java/analysis/artifact_cache_tmpdir/50378c29-214b-447b-9f49-7fdcbbc2db49/d70c3bf3d0df9ccaddc75c97a03765f1e5a66467/analysis -pdb-text-format -depfile /Users/paul/development/issues-1915/.pants.d/compile/jvm/java/jmake-depfiles/global_depfile -jcpath /Users/paul/development/issues-1915/.pants.d/ivy/jars/org.pantsbuild.tools.compiler/java-compiler/jars/java-compiler-0.0.1.jar:/Users/paul/development/issues-1915/.pants.d/ivy/jars/org.fusesource.jansi/jansi/jars/jansi-1.11.jar -jcmainclass com.twitter.common.tools.Compiler -C-encoding -CUTF-8 -C-g -C-Tcolor -C-Tnowarnprefixes -C/Users/paul/development/issues-1915/.pants.d/gen -C-Tnowarnregex -C^(warning: )?No processor claimed any of these annotations: .* -C-Xlint:all -C-Xlint:-serial -C-Xlint:-path -C-deprecation -C-Tdependencyfile -C/Users/paul/development/issues-1915/.pants.d/compile/jvm/java/jmake-depfiles/global_depfile .pants.d/gen/thrift/combined/gen-java/com/urbancompass/example/example/Example.java src/java/com/urbancompass/foobar/Foobar.java
jmake: error interacting with the compiler:
                         jmake: error loading compiler main class com.sun.tools.javac.Main
                         jmake: original exception:
                         jmake: com.twitter.common.tools.Compiler
                         Jmake version 1.3.8-10

FAILURE: error initializing or calling the compiler

mammoth-autumn-2551

08/04/2015, 1:54 AM

I'm trying to just compile a java target with a single .java file

enough-analyst-54434

08/04/2015, 1:56 AM

lemme check ... what the classfile version is in that jar - should be 6, but

mammoth-autumn-2551

08/04/2015, 1:56 AM

pants_ini.txt

mammoth-autumn-2551

08/04/2015, 1:56 AM

I'm trying to have a 'bare-bones' thrift + java pants.ini here

enough-analyst-54434

08/04/2015, 1:57 AM

right

enough-analyst-54434

08/04/2015, 1:57 AM

yeah - so jmake 1.3.8-10 is uniformly java 1.5 for every classfile

mammoth-autumn-2551

08/04/2015, 1:58 AM

So do I just need

Copy code

source: 7
target: 7

enough-analyst-54434

08/04/2015, 1:58 AM

nono

enough-analyst-54434

08/04/2015, 1:58 AM

I was just shooting in the dark

enough-analyst-54434

08/04/2015, 1:58 AM

if jmake had been compiled to java 8

enough-analyst-54434

08/04/2015, 1:58 AM

you trying to run it on 7 may have blown up abrubptly/weird

mammoth-autumn-2551

08/04/2015, 1:58 AM

gotcha

enough-analyst-54434

08/04/2015, 1:58 AM

enough-analyst-54434

08/04/2015, 1:59 AM

running that command line by hand - smae error?

enough-analyst-54434

08/04/2015, 1:59 AM

you'll need to edit the cli a bit to eliminate or escape some of the args with spaces

enough-analyst-54434

08/04/2015, 1:59 AM

or else copy-paste from

./pants goal server

- which may give more useful cli args