Mod bugs, there should be 0 ambiguity in how go remote targets should be spelled

there is exactly 1 way

Yeah, reading the 2nd block screams

go_remote_libraries(rev='X', pkgs=['.', 'fred', 'bob', 'fred/bob'])

, of which Medium has plenty, but managed via

buildgen

Yeah, working

buildgen

enablement for pants itself revealed 3rdparty misconceptions in

GoThriftGenIntegrationTest

which was comitted by a tweep.

well, 10 minutes give or take: https://rbcommons.com/s/twitter/r/3889

Thanks @rough-minister-58256, I commented on https://rbcommons.com/s/twitter/r/3883/ in case it helps @billowy-beach-68498 not waste too much time.

if anyone has anything else they'd like to see in 1.0.1, please add it here: https://docs.google.com/spreadsheets/d/12rsaVVhmSXrMVlZV6PUu5uzsKNNcceP9Lpf7rpju_IE/edit#gid=0 will be cutting the first rc today

@ancient-stone-50795: your comment in there is a bit unclear

@fancy-queen-20734: do you have anything else to add to that sheet?

@witty-crayon-22786: I want to get that commit in so the plugin can handle scoped deps. I comitted it, then reverted it and am waiting for an approval.

I'm not sure how you planned on cherry picking -

rbt patch -c <rb>

or

git cherry-pick <commit>

cherry-picking commits

i'll probably drop the RB column entirely

@ancient-stone-50795: ^

SGTM

@ancient-stone-50795: so, do you want to land that? i'm getting ready to do a few of these.

@witty-crayon-22786 I would like to land it. Should I just merge it in?

to master, yes

@witty-crayon-22786: gimme a sec to just run the tests locally and I'll merge

k, lemme know

@witty-crayon-22786 its in

great, thanks.

COmmit e188073

would appreciate a review if anyone gets the chance: https://github.com/pantsbuild/jarjar/pull/20

how do I add a custom scalastyle rule to a scalastyle run? do I need to build a fatjar with scalastyle + my rule’s jar and then edit the scalastyle target to point to that jar? or is there an easier way

No fat jar should be needed since

//:scalastyle

can be a

jar_library

with many jars listed.

FYI: master jenkins CI is red, which I caused. Working it here: https://github.com/pantsbuild/pants/issues/3450

Trying to fix it right, so taking a bit of time, I can do hacks if someone needs master jenkins green quicker and yells

General question to the slack black hole, I may follow up on pants-devel

If I were mischievous, I could refactor a good deal of code that is not marked

:API: public

and break the world right now. I'm tempted to just do it to prove one of 2 points, either we do not actually care about

:API: public

, or we do, but its a very much unfinished project and we all need to be extra-diligent, which I would have thought thte

:API: public

project aimed to make easy. In particular, I'd love to move build_file.py and the project_tree.py family of files (which would break imports). Hopefully and probably the ProjectTree family is not used publically, but I'm pretty sure the BuildFile class is used publically.