https://pantsbuild.org/ logo
Powered by
#general
  • e

    enough-analyst-54434

    05/12/2016, 10:47 PM
    This is properly #C15HUUSL9 material, but to give a competition spur (I know @bored-art-40741 is interested in tackling), https://github.com/pantsbuild/pants/issues/3385 is the biggest blocker to switching from Travis-CI (slow but ~steady) to Jenkins (fast with some issues: https://github.com/pantsbuild/pants/labels/travis-ci-parity).
  • m

    mysterious-action-44812

    05/13/2016, 4:11 AM
  • w

    witty-crayon-22786

    05/13/2016, 5:01 PM
    the 1.1.0-pre0 release thread is looking pretty quiet! we're almost done with our validation... has anyone else gotten a chance?
  • c

    cuddly-garage-87447

    05/13/2016, 5:02 PM
    Hi, I was able to add another source root pattern through the source subsystem but I'm now experimenting in a different direction: given the following project structure 
    module/src/scala/org/module/Stuff.scala
    module/BUILD
    If I add a 
    scala_library
    with 
    sources=globs('src/scala/org/module/*.scala')
    then 
    ./pants export module::
    will give me: 
    "root": [{ "package_prefix": "src.scala.org.module" }]
    . Obviously I'd like to have only 
    org.module
    as the package prefix. I've seen the 
    source_roots
    option which takes a map but I don't understand the syntax, the default says: 
    { '3rdparty/go':'(u'go_remote',)' ...
    . What is this 
    '(u'
    thing? Also, can I have both the root pattern option and the roots option?
  • w

    witty-crayon-22786

    05/13/2016, 5:05 PM
    @cuddly-garage-87447: 
    module/src/$lang
    should match the default source roots
  • w

    witty-crayon-22786

    05/13/2016, 5:05 PM
    if it isn't, that would be a bug.
  • w

    witty-crayon-22786

    05/13/2016, 5:06 PM
    @cuddly-garage-87447: it likely has to do with the fact that the target itself is defined outside the source_root
  • w

    witty-crayon-22786

    05/13/2016, 5:07 PM
    ...so actually, maybe not a bug so much as a confusing bit of behaviour
  • w

    witty-crayon-22786

    05/13/2016, 5:07 PM
    @cuddly-garage-87447: it's the target that matches the source_root... your target is defined at 
    module:target
  • w

    witty-crayon-22786

    05/13/2016, 5:07 PM
    ...which isn't under a source_root
  • w

    witty-crayon-22786

    05/13/2016, 5:08 PM
    recommend following "111": http://www.pantsbuild.org/build_files.html#target-granularity which would suggest moving the target definition to 
    module/src/scala/org/module/BUILD
  • c

    cuddly-garage-87447

    05/13/2016, 5:08 PM
    @witty-crayon-22786: ok, it seemed a good thing to be able to reference the module with 
    'module'
    instead of 
    'module/src/scala/org/module'
  • f

    fancy-queen-20734

    05/13/2016, 5:09 PM
  • w

    witty-crayon-22786

    05/13/2016, 5:09 PM
    @cuddly-garage-87447: so, generally there are two layouts: 1) no top level module directories, 2) maven/sbt/gradle style layout
  • w

    witty-crayon-22786

    05/13/2016, 5:10 PM
    @cuddly-garage-87447: the no-top-level-module approach avoids the redundancy there, because you'd just have `src/scala/org/module/BUILD``
  • c

    cuddly-garage-87447

    05/13/2016, 5:10 PM
    @witty-crayon-22786: exactly, i'm moving from maven simple smile
  • w

    witty-crayon-22786

    05/13/2016, 5:10 PM
    @cuddly-garage-87447: hm... but you dropped the "main" for some reason?
  • c

    cuddly-garage-87447

    05/13/2016, 5:11 PM
    yep, i'm experimenting different layouts
  • c

    cuddly-garage-87447

    05/13/2016, 5:11 PM
    this is a simple module
  • w

    witty-crayon-22786

    05/13/2016, 5:11 PM
    well, if you're experimenting, recommend the "no top-level modules" approach.
  • w

    witty-crayon-22786

    05/13/2016, 5:11 PM
    for one thing, it will let you use foursquare's buildgen
  • w

    witty-crayon-22786

    05/13/2016, 5:11 PM
    (afaik)
  • c

    cuddly-garage-87447

    05/13/2016, 5:11 PM
    ok, don't know that tool
  • c

    cuddly-garage-87447

    05/13/2016, 5:12 PM
    anyhow, i'll move the BUILD for now. So, in your opinion that's not really a bug?
  • c

    cuddly-garage-87447

    05/13/2016, 5:13 PM
    And what about having an option on the 
    scala_library
    target to configure the package_prefix?
  • w

    witty-crayon-22786

    05/13/2016, 5:13 PM
    @cuddly-garage-87447: would end up redundant with your directory structure
  • c

    cuddly-garage-87447

    05/13/2016, 5:14 PM
    @witty-crayon-22786: well, ok thanks simple smile
  • f

    full-kilobyte-93429

    05/13/2016, 5:15 PM
    @enough-analyst-54434: while validating mateo's 1.1.0-pre0, found a use case not covered by https://rbcommons.com/s/twitter/r/3851/ switching to jartool
  • f

    full-kilobyte-93429

    05/13/2016, 5:16 PM
    we have a resource target with a manifest to serve as a second entry point, jar tool by default would skip so we now not see the original manifest
  • f

    full-kilobyte-93429

    05/13/2016, 5:17 PM
    any way to let jar tool keep the original manifest?
1...129212931294...2420Latest