#general
- e
enough-analyst-54434
08/03/2015, 7:41 PMIE: direct construction - e
enough-analyst-54434
08/03/2015, 7:41 PMThe problem with direct construction is it doesn't handle defaults - e
enough-analyst-54434
08/03/2015, 7:41 PMthe new util I have does handle defaults - r
rough-minister-58256
08/03/2015, 7:44 PMah, nice - r
rough-minister-58256
08/03/2015, 7:46 PMi noticed the ivy-style approach also doesn’t handle defaults, which seems like an important part to test for what I’m working on - will wait for the new hotness - e
enough-analyst-54434
08/03/2015, 7:46 PMk - I had new functionality for JVM that required the defaults too - e
enough-analyst-54434
08/03/2015, 7:47 PMI saw Andy's
and though it was pretty silly a user had to specify both flags to turn on debug--jvm-debug --jvm-debug-port=1234 - b
billowy-alarm-80641
08/03/2015, 7:48 PMI'm not actually sure if that's true - e
enough-analyst-54434
08/03/2015, 7:48 PMThe code says it is - b
billowy-alarm-80641
08/03/2015, 7:49 PMah, I believe it - h
happy-kitchen-89482
08/03/2015, 7:52 PMyou don't - h
happy-kitchen-89482
08/03/2015, 7:52 PMthe debug port can be set globally in config - h
happy-kitchen-89482
08/03/2015, 7:53 PMand it probably defaults to something half-way sensible even if you don't - b
billowy-alarm-80641
08/03/2015, 7:53 PMyeah, i think the default is 5005 - h
happy-kitchen-89482
08/03/2015, 7:53 PMyep - h
happy-kitchen-89482
08/03/2015, 7:53 PMit defaults to 5005 - h
happy-kitchen-89482
08/03/2015, 7:54 PMRe creating subsystems in tests: - h
happy-kitchen-89482
08/03/2015, 7:54 PMthe current crappy way is to go through BaseTest - h
happy-kitchen-89482
08/03/2015, 7:54 PMwhich sets up subsystem options the same as task options - h
happy-kitchen-89482
08/03/2015, 7:55 PMthat's actually a great way to create subsystems you need incidentally in your test (if you can't mock it out) - h
happy-kitchen-89482
08/03/2015, 7:55 PMbut not a good way to create subsystems in tests of those subsystems - r
rough-minister-58256
08/03/2015, 7:56 PMvia BaseTest.context() you mean? - r
rough-minister-58256
08/03/2015, 7:57 PMI’ve got that working - but having to explicitly pass in default options feels a bit ugly - r
rough-minister-58256
08/03/2015, 7:58 PMwas going to wire something up to create default options by explicitly invoking Subsystem.register_options, but sounds like John has a better option - e
enough-analyst-54434
08/03/2015, 8:05 PMMy option does exactly that - e
enough-analyst-54434
08/03/2015, 8:05 PMlet me just send the RB in its present form - e
enough-analyst-54434
08/03/2015, 8:05 PMit is green - e
enough-analyst-54434
08/03/2015, 8:06 PM - e
enough-analyst-54434
08/03/2015, 8:07 PMI was holding back last night since it does a few things and so could really be 2-3 RBs - h
happy-kitchen-89482
08/03/2015, 8:15 PMYeah, it's a tad ugly in that you need to create a context even though you don't need one, because that's what triggers the setup