https://pantsbuild.org/ logo
Powered by
#general
  • r

    rough-minister-58256

    05/11/2016, 11:23 PM
    not I
  • h

    happy-kitchen-89482

    05/11/2016, 11:23 PM
    wow
  • h

    happy-kitchen-89482

    05/11/2016, 11:23 PM
    even manually uploading a diff failed
  • r

    rough-minister-58256

    05/11/2016, 11:24 PM
    sometimes when using 
    —parent
    I notice it gets in a bad state for some reason requiring an explicit 
    —parent=master
    to unjam
  • r

    rough-minister-58256

    05/11/2016, 11:25 PM
    e.g. when you layer reviews on other branches
  • h

    happy-kitchen-89482

    05/11/2016, 11:25 PM
    That worked
  • e

    enough-analyst-54434

    05/11/2016, 11:26 PM
    I always use 
    --parent
  • e

    enough-analyst-54434

    05/11/2016, 11:26 PM
    It then always works
  • e

    enough-analyst-54434

    05/11/2016, 11:26 PM
    Switched in early 2010
  • h

    happy-kitchen-89482

    05/11/2016, 11:26 PM
    yeah
  • h

    happy-kitchen-89482

    05/11/2016, 11:26 PM
    seems like a good idea
  • h

    happy-kitchen-89482

    05/11/2016, 11:27 PM
    qq: The Java subsystem docstring says "A subsystem to encapsulate Java language features."
  • h

    happy-kitchen-89482

    05/11/2016, 11:28 PM
    But in practice, the two options it has are not language features but build settings: 
    --strict-deps
    and 
    --fatal-warnings
  • h

    happy-kitchen-89482

    05/11/2016, 11:28 PM
    And it inherits those from 
    ZincLanguageMixin
  • h

    happy-kitchen-89482

    05/11/2016, 11:28 PM
    The other thing that mixes that in is 
    ScalaPlatform
  • w

    witty-crayon-22786

    05/11/2016, 11:29 PM
    mm, the latter is arguably a feature.
  • h

    happy-kitchen-89482

    05/11/2016, 11:29 PM
    And we also have a 
    JavaPlatform
    subsystem, that does not mix that in
  • h

    happy-kitchen-89482

    05/11/2016, 11:29 PM
    So this is all a bit confused
  • w

    witty-crayon-22786

    05/11/2016, 11:29 PM
    @happy-kitchen-89482: when we added that, the thought was to potentially rename 
    ScalaPlatform
    to 
    Scala
  • h

    happy-kitchen-89482

    05/11/2016, 11:29 PM
    The distinction between JavaPlatform and Java is unclear anyway
  • w

    witty-crayon-22786

    05/11/2016, 11:29 PM
    i don't think there is a JavaPlatform
  • w

    witty-crayon-22786

    05/11/2016, 11:29 PM
    JvmPlatform, iirc
  • w

    witty-crayon-22786

    05/11/2016, 11:29 PM
    which makes more sense
  • h

    happy-kitchen-89482

    05/11/2016, 11:30 PM
    JvmPlatform
  • w

    witty-crayon-22786

    05/11/2016, 11:30 PM
    so yea, imagine ScalaPlatform renamed to Scala
  • h

    happy-kitchen-89482

    05/11/2016, 11:30 PM
    OK, so ScalaPlatform should be renamed to Scala
  • h

    happy-kitchen-89482

    05/11/2016, 11:30 PM
    and then its options deal with versions of scala
  • h

    happy-kitchen-89482

    05/11/2016, 11:30 PM
    that makes sense
  • w

    witty-crayon-22786

    05/11/2016, 11:31 PM
    a little bit more perhaps, yea
  • h

    happy-kitchen-89482

    05/11/2016, 11:31 PM
    But I guess that docstring should say something like “Options related to compiling Java"
1...128612871288...2420Latest