#general
- r
rough-minister-58256
05/11/2016, 6:00 PMusually those would get encased in the python dep bdist - e
enough-analyst-54434
05/11/2016, 6:01 PMwell, I mean the ssl lib on the machine - r
rough-minister-58256
05/11/2016, 6:01 PMand there is tooling out there now that will bundle .so’s etc directly in their wheels - r
rough-minister-58256
05/11/2016, 6:02 PM - r
rough-minister-58256
05/11/2016, 6:02 PM
etcauditwheel repair - r
rough-minister-58256
05/11/2016, 6:02 PM(but all subject to the manylinux constraints) - r
rough-minister-58256
05/11/2016, 6:02 PM"auditwheel repair: copies these external shared libraries into the wheel itself, and automatically modifies the appropriate RPATH entries such that these libraries will be picked up at runtime. This accomplishes a similar result as if the libraries had been statically linked without requiring changes to the build system. Packagers are advised that bundling, like static linking, may implicate copyright concerns." - r
rough-minister-58256
05/11/2016, 6:03 PMbut this also only cuts it for linux today - w
witty-crayon-22786
05/11/2016, 7:34 PM@salmon-summer-38098: so, they're not starter tasks by any means, but it would be cool if you could take a look at either https://github.com/pantsbuild/pants/issues/3365 or https://github.com/pantsbuild/pants/issues/2969 - s
salmon-summer-38098
05/11/2016, 7:35 PM@witty-crayon-22786: thanks, will have a look. still walking through old RBs - w
witty-crayon-22786
05/11/2016, 7:35 PM3365 has a bit of history behind it... @full-kilobyte-93429 laid a lot of ground work for caching, and for a while we were serializing everything - w
witty-crayon-22786
05/11/2016, 7:37 PM...and actually, that's going to be heavily affected by a change i have queued. so maybe not that one - s
salmon-summer-38098
05/11/2016, 7:52 PM@witty-crayon-22786: https://rbcommons.com/s/twitter/r/3498 looks like a relevant start to 3365 ? just wondering, i wont work on that one since its going to change somewhat - w
witty-crayon-22786
05/11/2016, 7:54 PMyea, it was - w
witty-crayon-22786
05/11/2016, 7:55 PMthe entire history though, is that it was pretty expensive to content address and hash in all cases - w
witty-crayon-22786
05/11/2016, 7:55 PMthe upcoming change will affect that pretty significantly, because we'll have drastically fewer nodes in the ProductGraph - e
enough-analyst-54434
05/11/2016, 7:58 PMYay! - e
enough-analyst-54434
05/11/2016, 7:59 PMThat was a super intimidating viz to look at, let alone with an eye to the new task developer - w
witty-crayon-22786
05/11/2016, 8:01 PM@enough-analyst-54434: yea... i think the issue was that it was a mix of a query planning graph and a task graph. i've realized that you can inline execution of the
methods in all cases where you don't want to cache/memoize their executionstep - w
witty-crayon-22786
05/11/2016, 8:01 PMnever worth memoizing `Projection`/`Dependencies` basically - w
witty-crayon-22786
05/11/2016, 8:02 PMthe only thing i'm on the fence about is whether those should just not be Nodes at all, or whether it should be an option to inline, and for debuggability you could disable it - w
witty-crayon-22786
05/11/2016, 8:03 PMbecause, yes, intimidating. but super thorough. - w
witty-crayon-22786
05/11/2016, 8:05 PMum, whoops. my initial ping for ity was supposed to be in #C0D7TNJHL... but yea, i guess that was useful information to disseminate 😃 - w
witty-crayon-22786
05/11/2016, 8:05 PMand hey, welcome back @salmon-summer-38098 !🍰 1 - s
salmon-summer-38098
05/11/2016, 8:06 PMthank you for the background! 👍👋 1 - w
witty-crayon-22786
05/11/2016, 9:30 PM@billowy-beach-68498: mind reviewing https://rbcommons.com/s/twitter/r/3866/ ? - b
billowy-beach-68498
05/11/2016, 9:32 PMok! - h
happy-kitchen-89482
05/11/2016, 11:21 PMHas anyone been having trouble with ./rbt updating existing reviews? - h
happy-kitchen-89482
05/11/2016, 11:21 PMERROR: There don't seem to be any diffs! - h
happy-kitchen-89482
05/11/2016, 11:22 PMThere are definitely diffs.