pantsbuild #general

Channels

welcome

github-notifications

announce

witty-crayon-22786

05/09/2016, 5:59 PM

the paste indicates that you're doing the right thing

rough-dog-96241

05/09/2016, 5:59 PM

I wonder if

rglobs

doesn’t include directory listings, and I need to somehow do that?

witty-crayon-22786

05/09/2016, 5:59 PM

i suspect that whatever is jar'ing the binary doesn't include the directory listing

witty-crayon-22786

05/09/2016, 6:00 PM

@rough-dog-96241: no: this is a jar specific issue

rough-dog-96241

05/09/2016, 6:00 PM

nods

enough-analyst-54434

05/09/2016, 6:00 PM

This used to be a bug in the python jarring code 4+ years ago

enough-analyst-54434

05/09/2016, 6:00 PM

But we've since moved to java code to do jarring

witty-crayon-22786

05/09/2016, 6:00 PM

to confirm, can run

unzip -l $jar

on the jar containing your resources

enough-analyst-54434

05/09/2016, 6:00 PM

Which, uses java jar libs and should get this right for free

enough-analyst-54434

05/09/2016, 6:01 PM

But apparently does not

witty-crayon-22786

05/09/2016, 6:01 PM

it's changed a lot recently

witty-crayon-22786

05/09/2016, 6:02 PM

@rough-dog-96241: for a particular pants command, find the output jar containing your resources, and run

unzip -l $jar

... if you don't see a

expected/directory/

(ie, ending with a slash) entry, then it's a pants bug and you should report it

rough-dog-96241

05/09/2016, 6:03 PM

Copy code

$ unzip -l dist/services.cupid.bin-bundle/libs/services.cupid.src.main.resources.resources-0.jar
Archive:  dist/services.cupid.bin-bundle/libs/services.cupid.src.main.resources.resources-0.jar
  Length     Date   Time    Name
 --------    ----   ----    ----
     3308  05-06-16 23:27   application.conf
       56  05-06-16 23:27   BUILD
     1330  05-06-16 23:27   logback.xml
     2272  05-06-16 23:27   db/migration/V2016030454303__init.sql
      643  05-06-16 23:27   db/migration/V2016031414200__jobs_have_lists.sql
      366  05-06-16 23:27   db/migration/V2016031415130__programs_reference_firehose_tables.sql
      476  05-06-16 23:27   db/migration/V20160328_121326_4773__workflow_load.sql
 --------                   -------
     8451                   7 files

rough-dog-96241

05/09/2016, 6:03 PM

yup, I think you’re right.

rough-dog-96241

05/09/2016, 6:03 PM

Where should I report it?

enough-analyst-54434

05/09/2016, 6:04 PM

https://github.com/pantsbuild/pants/blob/master/tests/java/org/pantsbuild/tools/jar/JarBuilderTest.java#L411-L421

enough-analyst-54434

05/09/2016, 6:04 PM

So we nominally test for this, but clearly a corner somewhere

enough-analyst-54434

05/09/2016, 6:04 PM

@rough-dog-96241: https://github.com/pantsbuild/pants/issues please

enough-analyst-54434

05/09/2016, 6:19 PM

Not much of a corner, its easy to repro, only an issue for resources

enough-analyst-54434

05/09/2016, 6:22 PM

Running

bundle

then looking at the

libs/

symlinks is revealing

enough-analyst-54434

05/09/2016, 6:22 PM

the resource jars come from what looks like zinc compile products and that code does not use our jar building code, it uses python directly

enough-analyst-54434

05/09/2016, 6:25 PM

Ah no, its directly bad bundle_create.py code using python jar and not compensating by adding dir entries

enough-analyst-54434

05/09/2016, 6:27 PM

@rough-dog-96241: As soon as you have an issue filed I can hop on while I wait for AMIs to build

enough-analyst-54434

05/09/2016, 7:19 PM

K - I filed while waiting for my AMI: https://github.com/pantsbuild/pants/issues/3371

enough-analyst-54434

05/09/2016, 7:19 PM

I'll have an RB shortly

limited-country-20626

05/09/2016, 8:45 PM

I am putting together the release - john do you want to land the RB referenced above?

enough-analyst-54434

05/09/2016, 8:47 PM

Nope

limited-country-20626

05/09/2016, 8:55 PM

okay thanks!

limited-country-20626

05/09/2016, 9:06 PM

For the 1.1.0-pre0 release, I am considering the 0.0.82 tag to be the latest release, since 1.0.0 and the rcs are a different branch. Let me know if you disagree.

limited-country-20626

05/09/2016, 9:07 PM

well, I guess I take that back. Since the CHANGELOG in master already has those releases. Okay, nvm!