https://pantsbuild.org/ logo
Powered by
#general
  • e

    enough-analyst-54434

    05/07/2016, 4:19 AM
    It warned for all dups and optionally failed build
  • e

    enough-analyst-54434

    05/07/2016, 4:20 AM
    Since this sort of thing is so common and pernicious
  • e

    enough-analyst-54434

    05/07/2016, 4:20 AM
    I thought that was still in there
  • r

    rough-dog-96241

    05/07/2016, 4:21 AM
    This yellow warning text on the dup goal is no help, you think?
  • e

    enough-analyst-54434

    05/07/2016, 4:21 AM
    It is help!
  • e

    enough-analyst-54434

    05/07/2016, 4:21 AM
    That's what I mean
  • e

    enough-analyst-54434

    05/07/2016, 4:21 AM
    One of those dups must be materially relevant
  • r

    rough-dog-96241

    05/07/2016, 4:22 AM
    I don’t see anything in there that has anything to do with migrations. reference.conf’s in typesafe config. But that’s supposed to happen.
  • e

    enough-analyst-54434

    05/07/2016, 4:22 AM
    Well, need to understand flyways class path resource scanner code, set a breakpoint
  • e

    enough-analyst-54434

    05/07/2016, 4:23 AM
    Not a great answer
  • e

    enough-analyst-54434

    05/07/2016, 4:24 AM
    A naïve scanner might expect the resources are in the same jar as a magic class
  • e

    enough-analyst-54434

    05/07/2016, 4:24 AM
    And bundle might violate that
  • r

    rough-dog-96241

    05/07/2016, 4:25 AM
    Looks like it does a lot of debug logging
  • e

    enough-analyst-54434

    05/07/2016, 4:30 AM
    Round about here ://github.com/flyway/flyway/blob/master/flyway-core/src/main/java/org/flywaydb/core/internal/util/scanner/classpath/ClassPathScanner.java
  • r

    rough-dog-96241

    05/07/2016, 4:30 AM
    Yeah, I’ve got that up. I don’t see anything wonky. And the debug logs don’t say anything weird.
  • r

    rough-dog-96241

    05/07/2016, 4:32 AM
    huh. my code is different than that..
  • r

    rough-dog-96241

    05/07/2016, 4:32 AM
    They’ve had a recent major release.
  • r

    rough-dog-96241

    05/07/2016, 4:33 AM
    l. o. l.
  • r

    rough-dog-96241

    05/07/2016, 4:33 AM
    That worked.
  • r

    rough-dog-96241

    05/07/2016, 4:34 AM
    I hate life.
  • e

    enough-analyst-54434

    05/07/2016, 4:34 AM
    A jar upgrade worked?
  • r

    rough-dog-96241

    05/07/2016, 4:34 AM
    👍
  • r

    rough-dog-96241

    05/07/2016, 4:34 AM
    3.2.1 -> 4.0.1
  • e

    enough-analyst-54434

    05/07/2016, 4:34 AM
    K
  • e

    enough-analyst-54434

    05/07/2016, 4:34 AM
    Hopefully that means they fixed the cp scanner
  • r

    rough-dog-96241

    05/07/2016, 4:35 AM
    Yeah — I noticed the exception message was different, so they were mucking with it
  • r

    rough-dog-96241

    05/07/2016, 4:35 AM
  • r

    rough-dog-96241

    05/07/2016, 4:36 AM
    haha. It doesn’t work. It just .. no longer fails when it doesn’t work!
  • r

    rough-dog-96241

    05/07/2016, 4:36 AM
    yay
  • r

    rough-dog-96241

    05/07/2016, 4:37 AM
    That doesn’t feel like a “feature” to me.
1...127212731274...2420Latest