#general
- h
happy-kitchen-89482
05/05/2016, 5:45 PMso I guess I wait for @witty-crayon-22786’s change to pin to java8 and then try again... - w
witty-crayon-22786
05/05/2016, 5:46 PM@happy-kitchen-89482: i think that would mean making the final decision to nuke travis... are we ready for that @enough-analyst-54434 ? - w
witty-crayon-22786
05/05/2016, 5:47 PMtravis only supports 7, since we have the "core language" set to python - h
happy-kitchen-89482
05/05/2016, 5:47 PMAh - h
happy-kitchen-89482
05/05/2016, 5:47 PMthat could explain a lot - h
happy-kitchen-89482
05/05/2016, 5:49 PMBut java7 should still have a tools.jar, right? - h
happy-kitchen-89482
05/05/2016, 5:50 PMYeah, or the distribution would have failed to find it and thrown an exception - f
fast-megabyte-33579
05/05/2016, 5:50 PMtools.jar comes in the JDK I think, not a JRE, if that helps - b
bored-art-40741
05/05/2016, 5:51 PM@happy-kitchen-89482: Try installing jdk7 but not making it the default - b
bored-art-40741
05/05/2016, 5:52 PMOr switching the default around anyway - b
bored-art-40741
05/05/2016, 5:52 PMThat was definitely a bug at some point - b
bored-art-40741
05/05/2016, 5:52 PMWhere the presence of both versions was a problem, but only if a particular one was the default - h
happy-kitchen-89482
05/05/2016, 5:54 PMwell well well - h
happy-kitchen-89482
05/05/2016, 5:54 PMturns out that
doesn’t exist in java 7com.sun.source.util.Plugin - f
fast-megabyte-33579
05/05/2016, 5:54 PM - h
happy-kitchen-89482
05/05/2016, 5:55 PMThat explains everything - h
happy-kitchen-89482
05/05/2016, 5:55 PMThere were definitely plugins prior to 1.8, must have been a different classname - w
witty-crayon-22786
05/05/2016, 5:55 PMi'd definitely never heard of these. - h
happy-kitchen-89482
05/05/2016, 5:55 PMOK, so I need to run the test conditionally - h
happy-kitchen-89482
05/05/2016, 6:05 PMIs that a thing we can do? only run this test if java8 is present? - w
witty-crayon-22786
05/05/2016, 6:05 PMyea, there are examples in the distribution tests. i think they work? cc @jolly-chef-92794 - b
bored-art-40741
05/05/2016, 6:06 PMYeah - b
bored-art-40741
05/05/2016, 6:06 PMThere are definitely
filtersskipIf - b
bored-art-40741
05/05/2016, 6:06 PMThat do exactly this - h
happy-kitchen-89482
05/05/2016, 6:06 PMthese are integration tests - j
jolly-chef-92794
05/05/2016, 6:06 PMYes I did that a few months ago for distributions - h
happy-kitchen-89482
05/05/2016, 6:07 PMnot junit tests - h
happy-kitchen-89482
05/05/2016, 6:07 PMOh, I see - j
jolly-chef-92794
05/05/2016, 6:07 PMI don’t remember all the details/pitfalls though. I don’t remember whether integration tests vs unit tests made a difference - h
happy-kitchen-89482
05/05/2016, 6:07 PMthat is a pytest annotation