#general
- b
bored-art-40741
05/04/2016, 7:21 PMI'm confused - w
witty-crayon-22786
05/04/2016, 7:21 PM(for some subset of the graph) - b
bored-art-40741
05/04/2016, 7:22 PMWe know this fails with cache misses, but we're trying to mainline it? - w
witty-crayon-22786
05/04/2016, 7:22 PM@bored-art-40741: no: the tests cover that we don't miss cache - b
bored-art-40741
05/04/2016, 7:22 PMHow do they cover it? - w
witty-crayon-22786
05/04/2016, 7:22 PMby testing 100% hit rate - b
bored-art-40741
05/04/2016, 7:22 PMDo they cover writing to the cache with one interpreter and hitting it with another? - b
bored-art-40741
05/04/2016, 7:22 PMDifferent platforms? Different phases of the moon? - b
bored-art-40741
05/04/2016, 7:22 PMA lack of guarantee on stability is very dangerous - w
witty-crayon-22786
05/04/2016, 7:22 PM@bored-art-40741: no, but remote caching isn't implemented. - w
witty-crayon-22786
05/04/2016, 7:23 PMwell, no: it's not really. - w
witty-crayon-22786
05/04/2016, 7:23 PMit's a cache. - b
bored-art-40741
05/04/2016, 7:23 PMIt's a cache that we depend heavily on working 100% correctly - w
witty-crayon-22786
05/04/2016, 7:23 PMagain, not saying that won't be a blocker for making this the default. - b
bored-art-40741
05/04/2016, 7:23 PMI'm once again confused. Remote caching isn't implemented? - w
witty-crayon-22786
05/04/2016, 7:23 PM@bored-art-40741: it's a cache that doesn't currently exist - b
bored-art-40741
05/04/2016, 7:23 PMAbove you said that this change uses pickled bytestreams as fingerprint keys - w
witty-crayon-22786
05/04/2016, 7:23 PM@bored-art-40741: yes, for a local cache. - b
bored-art-40741
05/04/2016, 7:24 PMA local cache of what? - w
witty-crayon-22786
05/04/2016, 7:24 PMof what the engine executes - w
witty-crayon-22786
05/04/2016, 7:24 PMwhich is only build file parsing and glob expansion currently - w
witty-crayon-22786
05/04/2016, 7:24 PM(but also, i'm not even sure Kris turns that on in that review... he needn't.) - b
bored-art-40741
05/04/2016, 7:24 PMAh - b
bored-art-40741
05/04/2016, 7:24 PMSo this doesn't affect the artifact cache at all - w
witty-crayon-22786
05/04/2016, 7:24 PMcorrect. not for a while. - b
bored-art-40741
05/04/2016, 7:25 PMThat's what I was asking above, wrt fingerprints being downstream from pickled bytestream hashes - w
witty-crayon-22786
05/04/2016, 7:25 PM...in the sense of "Target fingerprints" you mean then - w
witty-crayon-22786
05/04/2016, 7:26 PMno: there are no Target fingerprints downstream of pickled bytesteams - b
bored-art-40741
05/04/2016, 7:27 PMOkay - b
bored-art-40741
05/04/2016, 7:27 PMThat's where I'm drawing a hard line