https://pantsbuild.org/ logo
Powered by
#general
  • b

    bored-art-40741

    07/31/2015, 10:14 PM
    The funny thing is that my primary focus during that refactor was build graph caching and the pants server, which you guys are now working on
  • h

    happy-kitchen-89482

    07/31/2015, 10:23 PM
    I'm doing some work on analyzing timing stats
  • h

    happy-kitchen-89482

    07/31/2015, 10:23 PM
    is anyone apart from Foursquare using stats_upload_url today?
  • h

    happy-kitchen-89482

    07/31/2015, 10:23 PM
    I want to change a few things there
  • h

    happy-kitchen-89482

    07/31/2015, 10:23 PM
    [Some of you will have seen the first in a series of related code reviews]
  • w

    witty-crayon-22786

    07/31/2015, 10:32 PM
    @happy-kitchen-89482: yea, we are. sorry
  • w

    witty-crayon-22786

    07/31/2015, 10:33 PM
    @happy-kitchen-89482: can you include @gorgeous-fish-11040 on those reviews?
  • h

    happy-kitchen-89482

    07/31/2015, 10:33 PM
    sure
  • g

    gorgeous-fish-11040

    07/31/2015, 10:33 PM
    👍
  • h

    happy-kitchen-89482

    07/31/2015, 10:33 PM
    I will make the changes backwards-compatible then
  • h

    happy-kitchen-89482

    07/31/2015, 10:34 PM
    @gorgeous-fish-11040: the two changes I want to make are
  • h

    happy-kitchen-89482

    07/31/2015, 10:35 PM
    1) Rename the runinfo "path" key to "buildroot", because that's what it really is.
  • h

    happy-kitchen-89482

    07/31/2015, 10:35 PM
    But that's easy to do in backwards-compatible way.
  • g

    gorgeous-fish-11040

    07/31/2015, 10:36 PM
    looks great. we don’t use it in our scripts
  • g

    gorgeous-fish-11040

    07/31/2015, 10:37 PM
    oh wait. we do. but don’t need any more simple smile
  • h

    happy-kitchen-89482

    07/31/2015, 10:37 PM
    2) Right now we have 4 bits of stats data (run_info, cumulative_timings, self_timings, artifact_cache_stats) that are each json-serialized separately, and uploaded as 4 separate urlencoded POST params. I'd like to change this to a single post param called "stats", whose value is a json-serialized dict of those 4 key-value pairs.
  • h

    happy-kitchen-89482

    07/31/2015, 10:38 PM
    How disruptive would that be?
  • g

    gorgeous-fish-11040

    07/31/2015, 10:38 PM
    for #2 we need to make a change
  • g

    gorgeous-fish-11040

    07/31/2015, 10:39 PM
    a small issue to our service. but out of curiosity why do you want to do it?
  • h

    happy-kitchen-89482

    07/31/2015, 10:39 PM
    I can upload both formats for a changeover period
  • g

    gorgeous-fish-11040

    07/31/2015, 10:40 PM
    maybe we can add an option to configure which parts to upload
  • h

    happy-kitchen-89482

    07/31/2015, 10:40 PM
    Mostly because adding a new stats category is now harder than it needs to be
  • h

    happy-kitchen-89482

    07/31/2015, 10:40 PM
    the webserver needs to know about it, somewhat
  • h

    happy-kitchen-89482

    07/31/2015, 10:41 PM
    I'd rather the subcategories of stats were encapsulated, and only whatever handles them needs to know about it.
  • g

    gorgeous-fish-11040

    07/31/2015, 10:41 PM
    make sense.
  • h

    happy-kitchen-89482

    07/31/2015, 10:41 PM
    But we can upload both for a deprecation period
  • h

    happy-kitchen-89482

    07/31/2015, 10:41 PM
    it's a small amount of data anyway
  • g

    gorgeous-fish-11040

    07/31/2015, 10:42 PM
    will be easier for us to switch.
  • g

    gorgeous-fish-11040

    07/31/2015, 10:42 PM
    will make a release. switch to the new one and fail back if any issues. with the next release could be removed
  • r

    rough-minister-58256

    07/31/2015, 10:43 PM
    downstream we have a bunch of HDFS thrift stuff that has the prior structure baked in, tho we can probably just parse upstream and continue using that in the backend
1...123124125...2420Latest