pantsbuild #general

Channels

welcome

github-notifications

announce

witty-crayon-22786

04/28/2016, 12:09 AM

@happy-kitchen-89482: remember that there are two modes here: 1) building a plugin jar to publish (

scalac_plugin

), 2) consuming a plugin (requires the tool classpath)

witty-crayon-22786

04/28/2016, 12:09 AM

and unfortunately, they are not linked up, because bootstrap.

happy-kitchen-89482

04/28/2016, 12:10 AM

happy-kitchen-89482

04/28/2016, 12:10 AM

sad

witty-crayon-22786

04/28/2016, 12:10 AM

yea.

happy-kitchen-89482

04/28/2016, 12:11 AM

So I need to create //:scalac-plugin-jars and have it pull in all the plugins?

happy-kitchen-89482

04/28/2016, 12:11 AM

In the new engine this will all just work, right? simple smile

witty-crayon-22786

04/28/2016, 12:11 AM

that is the idea, yea.

witty-crayon-22786

04/28/2016, 12:11 AM

what are "all of the plugins" here?

happy-kitchen-89482

04/28/2016, 12:15 AM

all the plugins you might want to use

witty-crayon-22786

04/28/2016, 12:15 AM

yea

happy-kitchen-89482

04/28/2016, 12:15 AM

I’m replicating parts of this for javac plugins

witty-crayon-22786

04/28/2016, 12:16 AM

also, it's a bit frustrating that there are different models here for scalac and javac plugins.

happy-kitchen-89482

04/28/2016, 12:16 AM

they are just different enough that copy-pasta is preferable to attempting to find commonality

witty-crayon-22786

04/28/2016, 12:17 AM

it would be great if scalac plugins acted more like annotation processors... the extra "must be jar'd" component used to be more difficult to get around, but now there is a context jar for any target we compile... might just need to compute it sooner

witty-crayon-22786

04/28/2016, 12:17 AM

er, not even "compute"... it's already computed: https://github.com/pantsbuild/pants/blob/master/src/python/pants/backend/jvm/tasks/jvm_compile/compile_context.py#L27

witty-crayon-22786

04/28/2016, 12:18 AM

@happy-kitchen-89482: ^ ... basically, annotation processors are the more desirable model currently

witty-crayon-22786

04/28/2016, 12:18 AM

back in an hour

happy-kitchen-89482

04/28/2016, 12:20 AM

Yeah, that would be simpler

happy-kitchen-89482

04/28/2016, 12:21 AM

except that we need the mapping of plugin name to jar, which we currently get by opening up that jar and looking at the xml

happy-kitchen-89482

04/28/2016, 12:21 AM

that would need to stay

witty-crayon-22786

04/28/2016, 1:44 AM

@happy-kitchen-89482: sure: but compilation of a scalac_plugin target creates that xml, so would be able to read it uniformly across internal vs external targets

witty-crayon-22786

04/28/2016, 1:45 AM

(with a small amount of special casing to look at the context jar rather than the loose classfile directory)

jolly-chef-92794

04/28/2016, 4:05 PM

Hey @happy-kitchen-89482 looks like the

_new_design_

build dictionary isn’t expandable? http://pantsbuild.github.io/staging/_new_design_/build_dictionary.html

rough-minister-58256

04/28/2016, 4:07 PM

same here, I see this in the js console:

Copy code

docsite.js:31 Uncaught TypeError: Cannot set property 'onclick' of null

rough-minister-58256

04/28/2016, 4:07 PM

(chrome on OSX)

rough-minister-58256

04/28/2016, 4:08 PM

new site looks great btw!

happy-kitchen-89482

04/28/2016, 4:38 PM

hmm yes

happy-kitchen-89482

04/28/2016, 4:39 PM

will see what that’s about

jolly-chef-92794

04/28/2016, 4:59 PM

Ditto on new site looking great. It’s an amazing improvement