https://pantsbuild.org/ logo
Powered by
#general
  • b

    billowy-beach-68498

    04/20/2016, 10:11 PM
    I think what happens is it first tried to look for setUp in FileSystemPantsIgnoreTest, but it’s not there, so it goes to super which is unittest.Testcase
  • w

    witty-crayon-22786

    04/20/2016, 10:11 PM
    @rough-minister-58256: then the base class (which is abstract) will be run as a test
  • b

    billowy-beach-68498

    04/20/2016, 10:11 PM
    yeah, I tried that, as Stu said, it cannot initiate an abstract class object
  • r

    rough-minister-58256

    04/20/2016, 10:12 PM
    yeah, scratch that. try moving the 
    test_ignore_pattern_blank_line
    to 
    FileSystemPantsIgnoreTest
  • r

    rough-minister-58256

    04/20/2016, 10:14 PM
    or 
    def test…(): super(…).test…
  • b

    billowy-beach-68498

    04/20/2016, 10:14 PM
    I believe it will work, but the reason I put it in baseclass is that the testcase is shared with multiple derived class
  • r

    rough-minister-58256

    04/20/2016, 10:14 PM
    yeah, so a super() passthru would make sense
  • r

    rough-minister-58256

    04/20/2016, 10:15 PM
    I think this is a test discovery thing. since your unittest.TestCase-deriving class doesn’t dfefine any tests, pytest thinks theres nothing to run. this should be reflected by the test counter in pytest output.
  • b

    billowy-beach-68498

    04/20/2016, 10:16 PM
    test is actually run, I got error from testrun because setUp is not executed.
  • b

    billowy-beach-68498

    04/20/2016, 10:17 PM
    I believe John’s solution to put setUp to FileSystemPantsIgnoreTest will work, but that way setUp cannot be shared either
  • e

    enough-analyst-54434

    04/20/2016, 10:17 PM
    Nack - it can be shared
  • r

    rough-minister-58256

    04/20/2016, 10:18 PM
    ah interesting
  • b

    billowy-beach-68498

    04/20/2016, 10:20 PM
    found an ugly way to make it work
  • b

    billowy-beach-68498

    04/20/2016, 10:20 PM
    Copy code
    def setUp(self):
    PantsIgnoreTestBase.setUp(self)

  def tearDown(self):
    PantsIgnoreTestBase.tearDown(self)
  • b

    billowy-beach-68498

    04/20/2016, 10:20 PM
    add these in FileSystemPantsIgnoreTest
  • b

    billowy-beach-68498

    04/20/2016, 10:21 PM
    reroute setUp and tearDown to PantsIgnoreTestBase instead of unittest.TestCase
  • r

    rough-minister-58256

    04/20/2016, 10:22 PM
    couldnt you also just reorder the base classes of FileSystemPantsIgnoreTest?
  • b

    billowy-beach-68498

    04/20/2016, 10:22 PM
    let me try
  • e

    enough-analyst-54434

    04/20/2016, 10:22 PM
    Or just move unittest.TestCase to PantsIgnoreTestBase - please
  • e

    enough-analyst-54434

    04/20/2016, 10:22 PM
    got sanity sake
  • e

    enough-analyst-54434

    04/20/2016, 10:23 PM
    the mro was unittest.TestCase as Kris points out
  • e

    enough-analyst-54434

    04/20/2016, 10:23 PM
    and so you were defeated by a no-op setUp
  • e

    enough-analyst-54434

    04/20/2016, 10:23 PM
    Just kill the diamond
  • b

    billowy-beach-68498

    04/20/2016, 10:23 PM
    shuffle the order works
  • b

    billowy-beach-68498

    04/20/2016, 10:23 PM
    yes no-op setUp is giving me trouble
  • e

    enough-analyst-54434

    04/20/2016, 10:25 PM
    put it this way
  • e

    enough-analyst-54434

    04/20/2016, 10:25 PM
    If some day unittest.TestCase does something real in setup
  • e

    enough-analyst-54434

    04/20/2016, 10:25 PM
    you are screwed
  • e

    enough-analyst-54434

    04/20/2016, 10:25 PM
    linearize that path
  • b

    billowy-beach-68498

    04/20/2016, 10:26 PM
    PantsIgnoreTestBase is an abstract class, I did something like
    Copy code
    PantsIgnoreTestBase(unittest.TestCase, ProjectTreeTestBase)
    before but it didn’t work. I got error like cannot create instance of abstract class
1...118511861187...2420Latest