pantsbuild #general

Channels

welcome

github-notifications

announce

happy-kitchen-89482

04/19/2016, 6:33 AM

What is it that you want to make into a subsystem?

happy-kitchen-89482

04/19/2016, 6:33 AM

Also, why not just put the locks and nailgun stuff under .pants.d?

bored-art-40741

04/19/2016, 2:29 PM

I'm working on a patch right now to enable eager cache writes for zinc (instead of batching them up to the end), but I don't think I've done it quite right. If anyone familiar with this code (probably @witty-crayon-22786 ) could take a look, I'd appreciate it

bored-art-40741

04/19/2016, 2:29 PM

https://github.com/pantsbuild/pants/pull/3221

bored-art-40741

04/19/2016, 2:29 PM

This is how it's failing, and the failures seem legit: https://travis-ci.org/pantsbuild/pants/builds/124074214

bored-art-40741

04/19/2016, 3:37 PM

It definitely seems to be an issue with the annotation processor stuff not making it into the artifact, but from all of my reading of the code I don't see why not

bored-art-40741

04/19/2016, 3:37 PM

That should happen as part of the "compile work", and therefore before the on-success callback for that work

bored-art-40741

04/19/2016, 3:56 PM

Okay, I officially have zero clue how new options work

bored-art-40741

04/19/2016, 3:57 PM

How the hell do I override the cache spec for a given task to write to a folder?

bored-art-40741

04/19/2016, 3:57 PM

Copy code

./pants --cache-compile-zinc-write-to="/tmp/artifact_cache" compile testprojects/src/java/org/pantsbuild/testproject/annotation/main

ancient-stone-50795

04/19/2016, 3:57 PM

./pants --help-all --help-advanced

bored-art-40741

04/19/2016, 3:57 PM

No, I know what the options are

bored-art-40741

04/19/2016, 3:57 PM

I don't understand how to use them

bored-art-40741

04/19/2016, 3:58 PM

Copy code

FAILURE
Exception caught: (<class 'pants.cache.cache_setup.RemoteCacheSpecRequiredError'>)
  File "/Users/pl/code/pants/src/python/pants/bin/pants_exe.py", line 50, in <module>
    main()
  File "/Users/pl/code/pants/src/python/pants/bin/pants_exe.py", line 44, in main
    PantsRunner(exiter).run()
  File "/Users/pl/code/pants/src/python/pants/bin/pants_runner.py", line 53, in run
    options_bootstrapper=options_bootstrapper)
  File "/Users/pl/code/pants/src/python/pants/bin/pants_runner.py", line 43, in _run
    return LocalPantsRunner(exiter, args, env, options_bootstrapper=options_bootstrapper).run()
  File "/Users/pl/code/pants/src/python/pants/bin/local_pants_runner.py", line 49, in run
    self._maybe_profiled(self._run)
  File "/Users/pl/code/pants/src/python/pants/bin/local_pants_runner.py", line 46, in _maybe_profiled
    runner()
  File "/Users/pl/code/pants/src/python/pants/bin/local_pants_runner.py", line 84, in _run
    result = goal_runner.run()
  File "/Users/pl/code/pants/src/python/pants/bin/goal_runner.py", line 335, in run
    result = self._execute_engine()
  File "/Users/pl/code/pants/src/python/pants/bin/goal_runner.py", line 324, in _execute_engine
    result = engine.execute(self._context, self._goals)
  File "/Users/pl/code/pants/src/python/pants/engine/engine.py", line 26, in execute
    self.attempt(context, goals)
  File "/Users/pl/code/pants/src/python/pants/engine/round_engine.py", line 240, in attempt
    goal_executor.attempt(explain)
  File "/Users/pl/code/pants/src/python/pants/engine/round_engine.py", line 58, in attempt
    task.execute()
  File "/Users/pl/code/pants/src/python/pants/backend/jvm/tasks/jvm_compile/jvm_compile.py", line 392, in execute
    classpath_product.add_for_target(cc.target, [(conf, cc.jar_file)])
  File "/usr/local/Cellar/python/2.7.11/Frameworks/Python.framework/Versions/2.7/lib/python2.7/contextlib.py", line 24, in __exit__
    self.gen.next()
  File "/Users/pl/code/pants/src/python/pants/task/task.py", line 425, in invalidated
    and self.artifact_cache_writes_enabled()
  File "/Users/pl/code/pants/src/python/pants/task/task.py", line 270, in artifact_cache_writes_enabled
    return self._cache_factory.write_cache_available()
  File "/Users/pl/code/pants/src/python/pants/cache/cache_setup.py", line 131, in write_cache_available
    return self._options.write and bool(self._options.write_to) and self.get_write_cache()
  File "/Users/pl/code/pants/src/python/pants/cache/cache_setup.py", line 154, in get_write_cache
    cache_spec = self._resolve(self._sanitize_cache_spec(self._options.write_to))
  File "/Users/pl/code/pants/src/python/pants/cache/cache_setup.py", line 183, in _sanitize_cache_spec
    raise RemoteCacheSpecRequiredError('One of two cache specs must be a remote spec.')

Exception message: One of two cache specs must be a remote spec.

limited-country-20626

04/19/2016, 3:58 PM

string appends to the old if it accepts a list

bored-art-40741

04/19/2016, 3:58 PM

That error makes no sense: we can definitely have local-only cache specs

limited-country-20626

04/19/2016, 3:58 PM

which it looks like that option does

ancient-stone-50795

04/19/2016, 3:58 PM

That's a new one on me.

bored-art-40741

04/19/2016, 3:58 PM

Hm, I don't want it to append, I want to clobber it

limited-country-20626

04/19/2016, 3:58 PM

use the list format

ancient-stone-50795

04/19/2016, 3:59 PM

--cache-compile-zinc-write-to="['/tmp/artifact_cache']"

ancient-stone-50795

04/19/2016, 3:59 PM

limited-country-20626

04/19/2016, 3:59 PM

yep

bored-art-40741

04/19/2016, 3:59 PM

bored-art-40741

04/19/2016, 3:59 PM

Yeah that works

bored-art-40741

04/19/2016, 3:59 PM

Thanks

limited-country-20626

04/19/2016, 3:59 PM

I spent the time learning it - glad to see a payoff!

bored-art-40741

04/19/2016, 4:14 PM

I'm super, super confused about what's going on. The correct files are under the target

results_dir

at the time I'm making the call to update the artifact cache

bored-art-40741

04/19/2016, 4:15 PM

The call I'm making is identical to what

Task.invalidated

does

bored-art-40741

04/19/2016, 4:17 PM

But for some reason the artifact only gets generated with the contents of

compile_classpath