https://pantsbuild.org/ logo
Powered by
#general
  • j

    jolly-chef-92794

    04/17/2016, 2:11 AM
    Okay, it’s been over three hours so I’m going to assume it’s not going to make any more progress.
  • w

    wide-energy-11069

    04/17/2016, 5:59 AM
    went with the links, and those files are tiny, shouldn’t take that long
  • h

    happy-kitchen-89482

    04/17/2016, 12:34 PM
    I’m seeing contrib/scalajs/tests/python/pants_test/contrib/scalajs/tasks/test_scalajs_repl_integration fail with timeouts in CI (travis and Jenkins) and locally
  • h

    happy-kitchen-89482

    04/17/2016, 12:34 PM
    known issue?
  • h

    happy-kitchen-89482

    04/17/2016, 2:05 PM
    I see, looks like some of our integration tests rely on the cache in order to complete in a reasonable amount of time.
  • h

    happy-kitchen-89482

    04/17/2016, 2:05 PM
    That’s not ideal
  • a

    ancient-stone-50795

    04/17/2016, 2:48 PM
    @jolly-chef-92794: on my box it winds up under 
    ~/.cache/pants/bin/node/mac/10.11/v5.5.0/node.tar.gz
    If you can get a copy downloaded there on your laptop you might be able to skip past this. My copy looks like:
    Copy code
    md5 ./pants/bin/node/mac/10.11/v5.5.0/node.tar.gz
MD5 (./pants/bin/node/mac/10.11/v5.5.0/node.tar.gz) = b6125759dc2247c83453db03295c6b93
  • j

    jolly-chef-92794

    04/17/2016, 5:37 PM
    Ok, I will try that. I tried running it overnight with no luck.
  • j

    jolly-chef-92794

    04/17/2016, 5:37 PM
    node-install.png
  • l

    limited-country-20626

    04/17/2016, 5:39 PM
    @happy-kitchen-89482: yeah - I ran a flyer with cache enforced off and determined we weren't ready for that. You and I both went to the same next step....I will review this afternoon : )
  • j

    jolly-chef-92794

    04/17/2016, 5:41 PM
    Ok…. @ancient-stone-50795 it looks like 
    ~/.cache/pants/bin/node/mac/10.11/v5.5.0/node.tar.gz
    is already there, and even has the right md5.
  • h

    happy-kitchen-89482

    04/17/2016, 5:48 PM
    That change I sent you sets up a framework for integration tests to declare themselves “hermetic” - i.e., unreliant on pants.ini or the cache
  • l

    limited-country-20626

    04/17/2016, 5:51 PM
    Yeah I looked it over already, just not reviewed. It is a more robust solution that what I had which was just a cache-read opt-out flag. I will give your patch full read in a little bit.
  • h

    happy-kitchen-89482

    04/17/2016, 5:54 PM
    The bigger issue there is actually the fact that our integration tests read our real pants.ini
  • l

    limited-country-20626

    04/17/2016, 5:56 PM
    Oh yes. That was the actual problem I wanted to solve. I was surprised they did that . If our integration tests rely on a base "default" config, I would like to see that codified in the integration test base class. I don't like the idea of scattered tests failing
  • l

    limited-country-20626

    04/17/2016, 5:56 PM
    because a pants.ini flag gets flipped
  • l

    limited-country-20626

    04/17/2016, 5:59 PM
    with perhaps some exceptions allowed if necessary - tool bootstrapping maybe
  • e

    enough-analyst-54434

    04/17/2016, 9:51 PM
    @jolly-chef-92794: this is evil: https://github.com/pantsbuild/pants/blob/master/contrib/node/examples/src/node/preinstalled-project/BUILD#L7-L8 - github rate limits for 1. I'll move to bintray and send an RB re-pointing the url
  • e

    enough-analyst-54434

    04/17/2016, 9:55 PM
    And it uses urllib instead of requests/Fetcher, I'll fix that too.
  • j

    jolly-chef-92794

    04/17/2016, 10:26 PM
    I dont’ think downloading it is the problem
  • j

    jolly-chef-92794

    04/17/2016, 10:26 PM
    It ends up in my cache folder ok
  • j

    jolly-chef-92794

    04/17/2016, 10:26 PM
    But 
    npm install
    hangs forever
  • e

    enough-analyst-54434

    04/17/2016, 10:27 PM
    Ack, the npm install is massive
  • e

    enough-analyst-54434

    04/17/2016, 10:28 PM
    But -"it"
  • e

    enough-analyst-54434

    04/17/2016, 10:28 PM
    You had an url that was not the bin url
  • e

    enough-analyst-54434

    04/17/2016, 10:28 PM
    there are 3 things, node distribution - cached in bin, pre-installed-modules, only 2 mb but hosted and fetched badly, node resolve - massive
  • e

    enough-analyst-54434

    04/17/2016, 10:29 PM
    My 2 RBs fix #2
  • e

    enough-analyst-54434

    04/17/2016, 10:29 PM
    #1 is fine
  • e

    enough-analyst-54434

    04/17/2016, 10:29 PM
    #3 is ridiculous, but the test uses a massive dep tree as things stand today
  • j

    jolly-chef-92794

    04/17/2016, 10:30 PM
    Yeah 
    /Users/gmalmquist/.cache/pants/bin/node/mac/10.11/v5.5.0/unpacked/node/bin/npm install
    ran for 14 hours last night before I killed it when I got up, with no indication that it had done anything useful
1...116311641165...2420Latest