https://pantsbuild.org/ logo
Powered by
#general
  • h

    happy-kitchen-89482

    04/15/2016, 7:50 PM
    Including my currently-open RBs, if you’re one of the reviewers.
  • j

    jolly-chef-92794

    04/15/2016, 8:12 PM
    I’m going to start preparing a release
  • m

    mysterious-action-44812

    04/15/2016, 8:57 PM
    @ancient-stone-50795: so I have the GH PR, and I’m trying to do the rbcommons one, but I get this: nitay@aiq ~/c/pants (nitay/bootstrap)> ./rbt post -o -g ERROR: There don't seem to be any diffs!
  • m

    mysterious-action-44812

    04/15/2016, 8:57 PM
    any ideas?
  • a

    ancient-stone-50795

    04/15/2016, 9:03 PM
    @mysterious-action-44812: here's what I do: 
    ./rbt post -o --tracking-branch HEAD~1
    (if my change is in one commit). it is a bit of an odd workflow, I admit but this is how I made sense of rbt. I always squash may change into one commit so that HEAD~1 is always right
  • m

    mysterious-action-44812

    04/15/2016, 9:03 PM
    got it so squash before every rbt push
  • m

    mysterious-action-44812

    04/15/2016, 9:03 PM
    but then the GH one wont make sense right? u push to both on updated?
  • b

    bored-art-40741

    04/15/2016, 9:15 PM
    You can just force push that to your PR branch
  • b

    bored-art-40741

    04/15/2016, 9:15 PM
    PRs do basically the right thing when you force push to them
  • m

    mysterious-action-44812

    04/15/2016, 9:28 PM
    i see, ok
  • m

    mysterious-action-44812

    04/15/2016, 9:28 PM
  • j

    jolly-chef-92794

    04/15/2016, 10:15 PM
  • a

    ancient-stone-50795

    04/15/2016, 10:43 PM
    Fishing for reviewers on the release and also non square reviewers of: https://rbcommons.com/s/twitter/r/3696 (junit runner change)
  • m

    mammoth-pharmacist-54215

    04/16/2016, 2:35 AM
    anyone outside twitter around to take a look at https://rbcommons.com/s/twitter/r/3703/?
  • m

    mysterious-action-44812

    04/16/2016, 3:53 AM
    Screen Shot 2016-04-15 at 23.51.21.png
  • m

    mysterious-action-44812

    04/16/2016, 3:54 AM
    im confused why is the pants code downloading itself and then using that instead of using local changes
  • h

    happy-kitchen-89482

    04/16/2016, 5:56 AM
    @ancient-stone-50795: I looked at 3696
  • a

    ancient-stone-50795

    04/16/2016, 10:20 AM
    @mysterious-action-44812 it sounds to me like you are not really invoking pants from source during your test. Maybe you can send me the changes you made to your script? Or maybe it something about the way your pants.ini is setup that is different from ours.
  • a

    ancient-stone-50795

    04/16/2016, 10:24 AM
    This is a bit superstitious, but maybe comment out 
    pants_version
    in pants.ini too
  • m

    mysterious-action-44812

    04/16/2016, 3:43 PM
    Will send in a bit. Everything else other than ivy subsystem does go through my pants code. Also at this point I'm actually running pants from IntelliJ and setting working directory to my other repo. So I know it is going through the pants code just for that one bit it's going into the egg for some reason
  • m

    mysterious-action-44812

    04/16/2016, 3:44 PM
    Will try the pants version also
  • m

    mysterious-action-44812

    04/16/2016, 3:56 PM
    @ancient-stone-50795: this is the pants hack i used - https://gist.github.com/nitay/f26da64f5697c448d114e9f56f3d0894. but as mentioned im actually running it from intellij now. when I comment out pants_version in my other repo I get this error: https://gist.github.com/nitay/144907c4366a19217d583327ae49108c
  • m

    mysterious-action-44812

    04/16/2016, 3:56 PM
    gistfile1_txt.txt
    gistfile1_txt.txt
  • a

    ancient-stone-50795

    04/16/2016, 4:01 PM
    OK, in that case I wonder if your plugins defined in pants.ini are somehow pulling in the pantsbuild.pants pre-built dependency. You might try commenting those out too
  • m

    mysterious-action-44812

    04/16/2016, 4:13 PM
    aha good catch
  • m

    mysterious-action-44812

    04/16/2016, 4:13 PM
    so the only plugin im using is scrooge
  • m

    mysterious-action-44812

    04/16/2016, 4:14 PM
    that must somehow pull in pants itself and then prefer that over the src code?
  • a

    ancient-stone-50795

    04/16/2016, 4:15 PM
    I don't know, it sounds a bit far fetched, but if it works, it sounds like that was the case. It could also just be IJ getting confused.
  • m

    mysterious-action-44812

    04/16/2016, 4:17 PM
    dont think its IJ cause same thing was happening on cmdline
  • m

    mysterious-action-44812

    04/16/2016, 4:17 PM
    that is, my new option wasnt getting picked up
1...116111621163...2420Latest