https://pantsbuild.org/ logo
Powered by
#general
  • a

    ancient-stone-50795

    07/31/2015, 4:26 PM
    ./pants test tests/python/pants_test/tasks:idea_integration
    is failing on my box
  • a

    ancient-stone-50795

    07/31/2015, 4:28 PM
    -.txt
    -.txt
  • e

    enough-analyst-54434

    07/31/2015, 4:28 PM
    Good - nice to have a repro for that
  • e

    enough-analyst-54434

    07/31/2015, 4:34 PM
  • a

    ancient-stone-50795

    07/31/2015, 4:34 PM
    I merged in your change and it looks like it actually did fix the OSX issue.
  • e

    enough-analyst-54434

    07/31/2015, 4:35 PM
    huh
  • e

    enough-analyst-54434

    07/31/2015, 4:35 PM
    So - at the end of the day, there is quite good test coverage for this stuff, but alot of mock
  • e

    enough-analyst-54434

    07/31/2015, 4:36 PM
    and its the mocks that expected/allowed property-style access to sneak by
  • e

    enough-analyst-54434

    07/31/2015, 4:36 PM
    I did not fix that up, I'll sick Kris on it
  • a

    ancient-stone-50795

    07/31/2015, 4:36 PM
    Not that its a surprise, but I can confirm that 
    ./pants ng-killall
    is working again on my laptop as well
  • e

    enough-analyst-54434

    07/31/2015, 4:37 PM
    excellent
  • e

    enough-analyst-54434

    07/31/2015, 4:41 PM
    There is actually no way my fix fixed that osx issue, that looks like osx timing + lack of catch
  • e

    enough-analyst-54434

    07/31/2015, 4:42 PM
    But that's a seperate issue so I'll not fold into the current RB
  • e

    enough-analyst-54434

    07/31/2015, 4:43 PM
    I'll file an issue for that against Kris - that OSX red started on this commit https://github.com/pantsbuild/pants/commit/497ebbb661f903e2aaf8a60f314982323101bf93
  • a

    ancient-stone-50795

    07/31/2015, 4:47 PM
    @enough-analyst-54434: LGTM
  • e

    enough-analyst-54434

    07/31/2015, 4:48 PM
    Ok - that's in
  • e

    enough-analyst-54434

    07/31/2015, 4:49 PM
    Now the other issue is more generic, requires a bit more thought, and should have a test added to cover
  • e

    enough-analyst-54434

    07/31/2015, 4:49 PM
    I can probably get it fixed here in 30 minutes, but not sure if it should block release
  • a

    ancient-stone-50795

    07/31/2015, 4:50 PM
    @bored-art-40741:

    http://2.bp.blogspot.com/-LxxPr7n5BY0/UdnmiNEG2-I/AAAAAAAADAM/BaxUmQtqAeU/s640/release_the_hounds.gif▾

  • b

    bored-art-40741

    07/31/2015, 4:50 PM
    As long as it doesn't stretch more than a couple hours from now I'm fine waiting
  • a

    ancient-stone-50795

    07/31/2015, 4:50 PM
    I don’t know if it is a big deal or not.
  • e

    enough-analyst-54434

    07/31/2015, 4:50 PM
    OK. I'll start hacking on it anyway right now and your call
  • b

    bored-art-40741

    07/31/2015, 4:50 PM
    sgtm, ping me in like an hour with an ETA
  • e

    enough-analyst-54434

    07/31/2015, 4:50 PM
    will do
  • b

    bored-art-40741

    07/31/2015, 4:50 PM
    Or I'll ping you when I start itching
  • m

    mammoth-pharmacist-54215

    07/31/2015, 5:10 PM
    do we adhere to any kind of guidance or standard when it comes to method order inside a module or class?
  • w

    witty-crayon-22786

    07/31/2015, 5:13 PM
    @mammoth-pharmacist-54215: i've never been nitpicked about it on a review, but ymmv
  • m

    mammoth-pharmacist-54215

    07/31/2015, 5:19 PM
    I’ve often found it helps readability if things are fairly consistent… this way you don’t have to search to much to find things like init, we seem to mix nested functions in all over the place rather than putting them at the top of the method and I haven’t been able to figure out any prescribed order to the methods.
  • b

    bored-art-40741

    07/31/2015, 5:22 PM
    There are some basic tendencies but nothing set in stone
  • b

    bored-art-40741

    07/31/2015, 5:22 PM
    class/static methods toward the top, class attributes toward the top, init below that, properties below that, everything else as seems to fit with the code
1...115116117...2420Latest