https://pantsbuild.org/ logo
Powered by
#general
  • a

    ancient-stone-50795

    04/08/2016, 9:24 PM
    @witty-crayon-22786 : don't like 
    pants.global.lock
    how about 
    pants.workspace.lock
    ?
  • w

    witty-crayon-22786

    04/08/2016, 9:24 PM
    +1 to 
    workspace
    or 
    workdir
  • w

    witty-crayon-22786

    04/08/2016, 9:24 PM
    i almost went ahead and suggested that we move the default location into the workdir
  • w

    witty-crayon-22786

    04/08/2016, 9:25 PM
    but that's (...probably?) too much change to slide in here
  • b

    bored-art-40741

    04/08/2016, 9:25 PM
    I've wondered that too
  • b

    bored-art-40741

    04/08/2016, 9:25 PM
    It is, in a sense, a lock on the workdir
  • b

    bored-art-40741

    04/08/2016, 9:25 PM
    Not on the workspace
  • w

    witty-crayon-22786

    04/08/2016, 9:25 PM
    yea... having multiple workdirs mostly works.
  • a

    ancient-stone-50795

    04/08/2016, 9:26 PM
    🚲🏠
    🖌️ 2
  • w

    witty-crayon-22786

    04/08/2016, 9:26 PM
    yea, it's too much to do here.
  • a

    ancient-stone-50795

    04/08/2016, 9:26 PM
    ok, 
    pants.workdir
    sounds like its gaining consensus
  • b

    bored-art-40741

    04/08/2016, 9:27 PM
    I am indifferent re the name
  • b

    bored-art-40741

    04/08/2016, 9:27 PM
    With maybe one exception:
  • b

    bored-art-40741

    04/08/2016, 9:27 PM
    End with 
    .file_lock
    ?
  • b

    bored-art-40741

    04/08/2016, 9:28 PM
    So it's mildly clear that it's used for a file lock, not just its presence
  • a

    ancient-stone-50795

    04/08/2016, 9:28 PM
    Hmm, looks like that file extension is inside the 
    fasteners
    library at first glance
  • w

    witty-crayon-22786

    04/08/2016, 9:28 PM
    file.txt
  • a

    ancient-stone-50795

    04/08/2016, 9:32 PM
    @bored-art-40741: the file extension is a detail built into the fasteners library
  • b

    bored-art-40741

    04/08/2016, 9:32 PM
    Oh does it do that for us?
  • b

    bored-art-40741

    04/08/2016, 9:32 PM
    Copy code
    $ ls ~/.ivy2/pants | grep lock
pants_ivy.file_lock
  • b

    bored-art-40741

    04/08/2016, 9:32 PM
    I'm pretty sure I did that one by hand
  • a

    ancient-stone-50795

    04/08/2016, 9:36 PM
    ok, I thought there was a 
    .lock
    already on the name of the file but there isn't
  • a

    ancient-stone-50795

    04/08/2016, 9:37 PM
    So I could just change it to 
    pants.workdir.file_lock
  • b

    bored-art-40741

    04/08/2016, 9:40 PM
    ++
  • a

    ancient-stone-50795

    04/08/2016, 9:43 PM
    looks like I also need to get .gitignore
  • h

    happy-kitchen-89482

    04/08/2016, 11:43 PM
    Which reminds me, we have some standard .gitignores that every pants repo will need to add. Can we get the install script to do that? Does it already?
  • w

    witty-crayon-22786

    04/08/2016, 11:44 PM
    it does not
  • b

    bored-art-40741

    04/09/2016, 12:03 AM
    Heads up: I'm late on the release today. I'm going to try to get the CR up tonight, but more than likely the release itself will happen tomorrow.
  • a

    ancient-stone-50795

    04/09/2016, 1:48 AM
    I merged the lockfile rename change
  • m

    mysterious-action-44812

    04/09/2016, 3:43 AM
    @witty-crayon-22786: @fast-megabyte-33579 got it, do u have examples of integrating scalastyle in a pants build u can point me to?
1...114111421143...2420Latest