https://pantsbuild.org/ logo
Powered by
#general
  • e

    enough-analyst-54434

    04/08/2016, 12:33 AM
    I'll leave that fix for you @full-kilobyte-93429 , but I'll send up a straw man to eliminate the fully-qualified flags in the http://pantsbuild.github.io/options_reference.html. On the CLI I know the full qualification served a purpose for @ancient-stone-50795 in particular, but in the web UI it only adds confusion IMO (it confused me anyway!).
  • f

    full-kilobyte-93429

    04/08/2016, 12:41 AM
    yup, fixing
  • f

    full-kilobyte-93429

    04/08/2016, 12:46 AM
    https://rbcommons.com/s/twitter/r/3663/ fixes the help
    Copy code
    --[no-]bundle-jvm-deployjar (default: False)
    Expand all 3rdparty and internal jars into loose classfiles in the bundle's
    root dir. If unset, all jars will go into the bundle's libs directory, the
    root will only contain a synthetic jar with its manifest's Class-Path set to
    those jars.
  • w

    wide-energy-11069

    04/08/2016, 12:47 AM
    what is best way to retrieve the target arguments from cli within a task?
  • w

    wide-energy-11069

    04/08/2016, 12:47 AM
    self.context.targets() gives 
    BuildFileAddress
    that is already parsed
  • w

    wide-energy-11069

    04/08/2016, 12:49 AM
    so like 
    ./pants <flag> <target A> <flag> <targetB> <flag>
    , and i just want to 
    <target A>
    <target B>
    in string format.
  • w

    wide-energy-11069

    04/08/2016, 1:02 AM
    ah looks like 
    self.context.options.target_specs
    will do
  • e

    enough-analyst-54434

    04/08/2016, 1:08 AM
    Target.address.spec
    if 
    self.context.options.target_specs
    were not to exist.
  • w

    wide-energy-11069

    04/08/2016, 1:13 AM
    thanks!
  • a

    ancient-stone-50795

    04/08/2016, 11:08 AM
    The fully qualified names from the CLI help you to unambiguously specify an option without having to put in the goal name. I can tell someone what the option is and I know it is going to work no matter where they put it on a command line or whether they are running the goal gen, compile, binary, idea, or test.
  • m

    mysterious-action-44812

    04/08/2016, 2:51 PM
    @witty-crayon-22786 is there a plugin for scalastyle and coveralls in pants?
  • f

    fast-megabyte-33579

    04/08/2016, 3:02 PM
    yes, we had to add a separate register.py to get scalastyle and checkstyle to run
  • f

    fast-megabyte-33579

    04/08/2016, 3:02 PM
    Copy code
    from pants.backend.jvm.tasks.checkstyle import Checkstyle
from pants.backend.jvm.tasks.scalastyle import Scalastyle
from pants.goal.task_registrar import TaskRegistrar as task


def register_goals():
    task(name='checkstyle', action=Checkstyle).install('compile')
    task(name='scalastyle', action=Scalastyle).install('compile')
  • c

    curved-manchester-66006

    04/08/2016, 4:01 PM
    Hackathon complete. Thanks to everyone who answered jvm related questions yesterday
  • w

    witty-crayon-22786

    04/08/2016, 6:11 PM
    @mysterious-action-44812: yes to scalastyle, no to coveralls, afaik
  • w

    witty-crayon-22786

    04/08/2016, 6:12 PM
    @fast-megabyte-33579, @mysterious-action-44812 : patches definitely welcome to move scalastyle/checkstyle into the jvm backend and just toggle their default so that they're installed by default but disabled
  • f

    fast-megabyte-33579

    04/08/2016, 6:32 PM
    yeah, when we get round to actually turning it on we will send a patch
  • f

    fast-megabyte-33579

    04/08/2016, 6:32 PM
    it is a little noisy atm
  • a

    ancient-stone-50795

    04/08/2016, 6:54 PM
    @bored-art-40741: are you doing the release today? I hope you can land the lock renaming patch first.
  • b

    bored-art-40741

    04/08/2016, 6:55 PM
    oops, I blanked on the release
  • b

    bored-art-40741

    04/08/2016, 6:55 PM
    Yes I'll do it today
  • b

    bored-art-40741

    04/08/2016, 6:55 PM
    I still haven't heard back from most reviews on the lock cleanup patch
  • b

    bored-art-40741

    04/08/2016, 6:56 PM
    And Stu raised an issue
  • b

    bored-art-40741

    04/08/2016, 7:37 PM
    So @witty-crayon-22786 @ancient-stone-50795 would appreciate if you took another look at that CR if you want it in this release
  • w

    witty-crayon-22786

    04/08/2016, 7:37 PM
    ...which?
  • w

    witty-crayon-22786

    04/08/2016, 7:41 PM
    @bored-art-40741: i'm happy with an immediate deprecation of https://rbcommons.com/s/twitter/r/3650/
  • w

    witty-crayon-22786

    04/08/2016, 7:42 PM
    ...but... i'm confused. either this is a thing we want to do by default (temporarily?) or not...
  • a

    ancient-stone-50795

    04/08/2016, 7:42 PM
    @witty-crayon-22786: https://rbcommons.com/s/twitter/r/3650/ @bored-art-40741: same here, just add 
    deprecated_hint=
    and 
    deprecated_version=
    to the option and we're good to go.
  • a

    ancient-stone-50795

    04/08/2016, 7:43 PM
    Wait, if we deprecate it immeidatly our users are going to see a warning every time we run pants.
  • w

    witty-crayon-22786

    04/08/2016, 7:43 PM
    @ancient-stone-50795: do you have a better idea of why we need that option? my issue with it was simply: "i don't know precisely why we need this, and the option doesn't make it clear"
1...113911401141...2420Latest