https://pantsbuild.org/ logo
Powered by
#general
  • e

    enough-analyst-54434

    07/31/2015, 2:21 PM
    At any rate, can you re-run with 
    JAVA_HOME=... ./pants ...
  • e

    enough-analyst-54434

    07/31/2015, 2:21 PM
    and ensure JAVA_HOME points to the non-symlink path?
  • e

    enough-analyst-54434

    07/31/2015, 2:21 PM
    That should behave correctly
  • m

    mammoth-autumn-2551

    07/31/2015, 2:22 PM
    okay
  • m

    mammoth-autumn-2551

    07/31/2015, 2:23 PM
    side note, seems like I’ll be trying to upgrade to 0.0.40 pretty soon… the only pending change that worries me would be:
    Copy code
    Migrate ApacheThriftGen to SimpleCodegenTask.
    https://github.com/pantsbuild/pants/commit/a8a73797a50f53fc48c57e1fdaf6b8211e267c67
  • m

    mammoth-autumn-2551

    07/31/2015, 2:23 PM
    @enough-analyst-54434: the only change in behavior is the strict mode, yes?
  • e

    enough-analyst-54434

    07/31/2015, 2:23 PM
    No - not really
  • e

    enough-analyst-54434

    07/31/2015, 2:24 PM
    We now correctly invalidate for a change from strict to non-strict
  • e

    enough-analyst-54434

    07/31/2015, 2:24 PM
    but the actual stub gen is unchanged
  • e

    enough-analyst-54434

    07/31/2015, 2:24 PM
    The big change will be gen is slower now
  • e

    enough-analyst-54434

    07/31/2015, 2:24 PM
    But you may not notice
  • m

    mammoth-autumn-2551

    07/31/2015, 2:25 PM
    "The big change will be gen is slower” sounds like an april fools item on the release notes simple smile
  • e

    enough-analyst-54434

    07/31/2015, 2:25 PM
    heh
  • e

    enough-analyst-54434

    07/31/2015, 2:25 PM
    The slowness should be in the noise of your builds
  • e

    enough-analyst-54434

    07/31/2015, 2:25 PM
    Unless you have Twitter-size thrift issues
  • m

    mammoth-autumn-2551

    07/31/2015, 2:26 PM
    nah our thrift stuff is just wrapped up as a single library, and not a significant part of our build time
  • a

    ancient-stone-50795

    07/31/2015, 2:27 PM
    It gets cached between builds too. We’ve been using the simple codegen with protobuf for a while and it isn’t significantly slower.
  • m

    mammoth-autumn-2551

    07/31/2015, 2:27 PM
    So I have to say, I’m super grateful for the help from you guys the last few weeks… so I want to ask, what exactly is your recommendation with regards to pants upgrades internal to our organization?
  • e

    enough-analyst-54434

    07/31/2015, 2:27 PM
    Well - for the thrift case, it used to be parallelized, which was lost in simple move
  • m

    mammoth-autumn-2551

    07/31/2015, 2:27 PM
    It seems like keeping near to head makes the problems a lot easier to address
  • m

    mammoth-autumn-2551

    07/31/2015, 2:27 PM
    (when I report them)
  • e

    enough-analyst-54434

    07/31/2015, 2:27 PM
    +1
  • e

    enough-analyst-54434

    07/31/2015, 2:27 PM
    Arch linux man
  • e

    enough-analyst-54434

    07/31/2015, 2:27 PM
    Yes - the reporting is key
  • e

    enough-analyst-54434

    07/31/2015, 2:28 PM
    Big drift is hard to diagnose
  • m

    mammoth-autumn-2551

    07/31/2015, 2:28 PM
    Okay, I’ll try to make this part of my monday routine then. I think I just need to build a regression suite that exercises all of our pants usages internally so I can do that upgrade efficiently
  • a

    ancient-stone-50795

    07/31/2015, 2:28 PM
    We have been trying to keep track of option migrations, but for changes to build file syntax and stuff, we deprecate for a while, (a few weeks?) then remove the code.
  • a

    ancient-stone-50795

    07/31/2015, 2:29 PM
    That’s what we do. I have a test for 
    ./pants idea
    , 
    ./pants compile
    and 
    ./pants test
    . The test is separate because it takes 15 hours...
  • a

    ancient-stone-50795

    07/31/2015, 2:30 PM
    We have a parallel builder, but we don’t have everything in CI moved to pants yet, so I’m still using hte old jenkins job to validate new pants builds
  • m

    mammoth-autumn-2551

    07/31/2015, 2:31 PM
    Cool, you guys rock, thanks again!
1...110111112...2420Latest