Ergonomic, hermetic, user-friendly software build system for Python, Go, Java, Kotlin, Protobuf, Scala, Shell. Pants lets you fearlessly scale up your codebase!

Pants

Hi guys! I'm getting duplicate class/resource errors while trying to bundle

```Duplicate classes and/or resources detected in artifacts: ('mysql-mysql-connector-java-5.1.34.jar', 'org.objenesis-objenesis-2.1.jar')
                        META-INF/INDEX.LIST
                   Duplicate classes and/or resources detected in artifacts: ('commons-logging-commons-logging-1.2.jar', 'org.slf4j-jcl-over-slf4j-1.7.6.jar')
                        org/apache/commons/logging/Log.class
                        org/apache/commons/logging/impl/NoOpLog.class
```

i added a shading rule trying to fix the second case, but it didn't work (although jarajr did execute)

```jvm_binary(name = 'bulk-index-bin',
  dependencies = [
    ':search',
  ],
  shading_rules = [
    shading_relocate_package('org.apache.commons.logging.**')
  ],
  main = 'com.compstak.search.indexer.BulkIndex'
)
```

the shading likely happens after the duplicate check

yes, its a warning, but is it something that can be ignored?

it looks like there will be collisions, no?

<@U0UKJ9XCY>: there are collisions, yes: but that's a property of your dependencies

pants doesn't currently support automatically shading within dependencies

for one thing, the solution is often to change dependencies (ie, not depend on a thing) rather than to just shade it away

but yea, it would be great to be able to specify shading at the dep level.

You may be able to exclude the jars you don’t want if they’re transitive deps

Or if it’s a version problem you can use `managed_jar_dependencies` or `managed_jar_libraries` to select which versions you want

probably can't exclude either of those though

you probably want only one of jcl-over-slf4j vs commons-logging-commons-logging

We excluded commons logging globally in our repo for a long time :stuck_out_tongue:

the "right" place to fix that usually is in 3rdparty

ya, i'll exclude it there, i do have other things excluded, ill add this too

whatever has a dep on ` commons-logging-commons-logging` could have an exclude, with an optional replacement with the slf4j thing

also, in the final bundle, i see many jars of the form abc-1.jar, abc-2.jar, etc