#general
- b
bored-art-40741
03/23/2016, 7:56 PM@ancient-stone-50795: I haven't noticed it, no--and yes, I'm worried about our internal CI - b
bored-art-40741
03/23/2016, 7:57 PMOSS Pants Jenkins workers aren't going to see the PID rolling issue because they're so short lived - b
bored-art-40741
03/23/2016, 7:59 PMThe pants "global" lock doesn't bother me at all--we already clean it up because jenkins has a "lock" on the workspace anyway and can safely clean it - b
bored-art-40741
03/23/2016, 7:59 PMBut the same is definitely not true for the ivy cache - a
ancient-stone-50795
03/23/2016, 8:00 PMOK, what about this solution: 1) add a flag --lock in ivy.py to guard this behavior. Set it off by default 2) Land this change with above said guard 3) File a ticket to fix the implementation of the OwnerPid... lock - a
ancient-stone-50795
03/23/2016, 8:00 PMIn this case, we can keep jenkins working by setting the lock flag to on, and nobody else gets potentially broken behavior. when 3 lands, we turn the ivy locking on by default. - b
bored-art-40741
03/23/2016, 8:01 PMIf we're going to add an option anyway, why not always lock but have the flag be to choose which lock impl is used? - a
ancient-stone-50795
03/23/2016, 8:01 PMbecause none of us have time to vet a new implementation before friday apparently. - a
ancient-stone-50795
03/23/2016, 8:01 PMholy 👖 I got up at 5am to fix this problem! - w
witty-crayon-22786
03/23/2016, 8:06 PMa revert then...? - a
ancient-stone-50795
03/23/2016, 8:08 PMI think a revert is OK, I just didn't want to break jenkins any more than we had to. - b
bored-art-40741
03/23/2016, 8:10 PMI think I'd prefer a revert. I'm willing to vet this in the medium term, but probably not before Friday, and I don't think Pants Jenkins is seeing much use anyway - b
bored-art-40741
03/23/2016, 8:10 PMHm or maybe I'm wrong - b
bored-art-40741
03/23/2016, 8:11 PMOkay, I concede--just use the
as is, I'll ship the CROwnerPrintingPIDLockFile - b
bored-art-40741
03/23/2016, 8:11 PMI won't ship that internally, but I probably won't have time to upgrade until next week anyway - b
bored-art-40741
03/23/2016, 8:12 PMAnd let's file a ticket to track it - b
bored-art-40741
03/23/2016, 8:12 PM@ancient-stone-50795: ^^ 3598 is shipped - a
ancient-stone-50795
03/23/2016, 8:16 PMI've got a ticket open: https://github.com/pantsbuild/pants/issues/3075 is that sufficient in your mind to track it? - a
ancient-stone-50795
03/23/2016, 8:17 PMI can just leave it open after 3598 lands. - b
bored-art-40741
03/23/2016, 8:27 PMYup, commented - a
ancient-stone-50795
03/23/2016, 8:31 PM@jolly-chef-92794: I see you cleverly avoiding a ship-it until the smoke is cleared and bloody bodies covering the PR battlefield.👼 1👍 1 - b
bored-art-40741
03/23/2016, 8:35 PMThat's called political savvy - a
ancient-stone-50795
03/23/2016, 8:37 PMSo, in other news, I sent an email to our comms team on Monday about communicating our pants release. Today I got a linked in announcement that my contact in comms just got a new job at FB! - a
ancient-stone-50795
03/23/2016, 8:38 PMI don't think it impacts us too much as far as I was just planning another http://corner.squareup.com/ blogpost and tweet it from our corp engineering twitter account - w
witty-crayon-22786
03/23/2016, 8:41 PMmm. yea, we hadn't started drafting anything. - w
witty-crayon-22786
03/23/2016, 8:41 PM(iirc, @happy-kitchen-89482 had signed up for that honor?) - h
happy-kitchen-89482
03/23/2016, 8:41 PMSo I did - h
happy-kitchen-89482
03/23/2016, 8:42 PMHmm, and I want to deprecate action=‘append’ by then too - h
happy-kitchen-89482
03/23/2016, 8:43 PMI’ll get started on both tonight - w
witty-crayon-22786
03/23/2016, 8:44 PMkeeping in mind that it actual release will likely be ~1 week earlier than May 1st... @mammoth-pharmacist-54215 will be working on a draft of the branch strategy