https://pantsbuild.org/ logo
Powered by
#general
  • m

    mammoth-pharmacist-54215

    03/22/2016, 7:09 PM
    well by fixed you mean it should blow up if someone specifies custom and doesn’t have an on disk target?
  • m

    mammoth-pharmacist-54215

    03/22/2016, 7:10 PM
    preferably with a useful error message
  • b

    bored-art-40741

    03/22/2016, 7:10 PM
    Yeah that's a good start. I'm also just wary of 
    custom
    having any defaults at all
  • b

    bored-art-40741

    03/22/2016, 7:10 PM
    I'd say if you choose 
    custom
    , you should have to specify everything
  • m

    mammoth-pharmacist-54215

    03/22/2016, 7:11 PM
    without a significant rewrite of how bootstrapping happens I don’t know that is possible.
  • w

    witty-crayon-22786

    03/22/2016, 7:11 PM
    that's a large and growing list though, unfortunately.
  • m

    mammoth-pharmacist-54215

    03/22/2016, 7:11 PM
    I can make it fail if you don’t specify everything though.
  • w

    witty-crayon-22786

    03/22/2016, 7:11 PM
    and actually, i think in many cases somebody saying "custom" doesn't actually need to customize every tool
  • m

    mammoth-pharmacist-54215

    03/22/2016, 7:12 PM
    I’d rather force the user to specify all tools then have them accidentally get tools they didn’t expect.
  • b

    bored-art-40741

    03/22/2016, 7:13 PM
    =molsen
  • l

    limited-country-20626

    03/22/2016, 7:13 PM
    =molsen
  • m

    mammoth-pharmacist-54215

    03/22/2016, 7:13 PM
    right now if you do something like override the runtime and forget compiler you can get mismatches.
  • m

    mammoth-pharmacist-54215

    03/22/2016, 7:13 PM
    and its not obvious to the user
  • w

    witty-crayon-22786

    03/22/2016, 7:13 PM
    and scalastyle
  • w

    witty-crayon-22786

    03/22/2016, 7:13 PM
    =P
  • m

    mammoth-pharmacist-54215

    03/22/2016, 7:13 PM
    true
  • m

    mammoth-pharmacist-54215

    03/22/2016, 7:14 PM
    I burned some time trying to figure out a reasonable way to create a custom spec for jvm build tools but that would be a big mess on the current engine… detecting if a target is on disk should be doable though.
  • j

    jolly-chef-92794

    03/22/2016, 7:18 PM
    @witty-crayon-22786: Do you have more thoughts on https://rbcommons.com/s/twitter/r/3582/ ?
  • w

    witty-crayon-22786

    03/22/2016, 7:18 PM
    yea, was just about to comment. scopes look great.
  • w

    witty-crayon-22786

    03/22/2016, 7:18 PM
    ...but i'm worried about transitivity
  • w

    witty-crayon-22786

    03/22/2016, 7:18 PM
    you mentioned 
    intransitive_deps=[..]
  • w

    witty-crayon-22786

    03/22/2016, 7:19 PM
    ...as a possibility. but also, i wonder whether something like an inverse of bazel's 
    exported_deps
    would make more sense?
  • w

    witty-crayon-22786

    03/22/2016, 7:19 PM
    basically, i don't want to tick you off, but i'm wondering how you would feel about landing scopes, but splitting transitivity out as another review
  • j

    jolly-chef-92794

    03/22/2016, 7:20 PM
    Wouldn’t the inverse of 
    exported_deps
    be equivalent to 
    intransitive deps
    ?
  • w

    witty-crayon-22786

    03/22/2016, 7:20 PM
    not sure... bazel is strict_deps by default
  • w

    witty-crayon-22786

    03/22/2016, 7:20 PM
    so exported_deps is a case that breaks through strict_deps
  • w

    witty-crayon-22786

    03/22/2016, 7:20 PM
    ie, definitely give this to my consumers
  • w

    witty-crayon-22786

    03/22/2016, 7:21 PM
    basically, transitivity seems hard.
  • w

    witty-crayon-22786

    03/22/2016, 7:21 PM
    and i know you guys need it, so
  • w

    witty-crayon-22786

    03/22/2016, 7:21 PM
    the scopes address a lot of cases
1...108010811082...2420Latest