https://pantsbuild.org/ logo
Powered by
#general
  • a

    average-yacht-43028

    03/22/2016, 6:49 PM
    BUILD.tools
  • a

    average-yacht-43028

    03/22/2016, 6:49 PM
    Copy code
    jar_library(name = 'scalac',
            jars = [
              jar(org = 'org.scala-lang', name = 'scala-compiler', rev = '2.11.5'),
            ])

jar_library(name = 'scala-library',
            jars = [
              jar(org = 'org.scala-lang', name = 'scala-library', rev = '2.11.5'),
            ])

jar_library(name = 'scala',
            jars = [
              jar(org = 'org.scala-lang', name = 'jline', rev = '2.11.5', intransitive = True),
            ],
            dependencies = [
              ':scalac',
              ':scala-library',
            ])

jar_library(name = 'scalastyle',
            jars = [
              scala_jar(org='org.scalastyle', name='scalastyle', rev='0.3.2')
            ])
  • a

    average-yacht-43028

    03/22/2016, 6:49 PM
    BUILD
  • b

    bored-art-40741

    03/22/2016, 6:49 PM
    Copy code
    def register_scala_compiler(version):
      name = scala_build_info[version].compiler_name
      version = scala_build_info[version].full_version
      _register_tool('org.scala-lang', 'scala-compiler', name, version)
  • b

    bored-art-40741

    03/22/2016, 6:49 PM
    Pretty sure it registers the wrong compiler no matter what, @mammoth-pharmacist-54215
  • b

    bored-art-40741

    03/22/2016, 6:49 PM
    I would like to see a working example of custom + 2.11 + runtime-spec
  • m

    mammoth-pharmacist-54215

    03/22/2016, 6:50 PM
    for custom its scalac and 2.10.4, which is based on the scala_build_info
  • m

    mammoth-pharmacist-54215

    03/22/2016, 6:51 PM
    as long as you create a scalac target in BUILD.tools it will load you custom scalac
  • m

    mammoth-pharmacist-54215

    03/22/2016, 6:51 PM
    however currently if you don’t specify a target in BUILD.tools and use custom it uses 2.10.4 and doesn’t fail
  • m

    mammoth-pharmacist-54215

    03/22/2016, 6:51 PM
    which is bad
  • b

    bored-art-40741

    03/22/2016, 6:51 PM
    hm okay
  • b

    bored-art-40741

    03/22/2016, 6:52 PM
    @average-yacht-43028: Did you mean to paste a second BUILD file?
  • b

    bored-art-40741

    03/22/2016, 6:52 PM
    You'll need one for your scala target too
  • a

    average-yacht-43028

    03/22/2016, 6:52 PM
    Copy code
    scala_library(
    name='utils',
    sources=rglobs('src/*'),
    dependencies = [
       '3rdparty:metricsScala',
       '3rdparty:metricsJvm',
       '3rdparty:metricsJson',
       '3rdparty:metricsStatsD',
       '3rdparty:slf4s',
       '3rdparty:jacksonScalaModule',
       '3rdparty:jacksonCore',
       '3rdparty:jacksonJoda',
       '3rdparty:playJson',
       '3rdparty:playWS',
    ],
)
  • a

    average-yacht-43028

    03/22/2016, 6:52 PM
    this is the build file for the utils project i showed above
  • b

    bored-art-40741

    03/22/2016, 6:53 PM
    @mammoth-pharmacist-54215: Actually I'm still unconvinced
  • b

    bored-art-40741

    03/22/2016, 6:53 PM
    Copy code
    def compiler_classpath(self, products):
    """Return the proper classpath based on products and scala version."""
    compiler_name = scala_build_info.get(self._get_label()).compiler_name
    return self.tool_classpath_from_products(products, compiler_name, scope=self.options_scope)
  • a

    average-yacht-43028

    03/22/2016, 6:53 PM
    rglobs is nice, i was using globs before and had to specify accurate paths
  • b

    bored-art-40741

    03/22/2016, 6:53 PM
    I think you get the 2.10 compiler classpath no matter what with custom
  • b

    bored-art-40741

    03/22/2016, 6:53 PM
    I'd like to see an actual example of this working
  • w

    witty-crayon-22786

    03/22/2016, 6:53 PM
    @average-yacht-43028: "i was using globs before and had to specify accurate paths"... generally a good thing 😃
  • b

    bored-art-40741

    03/22/2016, 6:54 PM
    I think Parvez is just going for a proof of concept
  • w

    witty-crayon-22786

    03/22/2016, 6:54 PM
  • b

    bored-art-40741

    03/22/2016, 6:54 PM
    But yeah, this would probably be easier to debug if the targets were a bit more granular @average-yacht-43028
  • b

    bored-art-40741

    03/22/2016, 6:54 PM
    In particular I'm not sure if you can have a target own sources which are ABOVE its source root
  • b

    bored-art-40741

    03/22/2016, 6:54 PM
    Try moving that BUILD file down into 
    src/scala
  • a

    average-yacht-43028

    03/22/2016, 6:56 PM
    ok
  • b

    bored-art-40741

    03/22/2016, 6:57 PM
    Ah, and in particular you need to have the glob/rglob be relative to the directory the BUILD file is in
  • a

    average-yacht-43028

    03/22/2016, 6:58 PM
    ya, i set it up that way
  • m

    mammoth-pharmacist-54215

    03/22/2016, 7:01 PM
    @bored-art-40741: I thought you had gotten scala 2.11 to work locally?
1...107810791080...2420Latest