https://pantsbuild.org/ logo
Powered by
#general
  • b

    bored-art-40741

    03/19/2016, 5:16 PM
    Done, also added everyone else as owners
  • b

    bored-art-40741

    03/19/2016, 5:16 PM
    Did I just happen to get ownership because I was the first to release that new contrib package?
  • a

    ancient-stone-50795

    03/19/2016, 6:39 PM
    Yeah
  • a

    ancient-stone-50795

    03/20/2016, 2:16 PM
    0.0.77 is out!
  • h

    happy-kitchen-89482

    03/20/2016, 5:17 PM
    Quick poll: How many list-typed options do you have in your custom plugins, and what is the type of their members?
  • h

    happy-kitchen-89482

    03/20/2016, 5:18 PM
    Should be easy to find with 
    git grep “type=list_option"
  • h

    happy-kitchen-89482

    03/20/2016, 5:19 PM
    Ditto re 
    git grep "action='append’"
  • h

    happy-kitchen-89482

    03/20/2016, 5:19 PM
    cc @ancient-stone-50795 @bored-art-40741 @witty-crayon-22786
  • b

    bored-art-40741

    03/20/2016, 5:23 PM
    Copy code
    src/python/foursquare/pants/codegen/python_thrift_gen.py:51:    register('--deps', advanced=True, type=list_option,
src/python/foursquare/pants/codegen/python_thrift_gen.py:53:    register('--service-deps', advanced=True, type=list_option,
src/python/foursquare/pants/codegen/scala_js_bundle.py:67:    register('--runtime-deps', advanced=True, type=list_option, default=[])
src/python/foursquare/pants/codegen/soy_codegen_task.py:65:    register('--jvm-options', advanced=True, type=list_option, default=[])
src/python/foursquare/pants/codegen/soy_codegen_task.py:66:    register('--runtime-deps', advanced=True, type=list_option, default=[])
src/python/fsqio/pants/pom/pom_resolve.py:299:      type=list_option,
src/python/fsqio/pants/pom/pom_resolve.py:343:      type=list_option,
src/python/fsqio/pants/spindle/tasks/spindle_gen.py:47:      type=list_option,
src/python/fsqio/pants/spindle/tasks/spindle_gen.py:53:      type=list_option,
src/python/fsqio/pants/spindle/tasks/spindle_gen.py:59:      type=list_option,
  • b

    bored-art-40741

    03/20/2016, 5:24 PM
    And maybe half a dozen 
    action='append'
    (lots more outside of our pants code though)
  • h

    happy-kitchen-89482

    03/20/2016, 5:33 PM
    aha, yes, if you use argparse elsewhere in your repo you will get a lot of false positives on 
    action=‘append’
  • h

    happy-kitchen-89482

    03/20/2016, 5:33 PM
    So in the cases you posted, what are the member types? And are they correct?
  • w

    witty-crayon-22786

    03/20/2016, 5:41 PM
    Copy code
    pants-plugins/src/python/twitter/pants_internal/build_helpers/consume_thrift_libraries_subsystem.py:    register('--thrift-jar-dependencies', advanced=True, type=list_option, default=[],
pants-plugins/src/python/twitter/pants_internal/build_helpers/consume_thrift_libraries_subsystem.py:    register('--thrift-jar-scala-excludes', advanced=True, type=list_option, default=[],
pants-plugins/src/python/twitter/pants_internal/build_helpers/consume_thrift_libraries_subsystem.py:    register('--thrift-jar-java-excludes', advanced=True, type=list_option, default=[],
pants-plugins/src/python/twitter/pants_internal/build_helpers/create_thrift_libraries_subsystem.py:    register('--generate-languages', default=['scala', 'java', 'ruby', 'python'], advanced=True, type=list_option,
pants-plugins/src/python/twitter/pants_internal/subsystems/node_packer_module_resolver.py:    register('--valid-packer-dcs', type=list_option,
pants-plugins/src/python/twitter/pants_internal/subsystems/twitter_tests.py:    register('--valid-environments', type=list_option,
pants-plugins/src/python/twitter/pants_internal/tasks/consolidate_classpath.py:    register('--patterns', type=list_option, default=[],
pants-plugins/src/python/twitter/pants_internal/tasks/dataset_gen.py:    register('--dependencies', type=list_option,
pants-plugins/src/python/twitter/pants_internal/tasks/ensure_tests.py:    register('--whitelist-paths', type=list_option, default=[], advanced=True,
pants-plugins/src/python/twitter/pants_internal/tasks/scrooge_generator_cocoa.py:    register('--jvm-options', default=[], advanced=True, type=list_option,
pants-plugins/src/python/twitter/pants_internal/tasks/thriftstore_dml_gen.py:    register('--javadeps', default=[], advanced=True, type=list_option,
  • w

    witty-crayon-22786

    03/20/2016, 5:42 PM
    strings, targets, excludes
  • w

    witty-crayon-22786

    03/20/2016, 5:43 PM
    Copy code
    pants-plugins/src/python/twitter/pants_internal/tasks/build_props/base.py:    register('--extra', default=[], action='append',
pants-plugins/src/python/twitter/pants_internal/tasks/dataset_gen.py:    register('--jvm-options', action='append', metavar='<option>...', advanced=True,
pants-plugins/src/python/twitter/pants_internal/tasks/ensure_tests.py:    register('--jvm-options', action='append', metavar='<option>...',
pants-plugins/src/python/twitter/pants_internal/tasks/persisted_schema_compatibility_checker.py:    register('--jvm-options', action='append', metavar='<option>...', advanced=True, fingerprint=True,
pants-plugins/src/python/twitter/pants_internal/tasks/source_dep_list.py:    register('--manual-override-file', default=[], action='append',
pants-plugins/src/python/twitter/pants_internal/tasks/twitter_tests.py:        action='append',
  • w

    witty-crayon-22786

    03/20/2016, 5:47 PM
    tuples of strings, strings, files
  • h

    happy-kitchen-89482

    03/20/2016, 5:50 PM
    lists of excludes?
  • h

    happy-kitchen-89482

    03/20/2016, 5:50 PM
    those are strings?
  • h

    happy-kitchen-89482

    03/20/2016, 5:50 PM
    regexes?
  • w

    witty-crayon-22786

    03/20/2016, 5:52 PM
    oh, i take it back. those are just strings as well it looks like.
  • h

    happy-kitchen-89482

    03/20/2016, 6:05 PM
    Either way, you don’t have lists-of-lists or lists-of-tuples it sounds like
  • a

    adorable-glass-89507

    03/20/2016, 8:19 PM
    what are the defaults for these values:
    Copy code
    #   user: the current user
#   homedir: the current user's home directory
#   buildroot: the root of this repo
#   pants_bootstrapdir: the global pants scratch space primarily used for caches
#   pants_supportdir: pants support files for this repo go here# for example: ivysettings.xml
#   pants_distdir: user visible artifacts for this repo go here
#   pants_workdir: the scratch space used to for live builds in this repo
  • a

    ancient-stone-50795

    03/20/2016, 11:35 PM
    @adorable-glass-89507: Try 
    ./pants help --help-advanced
  • a

    ancient-stone-50795

    03/20/2016, 11:37 PM
    Most of them are listed as options values:
    Copy code
    ...
--pants-config-files="['str1','str2',...]" (default: ['/Users/zundel/Src/pants/pants.ini'])
    Paths to Pants config files.
--pants-configdir=<dir> (default: '/Users/zundel/.config/pants')
    Use this dir for global config files.
--pants-distdir=<dir> (default: '/Users/zundel/Src/pants/dist')
    Write end-product artifacts to this dir.
--pants-supportdir=<dir> (default: '/Users/zundel/Src/pants/build-support')
    Use support files from this dir.
--pants-version=<str> (default: '0.0.77')
    Use this pants version.
--pants-workdir=<dir> (default: '/Users/zundel/Src/pants/.pants.d')
    Write intermediate output files to this dir.
  • a

    ancient-stone-50795

    03/20/2016, 11:37 PM
    I don't see buildroot listed there, but that's the root of the repo. User and homedir come from the operating system.
  • a

    adorable-glass-89507

    03/20/2016, 11:39 PM
    thanks
  • a

    ancient-stone-50795

    03/20/2016, 11:39 PM
    @happy-kitchen-89482: we have one:
    Copy code
    excludes:  [
   { "org": "org.slf4j",
     "name": "log4j-over-slf4j"},
   { "org": "org.eclipse.jetty.orbit",
     "name": "javax.servlet" },
  ...
  • a

    ancient-stone-50795

    03/20/2016, 11:40 PM
    register('--excludes', advanced=True, type=list_option, default=[], fingerprint=True,
  • h

    happy-kitchen-89482

    03/21/2016, 4:54 AM
    list-of-dicts
  • h

    happy-kitchen-89482

    03/21/2016, 4:54 AM
    you’ll need to set 
    member_type='dict_option’
    on it
1...107310741075...2420Latest