https://pantsbuild.org/ logo
Powered by
#general
  • j

    jolly-chef-92794

    03/18/2016, 8:27 PM
    Backing up a moment. If I understand, the structure for this that you’d find agreeable would look like:
    Copy code
    jar_library(name=‘hadoop’,
  …
)
target(name=‘hadoop-for-libraries’,
  scope=‘compile’,
  transitive=False,
  dependencies=[‘:hadoop’],
)
target(name=‘hadoop-for-tests’,
  scope=’runtime’,
  dependencies=[‘:hadoop’],
)
java_library(name=‘lib’,
  dependencies=[‘:hadoop-for-libraries’],
)
junit_tests(name=‘test’,
  dependencies=[‘:hadoop-for-tests’],
)
    ?
  • w

    witty-crayon-22786

    03/18/2016, 8:29 PM
    @jolly-chef-92794: no... in the absence of transitivity this is just:
  • w

    witty-crayon-22786

    03/18/2016, 8:29 PM
    Copy code
    jar_library(name='hadoop',
  scopes=['compile', 'test'],
)
java_library(name='lib',
  dependencies=[':hadoop'],
)
junit_tests(name='test',
  dependencies=[':hadoop'],
)
jvm_binary(name='test',
  dependencies=[':hadoop'],
)
  • w

    witty-crayon-22786

    03/18/2016, 8:29 PM
    no need for indirection, etc.
  • w

    witty-crayon-22786

    03/18/2016, 8:29 PM
    only graph shape changes need the indirection (which is ironic, because they change the shape)
  • a

    ancient-stone-50795

    03/18/2016, 8:30 PM
    Releasing a new version of junit-runner to nexus...
  • j

    jolly-chef-92794

    03/18/2016, 8:35 PM
    compile
    and 
    test
    are mutually exclusive right now, but that’s kind of a technical detail. So with transitivity, it’d look like:
    Copy code
    jar_library(name='hadoop',
  scopes=['compile', 'test'],
)
target(name=‘hadoop-intransitive’,
  intransitive=True,
  dependencies=[‘:hadoop’],
)
java_library(name='lib',
  dependencies=[‘:hadoop-intransitive'],
)
junit_tests(name='test',
  dependencies=[':hadoop'],
)
jvm_binary(name='test',
  dependencies=[':hadoop'],
)
  • j

    jolly-chef-92794

    03/18/2016, 8:38 PM
    To be more accurate, we would probably want to call the options 
    classpath_scopes
    and 
    classpath_transitive
    though
  • j

    jolly-chef-92794

    03/18/2016, 8:39 PM
    Which is a bit icky because now we’re adding variables to 
    target()
    that are explicitly relevant only to 
    jvm_targets()
  • j

    jolly-chef-92794

    03/18/2016, 8:39 PM
    Using 
    scopes
    in the more generic sense, we at least maintain a semblance of general applicability
  • r

    rough-minister-58256

    03/18/2016, 8:40 PM
    @clever-ambulance-21321: I’m not aware of any serious users of pants in c/c++ code bases. there’s basic support tho - just needs adoption and more work.
  • c

    clever-ambulance-21321

    03/18/2016, 8:40 PM
    kwlzn: OK, I've gotten further now - I have a pex file that's built. And when I try to run it, it runs. But when I try to go to / in the app and that tries to load templates/index.html, the log throws the error IOError: [Errno 20] Not a directory: '/home/buss/ignition.pex/templates/index.html'
  • r

    rough-minister-58256

    03/18/2016, 8:40 PM
    feel free to file bugs etc as you uncover shortcomings
  • c

    clever-ambulance-21321

    03/18/2016, 8:40 PM
    Cool, thanks
  • r

    rough-minister-58256

    03/18/2016, 8:42 PM
    @clever-ambulance-21321: yeah, so this is a problem with flask or w/e trying to load resources from the pex. it doesn’t understand how to load assets inside of a zip - so you can either write a loader that uses 
    pkg_resources.resource_stream
    etc OR set 
    zip_safe=False
    on your targets to make pex auto-explode the zip at runtime.
  • r

    rough-minister-58256

    03/18/2016, 8:42 PM
    initially zip_safe is probably easiest
  • c

    clever-ambulance-21321

    03/18/2016, 8:43 PM
    OK, like this? python_binary( name='theapp', dependencies=[ '3rdparty/python:Flask', '3rdparty/python:gevent', ], resources=globs('static/*', 'templates/*'), source=theapp.py, zip_safe=False )
  • r

    rough-minister-58256

    03/18/2016, 8:44 PM
    yup
  • c

    clever-ambulance-21321

    03/18/2016, 8:44 PM
    Hmm.. I don't notice any change
  • c

    clever-ambulance-21321

    03/18/2016, 8:44 PM
    rebuilt and reran
  • r

    rough-minister-58256

    03/18/2016, 8:45 PM
    what’s the path in the IOError now?
  • c

    clever-ambulance-21321

    03/18/2016, 8:45 PM
    Same. IOError: [Errno 20] Not a directory: '/home/buss/ignition.pex/templates/index.html'
  • c

    clever-ambulance-21321

    03/18/2016, 8:46 PM
    Oh is it supposed to be '/home/buss/templates/index.html'
  • r

    rough-minister-58256

    03/18/2016, 8:48 PM
    depends how its finding the path to the templates - but its odd that its looking in the same path even after zip_safe=False
  • r

    rough-minister-58256

    03/18/2016, 8:48 PM
    you can run the pex exploded as a test - just unzip it into a dir and then do a 
    cd dir && python2.7 .
  • c

    clever-ambulance-21321

    03/18/2016, 8:49 PM
    That works
  • c

    clever-ambulance-21321

    03/18/2016, 8:50 PM
    By 'explode at runtime' do you mean I should literally see all the files get unzipped?
  • c

    clever-ambulance-21321

    03/18/2016, 8:50 PM
    because I don't
  • r

    rough-minister-58256

    03/18/2016, 8:52 PM
    yeah - it should explode the pex under 
    ~/.pex/
    by default
  • r

    rough-minister-58256

    03/18/2016, 8:52 PM
    you can try 
    PEX_VERBOSE=9 ./the.pex
    to get some debug output about the runtime
1...107010711072...2420Latest