https://pantsbuild.org/ logo
Powered by
#general
  • r

    rough-minister-58256

    03/18/2016, 7:30 PM
    @clever-ambulance-21321: generally you'd put the majority of your application code in a 
    python_library
    and then use a 
    python_binary
    that depends on those libraries w/ some single-file entrypoint as the runner. this makes it easier to test the 
    python_library
    bits because they’re importable and makes your 
    python_binary
    targets more composable.
  • c

    clever-ambulance-21321

    03/18/2016, 7:31 PM
    kwlzn: That makes a lot of sense when this grows, but right now it's a single file flask app haha
  • c

    clever-ambulance-21321

    03/18/2016, 7:31 PM
    trying to start as simple as possible
  • a

    ancient-stone-50795

    03/18/2016, 7:31 PM
    I just realized I am on the hook for a release today.
  • r

    rough-minister-58256

    03/18/2016, 7:31 PM
    in that case you could just go with a 
    python_binary
    then
  • j

    jolly-chef-92794

    03/18/2016, 7:35 PM
    If we use the target indirection scheme, and someone wanted a jar_library to be used as 
    provided
    for libraries and as 
    runtime
    for junit tests, for example, you’d need a structure like
    Copy code
    jar_library(foo-library) <- target(foo-library-provided) <- java_library()
jar_library(foo-library) <- target(foo-library-runtime) <- junit_tests()
    or:
    Copy code
    jar_library(foo-library-provided) <- java_library()
jar_library(foo-library-runtime) <- junit_tests()
  • w

    witty-crayon-22786

    03/18/2016, 7:36 PM
    @jolly-chef-92794: which sortof implies that the scopes should actually differentiate between test/runtime/compiletime
  • w

    witty-crayon-22786

    03/18/2016, 7:37 PM
    and then whether deps are transitive is something else
  • w

    witty-crayon-22786

    03/18/2016, 7:37 PM
  • w

    witty-crayon-22786

    03/18/2016, 7:37 PM
    it seems more and more like scopes conflate a few things
  • j

    jolly-chef-92794

    03/18/2016, 7:38 PM
    “implies that scopes should differentiate between tests/runtime/compiletime” By that do you mean we should have a test scope in pants?
  • w

    witty-crayon-22786

    03/18/2016, 7:38 PM
    yes, potentially.
  • w

    witty-crayon-22786

    03/18/2016, 7:39 PM
    which would make it easy for the scope to be a property of the dep
  • j

    jolly-chef-92794

    03/18/2016, 7:39 PM
    I have looked over maven-is-broken-by-design in the past but it’s been a while
  • a

    ancient-stone-50795

    03/18/2016, 7:40 PM
    I would be ok with separating out 'intransitive' into an orthogonal property to be configured
  • c

    clever-ambulance-21321

    03/18/2016, 7:40 PM
    You guys know what might cause this error? TypeError: __init__() got multiple values for keyword argument 'sources'
  • l

    limited-country-20626

    03/18/2016, 7:40 PM
    Can I get a few eyes on https://rbcommons.com/s/twitter/r/3538/? It has been up for a couple weeks - I would like to close out the Android work I did during the summit. When it was posted it was dependent on other RBs- that is no longer the case so I reran Travis with just this patch.
  • w

    witty-crayon-22786

    03/18/2016, 7:41 PM
    @ancient-stone-50795, @jolly-chef-92794 : it seems like the transitivity is almost certainly another thing, yea
  • w

    witty-crayon-22786

    03/18/2016, 7:42 PM
    in particular, for 
    strict_deps
    targets, just having a 
    scope=compile
    without any effect on transitivity would be sufficient
  • j

    jolly-chef-92794

    03/18/2016, 7:43 PM
    Intransitive could be it’s own thing. I’m concerned that this is a lot of trouble to add extra syntax with little benefit
  • j

    jolly-chef-92794

    03/18/2016, 7:44 PM
    I still think splitting this up into a bunch of different cases and separate targets adds lots of unnecessary build file verboseness
  • w

    witty-crayon-22786

    03/18/2016, 7:44 PM
    hm, on the contrary, if the scope for hadoop was a declaration of "needed at compile time and test time, but not deploy time", then it would be supremely non verbose
  • w

    witty-crayon-22786

    03/18/2016, 7:45 PM
    because if the transitivity is something else, where would transitivity features be used?
  • w

    witty-crayon-22786

    03/18/2016, 7:45 PM
    mostly annotation processors
  • w

    witty-crayon-22786

    03/18/2016, 7:45 PM
    ...or not even there
  • c

    clever-ambulance-21321

    03/18/2016, 7:45 PM
    I've put my entire BUILD file and stack trace into a gist if that helps: https://gist.github.com/chicagobuss/73c298a3185f7a7abece
  • j

    jolly-chef-92794

    03/18/2016, 7:45 PM
    I think there are a couple weird cases in our repo involving multiple modules declaring the same symbols that would benefiit from it
  • w

    witty-crayon-22786

    03/18/2016, 7:46 PM
    mm, yea. but i think it might still be orthogonal
  • c

    clever-ambulance-21321

    03/18/2016, 7:46 PM
    BUILD_file
    BUILD_file
  • c

    clever-ambulance-21321

    03/18/2016, 7:46 PM
    error.txt
    error.txt
1...106610671068...2420Latest