https://pantsbuild.org/ logo
Powered by
#general
  • h

    happy-kitchen-89482

    07/30/2015, 9:01 PM
    e.g., in our pants.ini we could say that all jvm-ish targets get an injected dep on 3rdparty:logback, or whatever
  • e

    enough-analyst-54434

    07/30/2015, 9:01 PM
    I can't see harm in making that easier to do declaritively. I personally have no truck with folks who aren't wiling to type the extra explicit dep, but I realize there is a lot of sentiment against that stance
  • e

    enough-analyst-54434

    07/30/2015, 9:02 PM
    It seems good to me to have to understand why you're adding an slf4j dep
  • e

    enough-analyst-54434

    07/30/2015, 9:02 PM
    manually
  • e

    enough-analyst-54434

    07/30/2015, 9:02 PM
    But you folks have auto build deps, so that doesn't fly
  • b

    bored-art-40741

    07/30/2015, 9:02 PM
    For every single target, even when the dep isn't used directly?
  • e

    enough-analyst-54434

    07/30/2015, 9:02 PM
    Yes
  • e

    enough-analyst-54434

    07/30/2015, 9:03 PM
    because logging in tests is not obviously a good thing!
  • b

    bored-art-40741

    07/30/2015, 9:03 PM
    Actually that's a good point. Buildgen could just inject it everywhere
  • e

    enough-analyst-54434

    07/30/2015, 9:03 PM
    So turn it on if you need it explicitly
  • h

    happy-kitchen-89482

    07/30/2015, 9:03 PM
    hah
  • h

    happy-kitchen-89482

    07/30/2015, 9:03 PM
    yes it could
  • e

    enough-analyst-54434

    07/30/2015, 9:03 PM
    In this case the target doesn't use it explicitly but the human does
  • e

    enough-analyst-54434

    07/30/2015, 9:03 PM
    they want logging
  • h

    happy-kitchen-89482

    07/30/2015, 9:04 PM
    @enough-analyst-54434: I see what you're saying, but logging is special in that it's a cross-cutting concern, and the test shouldn't need to know which logging implementation will be used at runtime
  • h

    happy-kitchen-89482

    07/30/2015, 9:04 PM
    that's what is being injected here
  • e

    enough-analyst-54434

    07/30/2015, 9:04 PM
    That's where I disagree, but am agreeing to disagree
  • h

    happy-kitchen-89482

    07/30/2015, 9:04 PM
    the code is logging regardless, the question is where those logs go
  • h

    happy-kitchen-89482

    07/30/2015, 9:04 PM
    and I'm not sure that's a decision on a test-by-test bases?
  • h

    happy-kitchen-89482

    07/30/2015, 9:04 PM
    basis?
  • h

    happy-kitchen-89482

    07/30/2015, 9:04 PM
    Maybe it is
  • e

    enough-analyst-54434

    07/30/2015, 9:05 PM
    I'm pretty fervently against tests outputting anything to the console / files, etc in the steady state
  • h

    happy-kitchen-89482

    07/30/2015, 9:05 PM
    If we fixed this one-time with buildgen, we'd never have the problem again because everyone would copy-paste that dep over...
  • e

    enough-analyst-54434

    07/30/2015, 9:05 PM
    obviously not in python though!
  • e

    enough-analyst-54434

    07/30/2015, 9:05 PM
    thats my jvm hat
  • h

    happy-kitchen-89482

    07/30/2015, 9:06 PM
    Thanks for the feedback! I'm hearing that this may not be important enough to be a feature?
  • h

    happy-kitchen-89482

    07/30/2015, 9:06 PM
    Tom Dyas tried to do this by adding slf4j to the :junit tool dep
  • h

    happy-kitchen-89482

    07/30/2015, 9:06 PM
    but then it got shaded
  • h

    happy-kitchen-89482

    07/30/2015, 9:06 PM
    which defeats the purpose
  • h

    happy-kitchen-89482

    07/30/2015, 9:07 PM
    And adding it to the shader rules for that tool seems arbitrary
1...104105106...2420Latest