https://pantsbuild.org/ logo
Powered by
#general
  • m

    mammoth-pharmacist-54215

    03/01/2016, 7:36 PM
    @limited-country-20626: I think I would rather make those api’s public when the android backend gets moved to contrib unless you expect his is going to happen very soon. Adding new public markers in the future isn’t a big deal.
  • l

    limited-country-20626

    03/01/2016, 7:37 PM
    yeah - sounds fine to me. I may first try to convert to JarsField - it looks to do what I need.
  • m

    mammoth-pharmacist-54215

    03/01/2016, 7:39 PM
    Great, I’ll go ahead and merge this then. Thanks for taking a look.
  • h

    happy-kitchen-89482

    03/01/2016, 9:32 PM
    Yeah, let’s err on the side of less public stuff simple smile
  • m

    mammoth-pharmacist-54215

    03/01/2016, 9:34 PM
    @benjy do we care that —foo+=bar doesn’t work well on xonsh? Its a pretty obscure shell.
  • b

    bored-art-40741

    03/01/2016, 9:37 PM
    Can it be escaped within that shell?
  • b

    bored-art-40741

    03/01/2016, 9:38 PM
    If so, I tend to favor the 99% case of bash
  • m

    mammoth-pharmacist-54215

    03/01/2016, 9:48 PM
    I haven’t been able to figure out a good way to escape it, looking though.
  • m

    mammoth-pharmacist-54215

    03/01/2016, 9:48 PM
    xonsh is a bit of a weird shell
  • b

    bored-art-40741

    03/01/2016, 9:49 PM
    Could also just support both, right?
  • b

    bored-art-40741

    03/01/2016, 9:49 PM
    +=
    and 
    --append
    for those who can't support it or don't like it for whatever reason
  • m

    mammoth-pharmacist-54215

    03/01/2016, 9:53 PM
    supporting both is probably a good idea… I like += but I could def see it messing with some shells
  • h

    happy-kitchen-89482

    03/01/2016, 10:35 PM
    Yeah, could support both.
  • l

    limited-country-20626

    03/02/2016, 2:42 AM
    How permanent is marking a class API: public at this point? I have a CR that moves android out of backend and into contrib. But I need to mark 
    import_jars_mixin
    public. I think I can convert the contrib.android plugin to not use it in a followup but this CR is already 10,000+ lines long or so. So can I mark is public in the move and add a TODO to convert the contrib module? cc @mammoth-pharmacist-54215
  • m

    mammoth-pharmacist-54215

    03/02/2016, 2:43 AM
    If its only public short term please don’t mark it public
  • m

    mammoth-pharmacist-54215

    03/02/2016, 2:44 AM
    once we commit to something being public its harder to undo it.
  • l

    limited-country-20626

    03/02/2016, 3:06 AM
    I don't have a plan around it. What are the guarantees around public? Can i still import into contrib or is it just discouraged?
  • l

    limited-country-20626

    03/02/2016, 3:16 AM
    okay, looks like there is no errors with using a non-public api so I will won't bother changing it at all.
  • w

    witty-crayon-22786

    03/02/2016, 4:48 PM
    anyone able to review https://rbcommons.com/s/twitter/r/3203/ ? cc @enough-analyst-54434
  • w

    witty-crayon-22786

    03/02/2016, 4:53 PM
    @limited-country-20626: the guarantees are all post-1.0.0, but they're listed here now thanks to Eric and Kris http://pantsbuild.github.io/deprecation_policy.html
  • l

    limited-country-20626

    03/02/2016, 5:06 PM
    Ah..great doc! I will have to roll the dice for now. I want to move android out of backend because it isn't maintained and so is a wart to have in "core" pants. But I can only put so much time into that...if I had time to work on it then it would be fine where it was.
  • w

    witty-crayon-22786

    03/02/2016, 6:20 PM
    @fancy-queen-20734: hey. i'm interested in extracting everything that doesn't have a 
    self == Task
    dependency to IvyUtils in order to begin using that stuff outside of tasks. thoughts?
  • w

    witty-crayon-22786

    03/02/2016, 6:21 PM
    is that going to step on stuff you have in flight?
  • f

    fancy-queen-20734

    03/02/2016, 6:21 PM
    probably
  • f

    fancy-queen-20734

    03/02/2016, 6:22 PM
    but I could update things after
  • w

    witty-crayon-22786

    03/02/2016, 6:22 PM
    should i avoid doing that at the moment?
  • f

    fancy-queen-20734

    03/02/2016, 6:22 PM
    I’ve actually been thinking of moving the opposite direction
  • w

    witty-crayon-22786

    03/02/2016, 6:22 PM
    orly
  • f

    fancy-queen-20734

    03/02/2016, 6:23 PM
    and removing the resolution specific logic out of ivy utils because a lot of it is closely tied to how ivy_task_mixin works
  • w

    witty-crayon-22786

    03/02/2016, 6:23 PM
    yea, but Tasks are going away, heh.
1...102310241025...2420Latest