https://pantsbuild.org/ logo
Powered by
#general
  • w

    witty-crayon-22786

    02/27/2016, 7:01 PM
    named collections of options
  • a

    ancient-stone-50795

    02/27/2016, 7:01 PM
    @many-engine-77019: isn't that what: 
    --compile-zinc-debug-symbols
    is for?
  • m

    many-engine-77019

    02/27/2016, 7:04 PM
    it was actually --compile-java-args="-C-g:lines,source,vars" --compile-scala-args="-C-g:lines,source,vars" --compile-zinc-java-args="-C-g:lines,source,vars"
  • m

    many-engine-77019

    02/27/2016, 7:05 PM
    it got fixed in pants after that
  • m

    many-engine-77019

    02/27/2016, 7:05 PM
    oh, jvm_options is a thing...
  • m

    many-engine-77019

    02/27/2016, 7:05 PM
    maybe
  • w

    witty-crayon-22786

    02/27/2016, 7:05 PM
    for arguments that 
    java
    understands
  • w

    witty-crayon-22786

    02/27/2016, 7:06 PM
    rather than the program
  • m

    many-engine-77019

    02/27/2016, 7:06 PM
    mostly that we set -Xmx1g in pants.ini in jvm_options in pants.ini and then many projects add additional properties with -D
  • w

    witty-crayon-22786

    02/27/2016, 7:07 PM
    mm
  • w

    witty-crayon-22786

    02/27/2016, 7:07 PM
    @many-engine-77019: but that is a case where things should be specified on some target, and currently aren;t
  • w

    witty-crayon-22786

    02/27/2016, 7:07 PM
    ie, that should be on their binary
  • w

    witty-crayon-22786

    02/27/2016, 7:07 PM
    jvm_binary(..., extra_jvm_options=[x,y])
  • w

    witty-crayon-22786

    02/27/2016, 7:08 PM
    garrett/eric have done a good job adding that kind of stuff to junit_tests, so there is precedent
  • m

    many-engine-77019

    02/27/2016, 7:08 PM
    mmm
  • m

    many-engine-77019

    02/27/2016, 7:08 PM
    well so the options I'm looking at are specifically for when running on a laptop
  • m

    many-engine-77019

    02/27/2016, 7:08 PM
    we could put those on a jvm_run target
  • m

    many-engine-77019

    02/27/2016, 7:09 PM
    but that might be getting crazy
  • w

    witty-crayon-22786

    02/27/2016, 7:09 PM
    list of 
    runs
    on the binary?
  • m

    many-engine-77019

    02/27/2016, 7:09 PM
    or that
  • w

    witty-crayon-22786

    02/27/2016, 7:09 PM
    but really, we've been missing a way to link all the way up to execution for a while
  • w

    witty-crayon-22786

    02/27/2016, 7:09 PM
    whatever happens there should have some concept of prod/dev/laptop
  • m

    many-engine-77019

    02/27/2016, 7:10 PM
    what about like -DSKIP_FLAKY=1 for tests?
  • w

    witty-crayon-22786

    02/27/2016, 7:10 PM
    that's built in now
  • w

    witty-crayon-22786

    02/27/2016, 7:10 PM
    ...oh. internally.
  • m

    many-engine-77019

    02/27/2016, 7:10 PM
    we define a global jvm option that's inherited all the way down?
  • w

    witty-crayon-22786

    02/27/2016, 7:10 PM
    @many-engine-77019: go/ktf
  • w

    witty-crayon-22786

    02/27/2016, 7:10 PM
    should be upstreamed though
  • m

    many-engine-77019

    02/27/2016, 7:10 PM
    fine that was an example
  • m

    many-engine-77019

    02/27/2016, 7:11 PM
    but we also have like -DCI_RUN
1...102110221023...2420Latest