#general
- w
witty-crayon-22786
02/24/2016, 7:27 PMbasically, if you set custom, you have to override everything - b
bored-art-40741
02/24/2016, 7:27 PMRegardless of its version - w
witty-crayon-22786
02/24/2016, 7:27 PMcorrect? - b
bored-art-40741
02/24/2016, 7:27 PMI don't mind that, but it's crazy confusing - b
bored-art-40741
02/24/2016, 7:27 PMAlso - b
bored-art-40741
02/24/2016, 7:27 PMCopy coderegister('--runtime', advanced=True, type=list_option, default=['//:scala-library'], help='Target specs pointing to the scala runtime libraries.', deprecated_version='0.0.75', deprecated_hint='Option is no longer used - m
mammoth-pharmacist-54215
02/24/2016, 7:27 PMcls.register_jvm_tool(register, name, classpath=classpaths) is where the tool is registered - b
bored-art-40741
02/24/2016, 7:27 PMCopy code@classmethod def _synthetic_runtime_target(cls, buildgraph): """Insert synthetic target for scala runtime into the buildgraph :param pants.build_graph.build_graph.BuildGraph buildgraph: buildgraph object :return pants.build_graph.address.Address: """ # If a custom runtime is specified return it instead of synthetic target # This will pull in user defined scala-library defs custom_runtime_spec = ScalaPlatform.global_instance().runtime[0] if ScalaPlatform.global_instance().version == 'custom': return custom_runtime_spec - b
bored-art-40741
02/24/2016, 7:27 PMThe option apparently is used if you specify 'custom' - m
mammoth-pharmacist-54215
02/24/2016, 7:28 PMso if you provide a definition for the tool in something like BUILD.tools it uses that otherwise it uses what you provide as the default. - m
mammoth-pharmacist-54215
02/24/2016, 7:28 PM@witty-crayon-22786: correct - m
mammoth-pharmacist-54215
02/24/2016, 7:29 PMbecause of the way the tool registration happens though if you don’t create a target //:scalac though it will fallback to something… this is probably what is causing the confusion because its not necessarily what you want. - b
bored-art-40741
02/24/2016, 7:30 PMYeah - b
bored-art-40741
02/24/2016, 7:30 PMIt was compiling with 2.10 - m
mammoth-pharmacist-54215
02/24/2016, 7:31 PMWe could have the compiler classpath method check if you have version set to custom and blow up if it see’s a synthetic target. - b
bored-art-40741
02/24/2016, 7:31 PMYeah, I'd say the default here should be to error on custom rather than default - b
bored-art-40741
02/24/2016, 7:31 PMSince the current default is very non-intuitive - m
mammoth-pharmacist-54215
02/24/2016, 7:31 PMI’d rather it blow up with a reasonable explanation of what the user has to do. - b
bored-art-40741
02/24/2016, 7:31 PMAgreed - m
mammoth-pharmacist-54215
02/24/2016, 7:31 PMseems reasonable enough to me. - m
mammoth-pharmacist-54215
02/24/2016, 7:32 PMhow urgently do you want/need me to get a patch together? - b
bored-art-40741
02/24/2016, 7:33 PMNo longer urgent now that I've figured out the workaround - m
mammoth-pharmacist-54215
02/24/2016, 7:33 PMsorry for the confusion 😞 - m
mammoth-pharmacist-54215
02/24/2016, 7:34 PMI’ll try and get a patch out asap but may not bee this week or next since I’m on dev0 support this week and in Montana next. - m
mammoth-pharmacist-54215
02/24/2016, 7:34 PMWhile I’m poking around in there I may add an option to specify the spec for scalac as well. - b
bored-art-40741
02/24/2016, 7:37 PMYeah I feel like it should just be, "take the defaults for 2.10 or 2.11" or "say you want custom, and you're required to fully specify a dictionary in pants.ini of bootstrap targets" - b
bored-art-40741
02/24/2016, 7:38 PMAnything in-between is an error - m
mammoth-pharmacist-54215
02/24/2016, 7:42 PM - f
fast-nail-55400
02/24/2016, 7:51 PMhow do I override the zinc that is used with the recent versions of pants?Copy codecls.register_jvm_tool(register, 'zinc', classpath=[ JarDependency('org.pantsbuild', 'zinc', '1.0.12') ], - f
fast-nail-55400
02/24/2016, 7:51 PMthat’s from zinc_compile.py