https://pantsbuild.org/ logo
Powered by
#general
  • r

    rough-minister-58256

    02/24/2016, 1:16 AM
    would assume some of us might meet for earlier breakfast perhaps
  • m

    mammoth-pharmacist-54215

    02/24/2016, 1:18 AM
    I’d be up for that if other people are getting together.
  • w

    witty-crayon-22786

    02/24/2016, 1:21 AM
    @wide-energy-11069, @limited-terabyte-34878 : https://rbcommons.com/s/twitter/r/3492/
  • m

    mammoth-pharmacist-54215

    02/24/2016, 1:58 AM
    I’m not sure how this test was supposed to pass if the timeout was set correctly: def test_exceeds_timeout(): time.sleep(120)
  • m

    many-engine-77019

    02/24/2016, 2:07 AM
    that's in testprojects
  • m

    many-engine-77019

    02/24/2016, 2:07 AM
    I don't think it's supposed to pass
  • m

    mammoth-pharmacist-54215

    02/24/2016, 2:08 AM
    I see they are called by test_pytest_run_integration
  • m

    mammoth-pharmacist-54215

    02/24/2016, 2:08 AM
    yeah, it was running before because test_project_integration runs all those tests… but the timeout wasn’t getting caught because of a bad setting in pants.ini
  • m

    mammoth-pharmacist-54215

    02/24/2016, 2:09 AM
    also probably making our tests take much longer than they should.
  • m

    many-engine-77019

    02/24/2016, 2:09 AM
    hmm I actually tried --no-timeouts yesterday and it didn't seem to work
  • m

    mammoth-pharmacist-54215

    02/24/2016, 2:10 AM
    I guess there was an option change at some point for timeouts… pants.ini had an old value. @wide-energy-11069 caught it with his last review.
  • m

    many-engine-77019

    02/24/2016, 2:11 AM
    oh I see
  • m

    many-engine-77019

    02/24/2016, 2:12 AM
    wait
  • m

    many-engine-77019

    02/24/2016, 2:12 AM
    is there really a test that sleeps for 2 minutes?
  • m

    many-engine-77019

    02/24/2016, 2:12 AM
    that sounds kind of excessive
  • m

    mammoth-pharmacist-54215

    02/24/2016, 2:13 AM
    the test sets the timeout really low
  • m

    mammoth-pharmacist-54215

    02/24/2016, 2:14 AM
    I think 1 second so it fails almost immediately but the sleep is for 2 min
  • m

    mammoth-pharmacist-54215

    02/24/2016, 2:14 AM
    when you run it as an integ test if there is no timeout it eventually passes after 2 minutes
  • m

    mammoth-pharmacist-54215

    02/24/2016, 2:18 AM
    @many-engine-77019: if you are interested: https://rbcommons.com/s/twitter/r/3491/
  • w

    witty-crayon-22786

    02/24/2016, 2:51 AM
    the 
    timeout=
    parameter is now documented on http://pantsbuild.github.io//build_dictionary.html
  • w

    witty-crayon-22786

    02/24/2016, 2:51 AM
    @many-engine-77019: 
    timeout
    is scoped... so you need 
    --test-junit-timeouts
    probably
  • m

    many-engine-77019

    02/24/2016, 2:51 AM
    yeah I mean I was running ./pants test.pytest --no-timeouts
  • m

    many-engine-77019

    02/24/2016, 2:52 AM
    it's also possible it was working and just not doing what I wanted
  • m

    many-engine-77019

    02/24/2016, 2:52 AM
    (I was running a unit test that SIGALRM'd, which conflicted with pytest SIGALRM's, so I wanted to shut those up)
  • m

    mammoth-pharmacist-54215

    02/24/2016, 2:52 AM
    @witty-crayon-22786: thanks for getting that out so fast.
  • m

    mammoth-pharmacist-54215

    02/24/2016, 2:53 AM
    timeout fix is merged so hopefully we’ll have a green build soon.
  • w

    witty-crayon-22786

    02/24/2016, 2:53 AM
    cool, thanks.
  • m

    mammoth-pharmacist-54215

    02/24/2016, 2:54 AM
    no problem
  • w

    wide-energy-11069

    02/24/2016, 6:24 AM
    @mammoth-pharmacist-54215: oops sorry missed your ping on that rb
  • m

    mammoth-pharmacist-54215

    02/24/2016, 6:25 AM
    No worries
1...100210031004...2420Latest