https://pantsbuild.org/ logo
Powered by
#general
  • r

    rough-minister-58256

    02/23/2016, 10:00 PM
    yeh I think he said he got it working w/ the access token
  • a

    ancient-stone-50795

    02/23/2016, 10:00 PM
    Yes, I set that up and it worked.
  • m

    mammoth-pharmacist-54215

    02/23/2016, 11:03 PM
    qq for everyone… I have a bunch of modules that don’t look like we intend for them to be called as part of the API. I don’t want to be the sole decider but there is nothing to review since marking them as private is a noop. Should I just post a list of modules here and get opinions or tack it on another for some other modules?
  • w

    witty-crayon-22786

    02/23/2016, 11:05 PM
    @mammoth-pharmacist-54215: when in doubt, not public.
  • w

    witty-crayon-22786

    02/23/2016, 11:05 PM
    can mark aggressively later if people request.
  • w

    witty-crayon-22786

    02/23/2016, 11:05 PM
    but yea, can always ask here
  • m

    mammoth-pharmacist-54215

    02/23/2016, 11:05 PM
    so to me all the modules in core_tasks seem like they should be non-public
  • w

    witty-crayon-22786

    02/23/2016, 11:05 PM
    or, alternatively, propose a big list of stuff as private on the mailing list and see whether anyone needs it
  • m

    mammoth-pharmacist-54215

    02/23/2016, 11:06 PM
    no one is currently using them in plugins and I’m not sure we would want people to
  • w

    witty-crayon-22786

    02/23/2016, 11:06 PM
    i think that 
    src/python/pants/core_tasks/changed_target_tasks.py
    is supposed to be public? but it's not documented super well, so hard to tell. other than that, yea... private?
  • w

    witty-crayon-22786

    02/23/2016, 11:07 PM
    ...oh, no: correction. the contents of that file should not be public. but 
    src/python/pants/core_tasks/noop.py
    should be
  • w

    witty-crayon-22786

    02/23/2016, 11:07 PM
    ...and i think that's it.
  • m

    mammoth-pharmacist-54215

    02/23/2016, 11:07 PM
    is anyone using changed_target_tasks now?
  • w

    witty-crayon-22786

    02/23/2016, 11:07 PM
    foursquare might be
  • m

    mammoth-pharmacist-54215

    02/23/2016, 11:08 PM
    so Noop compile and test should be public?
  • m

    mammoth-pharmacist-54215

    02/23/2016, 11:09 PM
    I’ll put out a RB with those marked public and make sure I add a wide net in the reviewers so people can chime in.
  • m

    mammoth-pharmacist-54215

    02/23/2016, 11:10 PM
    @witty-crayon-22786: thanks
  • f

    fancy-queen-20734

    02/23/2016, 11:24 PM
    Does anyone use mutable for jars? My guess would be not, since its current behavior would be a little tricky to use.
  • f

    fancy-queen-20734

    02/23/2016, 11:24 PM
    It also has no test cases
  • h

    happy-kitchen-89482

    02/23/2016, 11:35 PM
    Is this CI timeout issue known?
  • m

    mammoth-pharmacist-54215

    02/23/2016, 11:35 PM
    what CI timeout issue?
  • h

    happy-kitchen-89482

    02/23/2016, 11:37 PM
    Shard #7 appears to fail on timeouts on my change and on stu’s totally unrelated change.
  • w

    witty-crayon-22786

    02/23/2016, 11:38 PM
    @limited-terabyte-34878: ^ related?
  • h

    happy-kitchen-89482

    02/23/2016, 11:39 PM
    I may be misreading this though
  • h

    happy-kitchen-89482

    02/23/2016, 11:39 PM
    It just seems suspicious that that shard is taking a LOT longer to run than the others.
  • m

    mammoth-pharmacist-54215

    02/23/2016, 11:40 PM
    seems suspect
  • m

    mammoth-pharmacist-54215

    02/23/2016, 11:41 PM
    has restarting it helped?
  • h

    happy-kitchen-89482

    02/24/2016, 12:03 AM
    Nope, restarting led to the same problem
  • h

    happy-kitchen-89482

    02/24/2016, 12:03 AM
    ~24 minutes, in both cases
  • h

    happy-kitchen-89482

    02/24/2016, 12:03 AM
1...99910001001...2420Latest