@witty-crayon-22786 do you know what's up with this for remote execution? I'm surprised w/ the INFO logs

I’m trying to streamline our CI, which is not in a great state at the moment. Two questions regarding fs_util in thread:

Oof, it's rough out there in the wild wild interwebs

Working on adding

fix

, Q on some UX. Should

fix

include formatters by default (and have a

--skip-formatters

flag, akin to

lint

)? I think it's a nicer UX as

fix

isn't meant to be run in a loop (buyer beware) as it'll blast your code. Running both fixers/formatters means people can still have a one-command "fix everything" goal.

fmt

will remain unchanged.

Please install Rustup and ensure `rustup` is on your PATH (usually by adding ~/.cargo/bin). See <https://rustup.rs>.

@happy-kitchen-89482 related to your changes? https://github.com/pantsbuild/pants/actions/runs/3231220886/jobs/5296430521

@narrow-vegetable-37489 I see you added

add-trailing-comma

in

experimental

to avoid the

fmt

v

fix

discussion. Time to have it 😛

What's our policy on promoting things out of experimental? Pointer to new code? Pointer + deprecation warning? Just move it?

Just a little 💭 about Python formatter additions. For every Python style formatter, we should consider duplicating it in

build_files

. Thinking of

add-trailing-comma

currently (I don't expect contributors to remember this, so we should as reviewers. Or invent a way to make this declarative 😛) (consider because

isort

makes no sense 😛)

And while I'm being a squeaky wheel:

fix

! 🎉 https://github.com/pantsbuild/pants/pull/17202

it looks like the macOS shards might be broken on main: claiming that rustup is not installed: https://github.com/pantsbuild/pants/actions/runs/3231218773/jobs/5290509559

hey folks, I'm writing tests and I'm confused. Using a RuleRunner I've copypasted from another test, I'm hitting:

E           pants.core.util_rules.system_binaries.BinaryNotFoundError: Was not able to locate a Python interpreter to execute rule code.
E           
E           Please ensure that Python is available in one of the locations identified by `[python-bootstrap].search_path`, which currently expands to:
E           
E           []

I'm not really sure what's up. I feel like I've dealt with this before, maybe I needed to pass my path through or something? is that necessary if I want a PythonSetup to show up?

(Sorry y'all I accidentally pushed a branch to

origin

that should've been on my fork (

fixgoal

for https://github.com/pantsbuild/pants/pull/17202). It'll be deleted as soon as I merge)

it would be helpful to avoid re-basing or merging dependabot reviews in the middle of the day, because it ties up CI resources

@hundreds-father-404: re: https://github.com/pantsbuild/pants/pull/17198

@happy-kitchen-89482: while you’re CI’ing: one thing i noticed yesterday (and then experimented with a bit) is that our commit-message based skipping skips Steps, but not Jobs

Relatedly, I can merge this PR with a job still running: https://github.com/pantsbuild/pants/pull/17202

seeing those:

20:41:15.86 [WARN] DEPRECATED: Not setting `Goal.environment_migrated=True` for `Goal` `auth-token-info` is scheduled to be removed in version 2.17.0.dev0.

See <https://www.pantsbuild.org/v2.15/docs/plugin-upgrade-guide>

20:41:15.86 [WARN] DEPRECATED: Not setting `Goal.environment_migrated=True` for `Goal` `auth-token-check` is scheduled to be removed in version 2.17.0.dev0.

See <https://www.pantsbuild.org/v2.15/docs/plugin-upgrade-guide>

📣 Reminder: Pants Team monthly meetup is this Monday. We've got a packed agenda, which team members can preview in the doc attached to your calendar invite. See ya Monday! (If you're a member of Pants Team and haven't received a calendar invite for this month's meetup, please fill in https://forms.gle/rFL98fitRYL33Df9A)

How do we get rid of all the

[WARN] DEPRECATED: Not setting Goal.environment_migrated=True`` for `Goal` `update-build-files`
is scheduled to be removed in version 2.17.0.dev0.

in the pants repo?

@witty-crayon-22786 refresh my memory on where we are w.r.t. target fields having async values? (Namely async defaults)

🔪 🥫 🪱 Okay... I've made a good bit of progress on a proposal for a new deprecation policy. The big change of this policy from the existing one is that it recommends never deprecating public APIs (with a few exceptions). I've included some analysis of different personae that are using Pants, and it's just really hard to make any kind of meaningful user-centric justification for the current deprecation policy. And while I've tried to avoid diving into implementation recommendations in this document, it really seems to me that this could be fairly easily maintained with an alias/translation layer feature that could translate between old options/defaults and new ones. This is still a work in progress, but I'd love some feedback on this. More in 🧵

@witty-crayon-22786 any suggestions for how to debug this remote execution failure?

Thread re removing our git hooks:

Getting this on

./pants_from_sources dependencies helloworld/translator/translator_test.py

in

example-python

00:57:24.50 [WARN] Pants cannot infer owners for the following imports in the target helloworld/translator/translator_test.py:tests:

  * pytest (line: 4)

If you do not expect an import to be inferrable, add `# pants: no-infer-dep` to the import line. Otherwise, see <https://www.pantsbuild.org/v2.15/docs/troubleshooting#import-errors-and-missing-dependencies> for common problems.

This goes away if I add

pytest

to my requirements.txt (

//:reqs#pytest

) - but is that the correct resolution to this? Pytest is provided by pants, so shouldn't this dep be owned or found somewhere?

Is it possible to get the absolute path to these venvs? I see that

mypy

uses the shim script as the python executable, but I'm wondering if we can just get the absolute venv location out of this data structure?

requirements_venv_pex = await Get(
        VenvPex,
        PexRequest(
            output_filename="requirements_venv.pex",
            internal_only=True,
            pex_path=[requirements_pex],
            interpreter_constraints=InterpreterConstraints(["==3.9.15"]),
        ),
    )

requirements_venv_pex.venv_rel_dir

@witty-crayon-22786 not entire sure about this test failure — https://github.com/pantsbuild/pants/actions/runs/3266607854/jobs/5370779975 — would it be OK in your view to strip the deprecation warnings out of the stderr as a way to deal with the excess output?

Ugh the build wheels jobs have been failing again starting today, across multiple PRs. E.g. macOS 10.15 intel saying that Pantsd is timing out while initializing https://github.com/pantsbuild/pants/actions/runs/3267360934/jobs/5372439004

Fishing for opinions on

fix

fmt

UX: https://github.com/pantsbuild/pants/discussions/17237

And while I'm fishing. I need a home for the

BUILD

file deprecations fixer. I'm proposing we might want a "meta" bucket for backends and this might belong (because eventually it'll encompass

pants.toml

and be a bit of a "deprecations" fixer for all of Pants) Other "meta" plugins that could join • Plugin to find and error on redundant

dependencies

declarations Thoughts?