pantsbuild #development

Channels

welcome

github-notifications

development

bitter-ability-32190

10/08/2022, 12:48 AM

Yeah

wide-midnight-78598

10/08/2022, 12:48 AM

👍 Testing now

wide-midnight-78598

10/08/2022, 12:52 AM

hahaha, I just pulled down a change that removed registration_rules - and here I was wondering what changed between 6 hours ago and now 🤦‍♂️

bitter-ability-32190

10/08/2022, 12:57 AM

Josh did 😛

bitter-ability-32190

10/08/2022, 12:58 AM

Eric rightfully pointed out it was a silly name when everything else uses

rules

wide-midnight-78598

10/08/2022, 12:59 AM

Yeah, fair enough - just amusing

wide-midnight-78598

10/08/2022, 12:59 AM

Does any of the target vs targetless partitioning touch typecheck code?

hundreds-father-404

10/08/2022, 2:49 AM

*Stu pointed out heh

hundreds-father-404

10/08/2022, 2:49 AM

and yeah, you will want to register both the target types & rules. I've wondered in the past whether we should have it that activating

pants.backend.python.lint.black

is enough, that you don't need to also activate

pants.backend.python

hundreds-father-404

10/08/2022, 2:50 AM

we already have tests to ensure that activating any single backend will not result in rule graph ambiguity (which happened a few times while trying to stabilize 2.0!). But it might not be useful w/o target types registered etc

wide-midnight-78598

10/08/2022, 2:51 AM

Really? I don't think I've seen target types registered for plugins, unless they have new tyes

hundreds-father-404

10/08/2022, 2:52 AM

yeah, that's what I mean. Right now, plugins don't ever activate target types from other backends, so you must register the dependent backends. I was proposing changing that, but it didn't happen

wide-midnight-78598

10/08/2022, 2:55 AM

Ahhh, I see

wide-midnight-78598

10/08/2022, 2:56 AM

I noted that we did it in unit tests, but not in registration, which was weird - but I thought it was just pants magic

hundreds-father-404

10/08/2022, 2:56 AM

nothing stopping you from doing it in your own backends though

hundreds-father-404

10/08/2022, 2:56 AM

or changing Pants to do it; I don't think anyone was majorly blocking, more "this seems low priority"

wide-midnight-78598

10/08/2022, 2:58 AM

I'll push what I have, and we can track something in the PR - so there is some tracing to reasoning

wide-midnight-78598

10/08/2022, 3:12 AM

https://github.com/pantsbuild/pants/pull/17163

enough-analyst-54434

10/08/2022, 4:22 AM

Question re docsite and dev releases. The docs say to cut new docs at dev0 which I read as, when you cut X.dev0, create the docsite for X: https://www.pantsbuild.org/docs/release-process#dev0---set-up-the-new-version. That, however, appears not to be done. Are the release docs stale or did this step just get missed when 2.15.0.dev0 was cut?

careful-address-89803

10/10/2022, 2:38 AM

hey could I have the error message for a missing QueryRule output something copypastable instead of the english rendition of that? something like

"return the type {}. Try registering QueryRule({} for {})."

"return the type {}. Try registering QueryRule({}, [{}])."

, and make sure the input types format correctly

happy-kitchen-89482

10/10/2022, 7:36 AM

If I’m understanding things correctly, we have a massive bug in our CI scripts: https://github.com/pantsbuild/pants/pull/17172

happy-kitchen-89482

10/10/2022, 7:36 AM

I think the only impact in practice was performance, but it could easily have been correctness as well

bitter-ability-32190

10/10/2022, 2:45 PM

Update: • The dust has mostly settled on all the

lint

and

fmt

changes. I kept it angled open for Dan's test batching change • We also have

_param_type_overrides

for

@rule

which should help us more easily write rule-maker code (E.g. default implementations of rules). I'm really hoping this will lead to some boilerplate reduction 😉 • Few more PRs on the horizon: ◦ ~~https://github.com/pantsbuild/pants/pull/17153 is open~~ ◦ Another PR to move the
FooResult
.create
methods onto the request type to reduce boilerplate further ◦ Still need to add
fix
and move the experimental tools over ◦ ~~And need to fix the double-logging issue when fmt results get promoted to lint results~~ ◦ ~~Helper for build file formatters~~ ◦ Move and deprecate `update-build-files` ◦ Maybe:

pants.toml

fixer?

BUILD

fixer? ◦ Maybe: Copy-writer? ◦ Likely: Pick up symlink WIP PR

🙌 1

hundreds-father-404

10/10/2022, 3:08 PM

Maybe deprecating

update-build-files

in favor of

fix

bitter-ability-32190

10/10/2022, 3:08 PM

Ah yeah, of course 👍

hundreds-father-404

10/10/2022, 3:09 PM

Plan for the week: mostly code review and helping users out. For now, I've been shifting to work on some Toolchain things rather than open source Please feel free to DM me if you want me to take a look at something!

happy-kitchen-89482

10/10/2022, 3:32 PM

I’ll not be doing much dev work, but will try to continue some CI improvements, look at @wide-midnight-78598’s pyright change, and maybe look at the AWS Lambda perf issue

✅ 1

🙌 2

👀 1

bitter-ability-32190

10/10/2022, 4:02 PM

Maybe 🐞 on 2.14.0rc3?

Copy code

MappingError: Failed to parse ./path/to/BUILD.pants:
Name 'wo_resolved_system_packages' is not defined.
...
All registered symbols: ['__defaults__', ..., 'wo_resolved_system_packages', ...]

🧵

✅ 1

happy-kitchen-89482

10/10/2022, 5:42 PM

Slow CI thread:

witty-crayon-22786

10/10/2022, 8:12 PM

@ancient-vegetable-10556, @hundreds-father-404: have posted two changes for https://github.com/pantsbuild/pants/issues/17129: • https://github.com/pantsbuild/pants/pull/17179 • https://github.com/pantsbuild/pants/pull/17155