now that we have some relevant files with spaces in their names, a potentially helpful command to “edit all files matching a grep”:

rg -0 -l 'Platform\.current' | xargs -o -0 vim

@fast-nail-55400: re: https://github.com/pantsbuild/pants/pull/16670

well, dang. it looks like converting `Platform`/`EnvironmentMatcher` into a parameter in https://github.com/pantsbuild/pants/pull/16682 runs smack into https://github.com/pantsbuild/pants/issues/12934#issuecomment-1049203868: basically, almost all real world

@union

usage now requires an

EnvironmentMatcher

to be part of its interface.

I've asked a variant of this before, but as there doesn't appear to be an existing mechanism to create a Subsystem which can either download from a url OR be setup from a system path, is there an approach I should take on this. Two mutually exclusive subsystems? New Subsystem type?

In order to make some moves on auto-generating shell completions (https://github.com/pantsbuild/pants/issues/16315)... I was waiting until we have time to think a bit more about how

export

should work, and then see if we can build an option to generate completions, as well as a venv. I'm on the fence about whether this is better or worse, but using

export

(or any goal) feels more like... dunno... I always associate those to targets and production code (and `export`ing a dev env to help out), while completions are related to the Pants tooling itself. So what about doing something more like

--version

?

./pants --completions

?

seeing a failure on the main branch:

Caused by:
    command ["/tmp/pants-sandbox-A9W6vX/.cache/pyoxidizer/python_distributions/python.1c490d71269e/python/install/bin/python3.9", "-m", "pip", "--disable-pip-version-check", "install", "--target", "/tmp/pyoxidizer-pip-installjeHPfR/install", "pantsbuild.pants-2.15.0.dev0-cp37-cp37m-linux_x86_64.whl"] exited with code 1
  --> ./pyoxidizer.bzl:21:30
   |
21 |     exe.add_python_resources(exe.pip_install(['pantsbuild.pants-2.15.0.dev0-cp37-cp37m-linux_x86_64.whl']))
   |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ PythonExecutable.pip_install()


error: calling pip install

to repo run

./pants package  src/python/::

(this is on linux, didn't try on mac).

@witty-crayon-22786 I came up with modeling for how a user specifies what environment a target should use. https://docs.google.com/document/d/1vXRHWK7ZjAIp2BxWLwRYm1QOKDeXx02ONQWvXDloxkg/edit#heading=h.l8tbyq7h6zch

I’m trying to figure out how to go about making a usable pyoxidizer release for Mac OS. Do we do any code signing for

native_engine

during CI? (ping @witty-crayon-22786)

is this a bug/broken window?

File "/Users/asher/.cache/pants/setup/bootstrap-Darwin-arm64/2.15.0.dev0_py39/lib/python3.9/site-packages/pants/engine/target.py", line 173, in __repr__
    f"default={repr(self.default)})"
AttributeError: 'PythonRequirementsField' object has no attribute 'default'

(I am playing around with some plugin APIs and stumbled across this when calling str on that on

resolve_to_requirements_fields

implemented here: https://github.com/pantsbuild/pants/blob/7251de9bb8aef692b4ffcfc62c36943983a51145/src/python/pants/backend/python/goals/lockfile.py#L252

How penalized will we be if I'm making a

Snapshot

for my plugin implementors and only some of them use the

Digest

(the other build their own from the

files

plus other info)

@hundreds-father-404: i’d like to start building atop https://github.com/pantsbuild/pants/pull/16714 once the naming is settled: otherwise my first commits in https://github.com/pantsbuild/pants/pull/16682 will probably be renaming it: fine either way, just let me know whether i should rebase on it as is, or wait for you to rename

I saw that there'd been a small effort to add sphinx documentation generation to pants a few months back but it got reverted - is there interest in moving forward on that / what would be involved?

I noticed that there are Oh My Zsh plugins for bazel, please, maven, ant, etc. https://github.com/ohmyzsh/ohmyzsh/wiki/Plugins Would you find it helpful to have a Pants plugin for Oh My Zsh? Are there any specific requests for what Oh My Zsh support of Pants would be? Is anyone interested in contributing?

flaky test on

main

from a PR I just landed. https://github.com/pantsbuild/pants/runs/8121604214?check_suite_focus=true#step:17:1194 -- will mark it ignored for now

https://github.com/pantsbuild/pants/pull/16735 is WIP (only for a few minor reasons) and it drastically changes linters (and soon to change formatters). Please take a look if you are interested and want to weigh in on the possible face of the format/lint plugin API.

Consider this a Pants engine joke:

class X:
    async def helper():
        pass

class Y(X):
    async def helper():
        return await Get(Snapshot, PathGlobs(["..."]))

@rule
async def my_rule(request: RequestType) -> RetType:
    if False:
        # Just for static scraping purposes
        Get(Snapshot, PathGlobs, None)

    x_or_y: X = get_some_X_or_Y_instance()
    foo = await x_or_y.helper()
    ...

Here’s the 2.13 release blog post draft. I plan on posting this later today assuming there’s no major blockers: https://docs.google.com/document/d/17ZiS4lGDWAwF0TFT2dzWQnRsbCNnDwYJY0rDNAq8asQ/edit?usp=sharing

@fast-nail-55400 re

docker_environment

target, you mentioned the image name like

centos6:latest

, but also a hash?

@witty-crayon-22786 what is the future of

Process(platform=)

?

Oof, we have some code that doesn't use engine mechanisms for executable discovery, like

python_bootstrap.py

and

asdf.py

. Those will need to run in the Docker container

I think I need to refactor

context.core.command_runners

to let you dynamically change which CommandRunners are used for a particular process, whereas right now it's the same for the whole Pants session *scheduler 🧵

Hello, I am on release rotation today. Would it be 2.15.0.dev1?

Hi, yes please 🙂

@hundreds-father-404, @bitter-ability-32190: re: naming for `in_scope_types`: i thought about renaming it, but couldn’t come up with anything better.

My contributions to in-repo docs were merged to

main

but don't seem to be overwriting the older versions of those pages that were in readme. Does the readme page need to be deleted in order for its in-repo version to take over?

looks like

main

is broken: getting a PR out shortly.

Following up on a discussion of the environments redesign I just had with @hundreds-father-404 regarding how this will affect Pants’ ease of adoption while we add in support for more advanced use cases. The tl;dr is that we think of environments as a new way of setting (applicable) subsystem options, rather than replacing them outright. Further commentary in-thread…

It's now possible (w/ a small diff) to have any arbitrary Python

Process

run in Docker, thanks to great work by @fast-nail-55400 😎 https://github.com/pantsbuild/pants/pull/16764#issuecomment-1235933533

Hi, still making progress on the release. I was able to remove most of the deprecations - https://github.com/pantsbuild/pants/pull/16768 However I am not sure about

InteractiveProcessRequest

https://github.com/pantsbuild/pants/blob/91d35dc323d3fd2e88d982d4abb9bfbc739305ab/src/python/pants/engine/process.py#L363-L381 Is this class supposed to be gone as well? If so, what should I do about the references around here for example? https://github.com/pantsbuild/pants/blob/1cdca117c7c6df7c7b5adb6012d64efbbb40e887/src/python/pants/backend/docker/goals/publish.py#L88 I tried using

InteractiveProcess.from(docker.push_image(tag, env)))

, but got rule errors.

(if the changes in the PR looks good, can also accept and land first. I can push out another one for the release notes. will come back to work on the release notes later this evening).