wide-midnight-78598
08/02/2022, 3:02 AMwitty-crayon-22786
08/02/2022, 3:12 PM2.13.0
`rc`: does anyone have anything they’d like to get in?fresh-cat-90827
08/02/2022, 5:00 PMancient-vegetable-10556
08/02/2022, 9:32 PMpkgutil.get_data
internally, because it’s not supported by PEP 304-style pluggable importers (PyOx…r uses one). The problem is that the replacement, importlib.resources
, cannot currently load resources from namespace packages, and the very first thing that Pants does on startup is load the VERSION
file from the pants
namespace package using get_data
.
There’s a backport library that fixes this issue, but that would require users install an external requirement into their python environment. One option is to vendor the code in (it looks relatively small).
Easier would be if I could move the VERSION
file into a non-namespace package. It appears, though, that our installer script depends on the location of the VERSION
file. I could leave the current version of the file as a symlink (or the importable version, for that matter).
Do we have a preference here?hundreds-father-404
08/03/2022, 3:14 PMhundreds-father-404
08/03/2022, 4:23 PMwitty-crayon-22786
08/03/2022, 9:01 PMwide-midnight-78598
08/04/2022, 1:49 PMflat-zoo-31952
08/04/2022, 4:09 PMpaths
is broken? It seems to be outputting []
no matter what, even for trivial dep paths like direct dependencies
sh-5.1$ ./pants dependees //tests/sorted_components.py:../testlib
//:testlib
//tests/local/components.py:../../testlib
sh-5.1$ ./pants paths --paths-from=//tests/sorted_components.py:../testlib --paths-to=//tests/local/components.py:../../testlib
[]sh-5.1$
hundreds-father-404
08/04/2022, 7:57 PMhundreds-father-404
08/04/2022, 8:17 PM[python].requirement_constraints
until we have landed local requirement support for Pex?ancient-vegetable-10556
08/04/2022, 8:20 PMhundreds-father-404
08/05/2022, 2:21 AM--path-mappings
should be a global option vs. per-resolve for local requirements?wide-midnight-78598
08/05/2022, 4:55 PMexpected_file_extensions
in a SingleSourceField
?
Does pants auto lower-case extensions when matching?happy-kitchen-89482
08/05/2022, 9:28 PMaverage-vr-56795
08/05/2022, 10:49 PMaverage-vr-56795
08/05/2022, 11:38 PMaverage-vr-56795
08/06/2022, 5:47 PM./build-support/bin/release.sh test-release
I'm told Installed version of Pants (2.14.0.dev4+git165bb828) did not match requested version (2.14.0.dev4)!
When I run PANTS_PEX_RELEASE=STABLE ./build-support/bin/release.sh build-universal-pex
I'm told:
ERROR: Could not find a version that satisfies the requirement pantsbuild.pants==2.14.0.dev4+git165bb828 (from versions: none)
ERROR: No matching distribution found for pantsbuild.pants==2.14.0.dev4+git165bb828
These seem... Conflicting? That one is stripping the git-sha where it shouldn't, and the other is requiring it where it doesn't see it?average-vr-56795
08/07/2022, 8:36 AMaverage-vr-56795
08/07/2022, 9:44 PMbitter-ability-32190
08/08/2022, 3:47 PMhappy-kitchen-89482
08/08/2022, 4:41 PMhundreds-father-404
08/08/2022, 5:57 PM[python].resolves_to_constraints_file
to let you hook up constraints files when generating a lockfile.
Unlike before, this option lets you specify tool "resolves" like pytest
and black
in the [python]
option. Whereas our conventional modeling would be [black].constraints_file
and so on.
Thoughts on what is preferable? This decision will apply to migrating [python].only_binary
to be [python].resolves_to_only_binary
bitter-ability-32190
08/08/2022, 6:28 PM2.13.0rc1
?bitter-ability-32190
08/08/2022, 8:37 PMupdate-build-files
, where should the plugin be located? pants.backend.build_files
?
(We have global options which use the term "build_file")
We might able to do something a la:
• pants.backend.build_files.fmt.black
and pants.backend.build_files.fmt.isort
?
• pants.backend.build_files.fix.upgrader
?happy-kitchen-89482
08/09/2022, 1:33 PMbitter-ability-32190
08/09/2022, 2:54 PMhundreds-father-404
08/09/2022, 10:41 PM[GLOBAL].plugins
and [mypy].extra_type_stubs
don't currently give any mechanism to set a lockfile 🧵hundreds-father-404
08/10/2022, 5:16 PMwide-midnight-78598
08/10/2022, 8:43 PMdefaults
or overrides
come in?
# In order for check to pass, we need some special compile options
cc_sources(
name="foo",
compile_options=["magicoption1", "magicoption2"]
)
cc_sources(
name="bar",
compile_options=["magicoption2", "magicoption3"]
)
// In order for this library to be built, it requires a certain compile option in all deps
cc_library(
dependencies=[":foo", ":bar"],
compile_options??? overrides?
)