hundreds-father-40403/05/2022, 12:40 AM
fast-nail-5540003/07/2022, 8:17 PM
target as its own dependency, but I don’t see that behavior for a
hundreds-father-40403/08/2022, 4:16 PM
hundreds-father-40403/08/2022, 9:21 PM
witty-crayon-2278603/09/2022, 12:21 AM
bitter-ability-3219003/09/2022, 3:55 PM
in the docs: https://www.pantsbuild.org/v2.10/docs/contributions-debugging If folks think it's good I'll copy to the other pages.
bitter-ability-3219003/09/2022, 4:42 PM
hundreds-father-40403/09/2022, 4:44 PM
to always generate using Pex JSON. But do we think it's valuable to indefinitely let users keep manually generating their requirements.txt style lockfiles, e.g. via pip-compile or poetry export?
ancient-vegetable-1055603/09/2022, 5:21 PM
hundreds-father-40403/09/2022, 7:11 PM
for building a PEX x lockfiles:
fast-nail-5540003/09/2022, 10:32 PM
down to just those generated from a
plain-fireman-4995903/10/2022, 10:07 AM
hundreds-father-40403/10/2022, 6:30 PM
fast-nail-5540003/10/2022, 7:23 PM
, how do I access the environment?
is empty except for
. Do I need to make an
to the engine?
hundreds-father-40403/10/2022, 9:47 PM
bitter-ability-3219003/11/2022, 12:07 PM
bitter-ability-3219003/11/2022, 9:04 PM
hundreds-father-40403/11/2022, 10:13 PM
, which means we're supposed to start
today/this weekend per our release strategy. We reflected in Pants 2.8 it was bad we violated this. Anyone trying to get things into 2.11 still?
bitter-ability-3219003/12/2022, 12:52 PM
flat-zoo-3195203/13/2022, 9:27 PM
with a rust toolchain installed in it? I'm not sure what all is needed to build pants or run GHA, but doing something targeted has got to be easier than a kitchen sink approach, right?
happy-kitchen-8948203/14/2022, 12:13 AM
happy-kitchen-8948203/14/2022, 12:14 AM
happy-kitchen-8948203/14/2022, 12:15 AM
flat-zoo-3195203/14/2022, 12:59 PM
narrow-vegetable-3748903/14/2022, 1:34 PM
. I have a few questions though since (to me) adding and using it is not as straight forward as a normal linter is. See thread!
narrow-vegetable-3748903/14/2022, 1:35 PM
needs a previous state to compare against in order to detect breaking changes. My naive approach is to simply piggyback on Pants'
to get the git workdir (from the currently protected
attribute) and `ChangedOptions.diffspec`/`ChangedOptions.since` to get the rev to compare the local tree against. If `ChangedOptions.diffspec`/`ChangedOptions.since` it can fall back on
, and if
then the linter will be skipped I guess? I'm not entirely sure how to put it all together.
seems to be callable from anywhere, so that should be simple enough, but
I'm struggling to get into my linter rule, probably because it's not intended to be used directly by rules but rather to determine which sources to provide the rules with. I'm also pondering about on how to structure the code and its options. The current linter is located in
. Is this even a linter, or is a test or a check? Right now I've renamed the current
and have introduce
. I imagine people will want the option to only enable/disable one of them, so bundling them in the same backend might not be the best approach. Then there's also the subsystem which I, of course, want to reuse for both, but should it be extended so
perhaps? I appreciate any and all feedback 🖖
bitter-ability-3219003/14/2022, 1:41 PM
just have your rule take in
as a parameter. Then use
hundreds-father-40403/14/2022, 4:53 PM
. https://github.com/pantsbuild/pants/issues/13724 tracks this - if you're interested, we'd be happy to write instructions Re different backends, it sounds like
might align with our notion of
is intended for heavier weight-things like typechecking and compilation