pantsbuild #development

Channels

welcome

github-notifications

announce

enough-analyst-54434

02/18/2022, 4:55 PM

@bitter-ability-32190 you're not wrong.

happy-kitchen-89482

02/18/2022, 4:56 PM

Even having this work just for MacOS would be a big win, since that's where we see a lot of the bootstrapping issues (at least that is my intuitive sense, I don't have firm numbers to prove this)

enough-analyst-54434

02/18/2022, 4:56 PM

The issue is we're semi-punters on this already (limited time & resources, not poor intent) and this just adds more maintenance burden. It may be the only way to go though.

bitter-ability-32190

02/18/2022, 4:57 PM

If I peer into my crystal ball, I don't see a wholesale switch from current art into PyOxd Pants in one go. It'll be a process.

enough-analyst-54434

02/18/2022, 4:57 PM

@happy-kitchen-89482 I think you're right there and mac won't have these compatibility issues like Linux.

happy-kitchen-89482

02/18/2022, 4:57 PM

Yeah

brew install pants

may not be the way - we likely want to continue to have the version locked at the repo level, and not dependent on the system

bitter-ability-32190

02/18/2022, 4:57 PM

I'm down to try out whatever bleeding edge and lightly advocate for my engs to do the same, FWIW

happy-kitchen-89482

02/18/2022, 4:57 PM

System pythons on linux seem more stable and standard that system pythons on MacOS, which are notorious

hundreds-father-404

02/18/2022, 4:58 PM

See https://pantsbuild.slack.com/archives/C0D7TNJHL/p1644006730554629?thread_ts=1643992726.399819&cid=C0D7TNJHL. I like Andreas's approach a lot that you essentially brew install the Pants installer, and that installer then installs the binary based on each project's

pants_version

🙌 1

✅ 1

enough-analyst-54434

02/18/2022, 4:58 PM

The only known issue over 12 years on Linux is packaging. Debian splits up Python into a few packages.

enough-analyst-54434

02/18/2022, 5:00 PM

@hundreds-father-404 the issue is "the installer then installs the binary". It would mean the installer would have to have logic to "brew install". Maybe ok, but that's the rub I think @happy-kitchen-89482 is pointing out.

bitter-ability-32190

02/18/2022, 5:01 PM

...I think the installer downloads the binary (not unlike today's art)

➕ 1

bitter-ability-32190

02/18/2022, 5:01 PM

"installs" is a loose term

hundreds-father-404

02/18/2022, 5:02 PM

Yeah precisely, e.g. downloads the binary from our Pantsbuild S3. The only thing you brew install is the installer script

enough-analyst-54434

02/18/2022, 5:03 PM

Well the point of this thread is that doesn't work - libcrypt.so.1. But I guess you're referring to mac.

enough-analyst-54434

02/18/2022, 5:04 PM

The script is really neither here nor there. Important for UX but trivial. The issue to solve is the binary thing. That's hard.

✅ 1

➕ 1

witty-crayon-22786

02/18/2022, 5:12 PM

it had been assuming that to reduce the number of variables, our migration path would still involve the pants script, but having it fetch a PEX or binary. other changes to distribution model could follow that

👆 2

👍 1

ancient-vegetable-10556

02/18/2022, 6:11 PM

At the moment, it looks like dependencies of JVM source files are assumed to be able to be turned into a

ClasspathEntry

, which is not true for

file

targets. As I go through and break this assumption, I’m wondering if I should be silently ignoring all non-classpath dependencies when assembling the classpath, or if I should have some way of affirmatively opting into this behaviour. (@witty-crayon-22786 @fast-nail-55400)

witty-crayon-22786

02/18/2022, 10:41 PM

@wide-midnight-78598: if you have time to add any docs for the new pyoxidizer support, it would be appreciated: if not, that’s fine too. maybe to one or all of: • https://www.pantsbuild.org/v2.10/docs/python-package-goal • https://www.pantsbuild.org/v2.10/docs/pyoxidizer

happy-kitchen-89482

02/22/2022, 5:09 PM

🤦 just noticed that the generated docs will leak the homedir of whoever generated them: https://www.pantsbuild.org/docs/reference-global#section-pants-distdir

fast-nail-55400

02/22/2022, 8:55 PM

In a

BuiltinGoal

, how do you retrieve the

OptionsBoostrapper

used?

fast-nail-55400

02/22/2022, 11:43 PM

BSP design question: what to do for JVM compiled classfiles: https://github.com/pantsbuild/pants/issues/14562 (comments welcome)

fast-nail-55400

02/22/2022, 11:50 PM

another BSP design question: exposing generator targets and not file-level targets via BSP: https://github.com/pantsbuild/pants/issues/14563 (comments welcome)

happy-kitchen-89482

02/23/2022, 2:28 AM

2.11.0.dev1 release prep PR: https://github.com/pantsbuild/pants/pull/14567

fast-nail-55400

02/23/2022, 6:28 PM

@ancient-vegetable-10556: Is there any way to obtain the absolute path to

JAVA_HOME

via

JdkEnvironment

fast-nail-55400

02/23/2022, 6:48 PM

rule graph question. I have a synchronous invocation of the engine (for BSP) that is adding a “context” type as a second

subject

for the engine execution request. I am getting this error:

Copy code

ValueError: Encountered 4 rule graph errors:
  No installed rules return the type BSPContext, and it was not provided by potential callers of @rule(pants.backend.scala.bsp.rules:67:bsp_resolve_all_scala_build_targets(ScalaBSPBuildTargetsRequest, AllScalaTargets, BSPContext) -> BSPBuildTargets, gets=[Get(BuildTarget, ResolveScalaBSPBuildTargetRequest)]).

And adding

QueryRule(BSPContext, ())

did not help (same error). Thoughts?

witty-crayon-22786

02/23/2022, 8:30 PM

for wider visibility to maintainers: branch protection is currently disabled for cherry-picks to stable branches until we can determine how to cherry-pick notes directly while still requiring CI in general. please double check the Merge button before clicking it. see the thread in #G0107QFGGAW for more info.

bitter-ability-32190

02/24/2022, 2:36 PM

What do folks think about removing the implicit

default

for "scalar" option types (like

str

bool

int

) etc... in the new

XOption

descriptor classes? The reasoning is that (especially for bool, although also for others) right now the implicit default of

None

isn't obvious. Users might expect a

StrOption

to have a default of

""

, etc...

bitter-ability-32190

02/24/2022, 6:44 PM

Shared in a thread. Sharing a little static HTML page to render dependencies. I'm using it with Bazel data to track migration but extended it for Pants and ran it on Pants itself. There's tons of rooms for more bell/whistles but I'll leave that for a later day

bitter-ability-32190

02/24/2022, 6:44 PM

pants.html