https://pantsbuild.org/ logo
Powered by
#development
  • w

    witty-crayon-22786

    01/14/2022, 9:24 PM
    until you’ve toggled the default of the flag mentioned in the warning, the 
    name
    argument won’t be supported
    ➕ 1
  • b

    bitter-ability-32190

    01/14/2022, 9:24 PM
    Let me set it and try again
  • w

    witty-crayon-22786

    01/14/2022, 9:25 PM
    …well, see the ticket: there are steps.
  • b

    bitter-ability-32190

    01/14/2022, 9:25 PM
    I'm getting really excited to see pants run on CI, even if it's experimental
  • b

    bitter-ability-32190

    01/14/2022, 9:27 PM
    Exception: Failed to watch filesystem for `/opt/buildagent/work/UUID/devops/terraform/s3/mcdtechlabs-devops-logs-east`: Error { kind: Io(Os { code: 28, kind: StorageFull, message: "No space left on device" }), paths: [] }
  • b

    bitter-ability-32190

    01/14/2022, 9:28 PM
    I think I need to set an ignore path
  • w

    witty-crayon-22786

    01/14/2022, 9:28 PM
  • w

    witty-crayon-22786

    01/14/2022, 9:29 PM
    …or, yea: if you can ignore things then that is great too.
  • b

    bitter-ability-32190

    01/14/2022, 9:29 PM
    I'm very afraid to change anything on our CI as this is all experimental, and I think our build agent owners wouldn't be pleased 😂
  • b

    bitter-ability-32190

    01/14/2022, 9:33 PM
    It seems if i dont watch the fs i dont get pantsd?
  • b

    bitter-ability-32190

    01/14/2022, 9:36 PM
    (I'm guessing some files exist on disk somewhere in my repo that aren't git ignored or similar)
  • b

    bitter-ability-32190

    01/14/2022, 9:37 PM
    (Because I don't se it locally)
  • w

    witty-crayon-22786

    01/14/2022, 9:50 PM
    It seems if i dont watch the fs i dont get pantsd?
    correct… that was out of an abundance of caution with that option.
  • w

    witty-crayon-22786

    01/14/2022, 9:52 PM
    we could likely add an even larger warning and allow 
    --pantsd --no-watch-filesystem
    , if that would be helpful.
  • b

    bitter-ability-32190

    01/14/2022, 9:53 PM
    Ill probably work with our CI guardians for when it is time
  • b

    bitter-ability-32190

    01/14/2022, 9:53 PM
    to set good numbers
  • h

    hundreds-father-404

    01/15/2022, 12:12 AM
    Follow up bikeshed: should 
    regex-lint
    be activated by default or you have to add a backend for it?
    w
    p
    c
    • 4
    • 13
  • w

    witty-crayon-22786

    01/15/2022, 12:25 AM
    i had a minor false-start with https://github.com/pantsbuild/pants/issues/13462 this afternoon, in that i started on adapting all formatters to return 
    FmtResults
    (similar to 
    LintResults
    , which allows linters to internally partition themselves), as that looked like a good alignment that would allow formatters to batch themselves using the explicit 
    BatchProcess
    API that i sketched on the ticket.
    f
    h
    • 3
    • 11
  • c

    curved-television-6568

    01/17/2022, 9:08 AM
    module naming style nit.
    Copy code
    pants.engine.target
pants.engine.fs
pants.util.docutil
...
pants.engine.addresses  # <= most of the other modules seem to stick singular form
  • c

    curved-television-6568

    01/17/2022, 9:10 AM
    Wondering if this is intentional or accidental.. and whether it’s worth cleaning up before stabilizing the PluginAPI.. ? (if it was accidental)
  • h

    happy-kitchen-89482

    01/17/2022, 4:02 PM
    Yeah, I generally prefer singular form, as the core concepts are singular
    👍 1
  • h

    happy-kitchen-89482

    01/17/2022, 4:02 PM
    I think this is accidental
  • c

    curved-television-6568

    01/17/2022, 4:42 PM
    so, is it desirable to address this? (pun intended) 😉
  • c

    curved-television-6568

    01/17/2022, 4:45 PM
    Just want to flag https://github.com/pantsbuild/pants/issues/14154 I’m not actively investigating that issue..
  • c

    curved-television-6568

    01/17/2022, 4:48 PM
    Perhaps we need some safeguards around the use of hadolint, in case it is sensitive to platform/libc versions etc?
  • h

    happy-kitchen-89482

    01/17/2022, 6:54 PM
    Thanks for flagging
  • p

    polite-garden-50641

    01/17/2022, 7:54 PM
    It likely introduces an issue/breaking change for external plugins and it also makes it harder (not impossible, but just adds a little bit more work and risk) for those plugins to support multiple pants versions. not a blocker but just something to keep in mind.
  • c

    curved-television-6568

    01/18/2022, 6:46 AM
    It should be possible to have an interim version deprecating the old name, while still being usable to help smooth the transition.
  • f

    flat-zoo-31952

    01/18/2022, 3:01 PM
    I recently reported a bug about tailor generating duplicate targets when 
    alias_mapping
    is defined. I took a swing at fixing this myself, but the code in 
    pants/core/goals/tailor.py
    was ... pretty abstract. I'm thinking the issue is that the putative targets are calculated before the alias mapping is defined. Is this generally the right place to be looking here?
  • h

    happy-kitchen-89482

    01/18/2022, 3:55 PM
    [Just reminding myself how this code works]
1...825826827...906Latest